Quantcast
Channel: Issues for Drupal core
Viewing all 297377 articles
Browse latest View live
↧

Can't rearrange view fields when in maintenance mode

January 28, 2017, 9:15 pm
$
0
0

Hey,

I just want to report a bug in the view's configuration.
When operating in maintenance mode, the "Operating in maintenance mode. Go online." appears everywhere...including the view's rearrange fields options. This causes the last field to remain hidden when there are 6 or more fields.

Duplicate:

  • turn on maintenance mode
  • make a view with 6+ fields
  • try rearranging the fields...you'll see that the last one doesn't appear...

Right now I'm managing with put:

.messages {  display: none;  }

in the google developer's tools, but it's really annoying...

Thanks for your time!

↧
Search

/admin/config/regional/date-time does not show the correct default format for short and medium format

October 19, 2012, 7:12 am
$
0
0

Problem/Motivation

Drupal uses the following fallback values for date formats.

variable_get('date_format_short', 'm/d/Y - H:i');
variable_get('date_format_medium', 'D, m/d/Y - H:i');
variable_get('date_format_long', 'l, F j, Y - H:i');

But in Date and time types settings page (/admin/config/regional/date-time), the following formats are selected as the defauts if the variables are not set.

short: Y-m-d H:i
medium: D, Y-m-d H:i

(There is no problem with the long format.)

Proposed resolution

Change the order of selectbox options to show the fallback values as default.

Remaining tasks

Review the patch.

User interface changes

None. Only the order of selectbox of date formarts is changed.

API changes

None.

Data model changes

None.

Original report by wavesailor

/admin/reports/dblog does not display the results using the correct date format specified for the site

I have the short date specified as

2012-10-19 16:07

but /admin/reports/dblog displays the results as:

10/19/2012 - 16:07
↧
↧

BlockContent::delete() should be preDelete() and needs to clear plugin definitions like postSave()

June 21, 2015, 2:38 am
$
0
0

Problem/Motivation

delete() is not guaranteed to be called, since it's just a shortcut for passing the entity to the delete() method of the entity storage handler.

The code needs to be moved into a preDelete() method, not that one receives an array of entities, so you need to call getInstances() in a foreach loop.

Also, just like postSave(), it needs to call the clearCachedDefinitions() method.. otherwise the old block content entity would still be visible on the block page.. should not be too hard to write a test for it.. delete one, then go to admin/structure/block and make sure it's not there as a link anymore.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
BugBecause old block content entity would still be visible on the block page
Issue priorityNormal - doesn't break functionality

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

↧

[upstream] Include CKEditor's Accessibility Checker plug-in

May 23, 2016, 7:14 am
$
0
0

Problem/Motivation

The CKEditor Accessibility Checker, formerly a proprietary plugin, has been released under the GPL.

Proposed resolution

This is a great time to look at bringing this accessibility checker in. Ideally it would be enabled by default in the Standard installation profile. This should help make content editors make their content better.

Remaining tasks

  • add Quail.js library to core (MIT license, maintainer is jessebeach).
  • add balloonpanel plugin to Drupal's custom CKEditor build.
  • add a11ychecker plugin to Drupal's custom CKEditor build.
  • add a11ychecker configuration options to Drupal\ckeditor\Plugin\CKEditorPlugin\Internal.
  • Write tests

User interface changes

Makes a new CKEditor plugin available - see demo video
Adds options relating to this plugin, for the text format configuration form.

API changes

None expected.

Data model changes

None expected.

↧

Use drupal_static_fast in drupal_html_id

December 18, 2015, 3:08 am
$
0
0

Problem/Motivation

drupal_html_id() is often called with the same IDs during form submissions.

With many files the &drupal_static calls become noticeable.

Proposed resolution

- Add drupal_static_fast pattern
- Optionally allow static caching

Remaining tasks

- Investigate cache hit ratio.

↧
↧

Add functionality to automatically remove Content and Field Mappings

July 15, 2014, 6:48 am
$
0
0

At the moment RDF module does not support automated deletion of stored mappings for Content Types and Fields. This would result in inconsistency once the users edit or delete Content Types and fields associated. Thus this functionality should be added to the rdf module.

How to create a content type + mapping using Drush

Having a way to quickly create content types with their RDF mappings is going to be quite useful to test this issue.
These instructions assume you are starting from a vanilla Drupal site with the standard profile installed. It already includes mappings for article, user and the tags taxonomy term bundle. It also assumes you've already deleted the article content type (for example to test this issue). Here is how to recreate the article content type (and if needed its RDF mappings too) using Drush:

- Export your configuration in the staging area: drush config-export staging -y
- It should be missing the article content type YAML file
- copy the original article content type definition YAML file located in the standard profile into your site staging area: cp core/profiles/standard/config/install/node.type.article.yml sites/default/files/config_2T8.../staging/
- optionally also copy the article RDF mapping (rdf.mapping.node.article.yml) if those were deleted (as they should be once the patch is working
- Import all of the config present in the staging area into your site: drush config-import staging -y
- Visit the content type listing page, the article content type should be back!

↧

A #default_value = 0 for #type radios checks all radios

December 23, 2011, 1:25 am
$
0
0

Problem

  • Specifying a '#default_value' => 0 in a set of radio button #options using string keys checks all options.

Example

$form['myradios'] = array('#type' => 'radios','#options' => array(
    0 => '- None -','one' => 'one','two' => 'two','three' => 'three',
  ),'#default_value' => 0,
);

Result:

<input id="edit-myradios-0" name="radios" value="0" checked="checked" class="form-radio" type="radio"><input id="edit-myradios-one" name="radios" value="one" checked="checked" class="form-radio" type="radio"><input id="edit-myradios-two" name="radios" value="two" checked="checked" class="form-radio" type="radio"><input id="edit-myradios-three" name="radios" value="three" checked="checked" class="form-radio" type="radio">

Example of steps to reproduce in core:

  • Edit any node view
  • Add 'Published' filter
  • Tick 'Expose ...'
  • Select '- Any -' under 'Published status'
  • Save filter
  • Go to filter form again. 'No' is selected instead of '- Any -'.
↧

*TempStore's missing @throws documentation

January 22, 2017, 12:17 am
$
0
0

\Drupal\user\PrivateTempStore

method@throwsnotes
::deleteTempStoreException
::setTempStoreException

\Drupal\user\SharedTempStore

method@throwsnotes
::deleteTempStoreException
::setTempStoreException
::deleteIfOwnerTempStoreExceptionvia ::delete
::setIfOwnerTempStoreExceptionvia ::set
↧
Search

Redesign the status report page

December 22, 2009, 6:20 am
$
0
0

Problem/Motivation

The current status report is informative but not highlighting the crucial information really well. A lot of key information gets lost in the rows of green, blue and other color indicators. From a design point of view this page could also be a lot more appealing.

Proposed resolution

We are looking for designers to pick up this page and propose a view alternatives. Yoroy and Bojhan will be available to guide any designers.

Remaining tasks

  • Add default styles for counters and general information #400 to system. Would be nice to get a designers perspective on this.
  • CSS clean-up (BEM conversion / remove class nesting)

User interface changes

The information will be separated in 3 regions:

Error counter at top

3 items with error/warning/checked if there are errors. Link to each item list.
Re-count of items checked if no errors. Link to item list.

General system information table

The aim for this region is to show the basic
info about the development environment.

  • Drupal version
  • Last cron run
  • Button to run cron
  • Web server info
  • PHP info
  • Database info
List of reports
  • Separated lists by Errors, Warnings and Checked.
  • The title for each list should be an anchor for each
    counter in the top regiom.
  • On mobile, thedescription is collapsed by default.

Designs

Status page (no errors)

Status page no errors

Status page (with errors)

Status page with errors

Status page (mobile)

Status page with errors on mobile

Status page in Bartik

Proposal.

API changes

None

Data model changes

None

↧
↧

Missing 'attributes' under 'options' in docs for Link::createFromRoute

October 13, 2016, 11:39 am
$
0
0

API page: https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Link.php/...

Enter a descriptive title (above) relating to public static function Link::createFromRoute, then describe the problem you have found:

In Link::createFromRoutean array with the key of attributes may be added to supply element attributes (class, title, etc). This is missing from the documented description of parameters, in the options section.

↧

File Field design update

October 17, 2013, 1:22 am
$
0
0

Problem/Motivation

In terms of interaction, file fields could be a lot more accessible. The style guide proposes both a new appearance and a new interaction design.

Proposed resolution

11.file-field.png

  1. Files can be added from the local filesystem using drag-and-drop, or using the traditional click-browse-attach workflow (which hands the action off to the OS and back)
  2. Files upload automatically once added by dropping or browsing.
  3. Uploaded files provide a preview where possible (images) or a file-type-specific icon where not.
  4. File fields with multiple attachments use progressive disclosure to reveal each additional slot in turn. They should support dropping multiple files onto a single dropzone to upload multiple files at once.
  5. The “Browse Library” functionality is speculative at this time, but designed to accommodate contrib.

An important reason to encapsulate much of this functionality, is that it tends to scale much better amongst many items and especially if placed between forms it can serve as a clear visual landmark.

Test Pages

  • A file field will have to be created and add to an existing content type

View all styleguide issues

↧

Add documentation to Extract process plugin

January 20, 2017, 3:49 pm
$
0
0

Add API documentation to the Extract process plugin.

↧

View output is not used for autocomplete display

January 15, 2014, 6:58 pm
$
0
0

Please also consider those that participated in #2714089: Views Filter by an entity reference view not working as expected when assigning issue credit.

Problem/Motivation

When an entity relation field displays options via a view the view fields are not used, instead it is the entity label. This is a regression from Drupal 7.x.

Proposed resolution

Update \Drupal\views\Plugin\EntityReferenceSelection\ViewsSelection::getReferenceableEntities() to return the Views result rather than just the entity label.

Remaining tasks

None.

User interface changes

None.

API changes

In order continue injecting dependencies, \Drupal\views\Plugin\EntityReferenceSelection\ViewsSelection::__construct() will add a $renderer parameter. However, as per the BC changes documentation, this is allowed in minor version releases.

Data model changes

None.

Original report:

I'd like to prepend the content type to the referenceable item titles in the field autocomplete. An entity reference view rewrites the title field as [type]: [title], and is selected as the "view used to select the entities".

This does not appear to work - the view is used to assemble the list (tested by adding a view filter), but the autocomplete continues to display the item titles only.

This is a regression from entityreference 7.x-1.x

↧
↧

Block layout action removes instance, but contextual link deletes all instances.

November 11, 2016, 12:33 pm
$
0
0

Problem/Motivation

Initially this issue was about changing the label of the contextual (delete) link to match the label in block-layout (remove). In fact the link in contextual links actually deletes the block and all of it's instanaces. This is too destructive an action to expose in a contextual link, since users are likely to think they are only removing a single instance when they are in fact removing all instances and any associated content.

Proposed resolution

Remove the 'delete' contextual link from blocks.

Remaining tasks

Create patch

User interface changes

There will be no 'delete' link on blocks.

API changes

?

Data model changes

?

↧

[META] Simplify / streamline codebase to allow accessibility tests to be extended for contrib themes

January 27, 2017, 5:53 pm
$
0
0

It would be really great if there was a simple process to extend core's tests for use in a contrib module to ensure that all of the accessibility improvements are not accidentally broken by the contrib module.

Initial idea:

  • Refactor / streamline / simplify the tests around accessibility so that they have a hierarchical structure:
    • Base tests for system output.
    • Each bundled theme would extend these to include any additional accessibility adjustments necessary for the theme, e.g. DOM-level adjustments where the output adds extra DIVs, etc.
  • Clearly document how a contrib theme would go about leveraging the core tests.
  • Later on.. create a generator in DrupalConsole to create the necessary test files for a given subtheme.
↧
Search

Can't filter by string 'date' when adding options in Views

January 24, 2017, 11:19 am
$
0
0

When adding fields, filters, etc., in Views I am unable to use the string 'date' in the Search field to narrow down the available options. This is because the string of searchable text is derived from the input label, which as far as I can tell always contains the word "update".

To reproduce:

1. Edit a view,
2. in the Fields area, click "Add",
3. type "date" into the Search field.

The list should be filtered to only "date"-related options, but instead nothing happens. (I initially thought the keyword search wasn't working at all.)

This problem doesn't exist in 7.x.

Proposed solution: Formulate the searchText from the <td class="title"> element, which does not have "Update " prepended, instead of <label>.

I'll upload a patch in a moment.

↧

Provide menu links for Drupal Upgrade UI pages

April 7, 2016, 2:47 am
$
0
0

Problem/Motivation

I assumed that there already is an issue for this, but I couldn't find.

The Drupal Upgrade UI module provides two pages /upgrade and /upgrade/log but there are no menu items for it.

Proposed resolution

Add menu items for the Administration menu, probably under /admin/config/development or under admin/structure if that is the location of the migrate tools module as well.

Remaining tasks

Decide where the menu items should be located.

User interface changes

API changes

Data model changes

↧
↧

Add README.txt to Bartik theme

June 16, 2016, 2:47 am
$
0
0

Add a README.txt for the bartik theme that includes instructions on changing Admin theme and changing theme for add / edit node pages.

↧

Views REST authentication is broken

November 6, 2016, 5:09 am
$
0
0

Problem/Motivation

List of authentication providers consists of module names, which are defined them. In this case an authentication cannot be configured, because providers with such names aren't exists.

Display configuration through UI.

Display configuration

Exported configuration

Exported configuration

Proposed resolution

Correct a computation of the authentication_providers variable for DI container inside of \Drupal\Core\DependencyInjection\Compiler\AuthenticationProviderPass::process() method.

Correct a computation of the options list for configuring the authentication (\Drupal\rest\Plugin\views\display\RestExport::getAuthOptions()).

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

↧

Fix new sniffs added in Coder 8.x-2.9

September 21, 2016, 4:17 am
$
0
0

There is a new release of the Coder module. Some new sniffs were added. Let's fix them.

↧
Viewing all 297377 articles
Browse latest View live
Search
<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>