Add ExportStorageFactory to allow config export in third party tools

February 27, 2019, 8:52 am

≫ Next: Fix grammar 'a' to 'an' when necessary

≪ Previous: Convert locale.compare.inc to a service

$

0

0

Problem/Motivation

Drupal 8 core currently does not have any API for configuration export.
This means that tools such as drush or the drupal console have come up with their own way of exporting configuration. The way they do that is by reading directly from the active configuration storage service.
This will make it very difficult in the future to improve the workflow with for example #3028179: Config Environment module (core experimental) without patching drush.
Currently CMI improvements working with config_filter get around this because config_filter decorates the sync storage and drush uses the sync storage service when no argument is passed to the commands and thus it only works in the default case.
With #2991683: Add configuration transformer API we are adding a new API that will make working with it much easier and also work with the zip workflow. But it should remain the responsibility of core to make sure that the API is called properly.

Proposed resolution

Add a new service: config.export.factory with a method getExportStorage()
In a first version in 8.7 this will just return a memory storage with the contents of config.storage.

Drush and console can check if the new service exists and get the storage from it or continue using config.storage directly if the site runs on 8.6.
Then in 8.8 when the environment module becomes an experimental module drush and console will not have to be patched.

Remaining tasks

Write patch.
review
commit

User interface changes

None

API changes

API addition. New service.

Data model changes

None.

Release notes snippet

TBD

---

Fix grammar 'a' to 'an' when necessary

February 10, 2017, 1:34 am

≫ Next: Umami Article Spanish Translation: Give it a go and grow your own herbs

≪ Previous: Add ExportStorageFactory to allow config export in third party tools

$

0

0

I see a lot of 'a' uses in comments instead of 'an'.

Ex:

• a entity
• a alt
• a author
• a image
• ...

Many modules and core files are concerned. I suggest to make all changes here instead of one issue per module since it's only minor documentation issue.

Umami Article Spanish Translation: Give it a go and grow your own herbs

January 27, 2019, 6:23 am

≫ Next: Umami Article Spanish Translation: Dairy-free and delicious milk chocolate

≪ Previous: Fix grammar 'a' to 'an' when necessary

$

0

0

Problem/Motivation

We need to translate this article to Spanish so we can demonstrate Drupal's multilingual capabilities.
This issue is to produce and agree a translation, not to actually incorporate it in Umami's installation process. That will be achieved in a follow-on issue.

Proposed resolution

Translate this article to Spanish so we can demonstrate Drupal's multilingual capabilities according to our Spanish language guidelines: #3011647: [policy, no patch] Standardize writing style for Umami in Spanish.

Spanish title: Prueba y cultiva tus propias hierbas
Spanish path: prueba-y-cultiva-tus-propias-hierbas
Spanish image alt text: Hierbas frescas cortadas incluyendo menta, perejil, tomillo y eneldo
Spanish article body: please translate in: https://docs.google.com/document/d/1AuYnnWN1DH2SLU95M5SksaB3uwCOGPytWsQc...

Remaining tasks

Translate title
Translate path
Translate image alt text
Translate article body

User interface changes

None

API changes

None

Data model changes

None

Release notes snippet

None

Umami Article Spanish Translation: Dairy-free and delicious milk chocolate

January 27, 2019, 6:28 am

≫ Next: Umami Article Spanish Translation: The real deal for supermarket savvy shopping

≪ Previous: Umami Article Spanish Translation: Give it a go and grow your own herbs

$

0

0

Problem/Motivation

We need to translate this article to Spanish so we can demonstrate Drupal's multilingual capabilities.
This issue is to produce and agree a translation, not to actually incorporate it in Umami's installation process. That will be achieved in a follow-on issue.

Proposed resolution

Translate this article to Spanish so we can demonstrate Drupal's multilingual capabilities according to our Spanish language guidelines: #3011647: [policy, no patch] Standardize writing style for Umami in Spanish.

Translate title: Delicioso chocolate sin lactosa
Translate path: web/articulos/delicioso-chocolate-sin-lactosa
Translate image alt text: Deliciosa tableta de chocolate con leche sin lactosa partido en onzas.
Spanish article body: please translate in: https://docs.google.com/document/d/1Ca8p0mJWLool6U9OF44Baz_C_cZX2tafNpiH...

Remaining tasks

Translate title
Translate path
Translate image alt text
Translate article body

User interface changes

None

API changes

None

Data model changes

None

Release notes snippet

None

Umami Article Spanish Translation: The real deal for supermarket savvy shopping

January 27, 2019, 6:30 am

≫ Next: Umami Article Spanish Translation: The Umami guide to our favorite mushrooms

≪ Previous: Umami Article Spanish Translation: Dairy-free and delicious milk chocolate

$

0

0

Problem/Motivation

We need to translate this article to Spanish so we can demonstrate Drupal's multilingual capabilities.
This issue is to produce and agree a translation, not to actually incorporate it in Umami's installation process. That will be achieved in a follow-on issue.

Proposed resolution

Translate this article to Spanish so we can demonstrate Drupal's multilingual capabilities according to our Spanish language guidelines: #3011647: [policy, no patch] Standardize writing style for Umami in Spanish.

Spanish title:
Spanish path:
Spanish image alt text:
Spanish article body: please translate in: https://docs.google.com/document/d/1TYa8MiowPTxNAjx4fKTaCdyDHB2Y9T3qsafu...

Remaining tasks

Translate title
Translate path
Translate image alt text
Translate article body

User interface changes

None

API changes

None

Data model changes

None

Release notes snippet

None

Umami Article Spanish Translation: The Umami guide to our favorite mushrooms

January 27, 2019, 6:34 am

≫ Next: Umami Recipe Spanish Translation: Watercress soup

≪ Previous: Umami Article Spanish Translation: The real deal for supermarket savvy shopping

$

0

0

Problem/Motivation

We need to translate this article to Spanish so we can demonstrate Drupal's multilingual capabilities.
This issue is to produce and agree a translation, not to actually incorporate it in Umami's installation process. That will be achieved in a follow-on issue.

Proposed resolution

Translate this article to Spanish so we can demonstrate Drupal's multilingual capabilities according to our Spanish language guidelines: #3011647: [policy, no patch] Standardize writing style for Umami in Spanish.

Spanish title:
Spanish path:
Spanish image alt text:
Spanish article body: please translate in: https://docs.google.com/document/d/1NFNUWhGGZKPQxqNbYsOo-ZAJs-FDelNSmTr5...

Remaining tasks

Translate title
Translate path
Translate image alt text
Translate article body

User interface changes

None

API changes

None

Data model changes

None

Release notes snippet

None

Umami Recipe Spanish Translation: Watercress soup

January 27, 2019, 7:26 am

≫ Next: Umami Recipe Spanish Translation: Gluten free pizza

≪ Previous: Umami Article Spanish Translation: The Umami guide to our favorite mushrooms

$

0

0

Problem/Motivation

We need to translate this recipe to Spanish so we can demonstrate Drupal's multilingual capabilities.
This issue is to produce and agree a translation, not to actually incorporate it in Umami's installation process. That will be achieved in a follow-on issue.

Proposed resolution

Translate this recipe to Spanish so we can demonstrate Drupal's multilingual capabilities according to our Spanish language guidelines: #3011647: [policy, no patch] Standardize writing style for Umami in Spanish.

Spanish title: Sopa de berro
Spanish path: /recetas/sopa-de-berro
Spanish image alt text: Sopa de berros con una ramita de cilantro como guarnición en un tazón blanco con borde verde.
Spanish summary: Una sopa maravillosamente simple y ligera, que aprovecha al máximo los productos locales de temporada.
Spanish ingredients & recipe instruction: please translate at https://docs.google.com/document/d/1-k6ejxveVM3zeKu3NAzFkVktoF6PYEe8V6-X...

Remaining tasks

Translate title
Translate path
Translate image alt text
Translate summary
Translate ingredients
Translate recipe instruction

User interface changes

None

API changes

None

Data model changes

None

Release notes snippet

None

Umami Recipe Spanish Translation: Gluten free pizza

January 27, 2019, 7:31 am

≫ Next: Umami Recipe Spanish Translation: Thai green curry

≪ Previous: Umami Recipe Spanish Translation: Watercress soup

$

0

0

Problem/Motivation

We need to translate this recipe to Spanish so we can demonstrate Drupal's multilingual capabilities.
This issue is to produce and agree a translation, not to actually incorporate it in Umami's installation process. That will be achieved in a follow-on issue.

Proposed resolution

Translate this recipe to Spanish so we can demonstrate Drupal's multilingual capabilities according to our Spanish language guidelines: #3011647: [policy, no patch] Standardize writing style for Umami in Spanish.

Spanish title:
Spanish path:
Spanish image alt text:
Spanish summary:
Spanish ingredients & recipe instruction: please translate at https://docs.google.com/document/d/1iB4s9lTvxYwWh6dxDJasUQmKhwc2eNw0WGxx...

Remaining tasks

Translate title
Translate path
Translate image alt text
Translate summary
Translate ingredients
Translate recipe instruction

User interface changes

None

API changes

None

Data model changes

None

Release notes snippet

None

---

Umami Recipe Spanish Translation: Thai green curry

January 27, 2019, 7:33 am

≫ Next: Umami Recipe Spanish Translation: Crema catalana

≪ Previous: Umami Recipe Spanish Translation: Gluten free pizza

$

0

0

Problem/Motivation

We need to translate this recipe to Spanish so we can demonstrate Drupal's multilingual capabilities.
This issue is to produce and agree a translation, not to actually incorporate it in Umami's installation process. That will be achieved in a follow-on issue.

Proposed resolution

Translate this recipe to Spanish so we can demonstrate Drupal's multilingual capabilities according to our Spanish language guidelines: #3011647: [policy, no patch] Standardize writing style for Umami in Spanish.

Spanish title: Curry verde tailandés
Spanish path: /recetas/curry-verde-tailandes
Spanish image alt text: Un tazón tradicional de curry verde tailandés aromático y cremoso, con trozos de pollo y verduras.
Spanish summary: Una versión rápida y fácil del clásico curry verde tailandés. ¡Perfecto para una comida entre semana!
Spanish ingredients & recipe instruction: please translate at https://docs.google.com/document/d/1zjCAJN9dfk3mVCgAEFvvIUmTd5aH3I2Mc8sI...

Remaining tasks

Translate title
Translate path
Translate image alt text
Translate summary
Translate ingredients
Translate recipe instruction

User interface changes

None

API changes

None

Data model changes

None

Release notes snippet

None

Umami Recipe Spanish Translation: Crema catalana

January 27, 2019, 7:36 am

≫ Next: Umami Page Spanish Translation: About Umami

≪ Previous: Umami Recipe Spanish Translation: Thai green curry

$

0

0

Problem/Motivation

We need to translate this recipe to Spanish so we can demonstrate Drupal's multilingual capabilities.
This issue is to produce and agree a translation, not to actually incorporate it in Umami's installation process. That will be achieved in a follow-on issue.

Proposed resolution

Translate this recipe to Spanish so we can demonstrate Drupal's multilingual capabilities according to our Spanish language guidelines: #3011647: [policy, no patch] Standardize writing style for Umami in Spanish.

Spanish title: Crema catalana
Spanish path: crema-catalana
Spanish image alt text: Postre típico catalán hecho de crema y yemas de huevo, cubierto con una capa tradicional de azúcar caramelizado para proporcionar un contraste crujiente.
Spanish summary: Disfruta de esta dulce receta de uno de los postres más antiguos de Europa. ¡Requiere muy pocos ingredientes!
Spanish ingredients & recipe instruction: please translate at https://docs.google.com/document/d/114DCQAeZkutnmvScZj4niNPMtnX0FiUBI9JV...

Remaining tasks

Translate title
Translate path
Translate image alt text
Translate summary
Translate ingredients
Translate recipe instruction

User interface changes

None

API changes

None

Data model changes

None

Release notes snippet

None

Umami Page Spanish Translation: About Umami

January 27, 2019, 9:21 am

≫ Next: Convert pager.inc to a service

≪ Previous: Umami Recipe Spanish Translation: Crema catalana

$

0

0

Problem/Motivation

We need to translate this page to Spanish so we can demonstrate Drupal's multilingual capabilities.
This issue is to produce and agree a translation, not to actually incorporate it in Umami's installation process. That will be achieved in a follow-on issue.

Proposed resolution

Translate this page to Spanish so we can demonstrate Drupal's multilingual capabilities according to our Spanish language guidelines: #3011647: [policy, no patch] Standardize writing style for Umami in Spanish.

Spanish title: Acerca de Umami
Spanish path: acerca-de-umami
Spanish body: please translate at https://docs.google.com/document/d/1Ftfp8O1ehBJne6vP9eusdCNlLvIWOJGG5Z51...

Remaining tasks

Translate title
Translate path
Translate body

User interface changes

None

API changes

None

Data model changes

None

Release notes snippet

None

Convert pager.inc to a service

July 17, 2013, 2:46 pm

≫ Next: Fix the sub-query part in UserSelection::entityQueryAlter

≪ Previous: Umami Page Spanish Translation: About Umami

$

0

0

From #2547833: Pager.inc -- add tests, clean it up, convert to a service, use it!:

Problem/Motivation

pager.inc uses global variables, which we are trying to get rid of, as they make it impossible to manage pagers in a OO manner. All the pager related API are procedural functions.

Proposed resolution

Make Drupal's default pager an OO service, using the capabilities introduced in Drupal 8. This will make it OO and will open it up to the possibility to replace it by alternative implementations.

Unfortunately proper cleanup would include removing the four globals in pager.inc. Since that's an API change, the best we can do in 8.x is deprecate them and include (deprecated) wrappers for the new service to maintain backwards comparability until 9.x.

In detail:

1) A 'pager' is a classed object that contains data and methods relative to a pager element. A 'pager manager' service creates 'pager' objects and keeps track of the objects created so that they can be traversed to produce the 'page' URL querystring for the pager links.

2) The global variables are retained at this stage, wrapped into the PagerInterface methods so that methods can alter them, but also, for BC, other code can alter them independently, and in this case the values stored in the global override any value stored in the PagerInterface object.

3) pager.inc procedural functions remain for BC as wrappers to PagerManagerInterface service or PagerInterface methods. There are no longer global variables declared in this file!

4) template_preprocess_pager() use the new service methods instead of directly accessing the globals.

Remaining tasks

• review

User interface changes

None.

API changes

All pager_* global variables and procedural function will be deprecated. New Drupal\Core\Pager\PagerInterface and Drupal\Core\Pager\PagerManagerInterface and their default implementations will be added. BC layer introduced to allow deprecated global variables and functions to stay with same functionality until Drupal 9.

Data model changes

None.

Fix the sub-query part in UserSelection::entityQueryAlter

May 5, 2014, 5:31 pm

≫ Next: Content language negotiation not working for entity autocomplete

≪ Previous: Convert pager.inc to a service

$

0

0

Context

You looked at the queries, which are identical but the values are not. If you look at those, you can see that it's doing a "'Anonymous' LIKE 'en'"...

The reason is one of the dark places of the database layer, ensuring unique placeholders, which is done by recursively precompiling queries and passing around a shared object/state that returns a unique ID every time it's called for each query.

This works all fine until we get to the very special and dark case of UserSelection::entityQueryAlter() which manually compiles a query condition and passes the global default connection and the current query in for the placeholder ID stuff. Combine this with the count query, which is really a nested selected and we're now inside the inner query, which is *not* the one that was used for the compilation, the outer query would be, so we re-start the placer ID counter and get a _0 placeholder. That is the same as the language condition is using, so we re-use that placeholder and use the first value instead of the one that we're adding.

A possible workaround might be to preg_replace() the placeholder with one that is unique, but that's ugly (not that the whole piece of code there isn't already ugly). I suggest you get Crell and DamZ in here, because AFAIK they came up with all this preExecute() fun (I was involved too, but not as much as they).

Problem/Motivation

As per @Crell (in #2144377-135: Entity reference autocomplete lists entity labels only in current content language), pre-compiling a query is not supported and need to be fixed in UserSelection::entityQueryAlter

Proposed resolution

Prosed solution hints from @Crell on IRC:

01:22 Crell: That plugin needs to get the DB connection injected properly.
01:22 Crell: And then not use db_and()/db_or().
01:22 Crell: And then not precompile the string and hope it works.
01:23 Crell: Actually… Hm, can you get the connection from the $query?
01:23 Crell: I could see an argument that you may need to.
01:24 Crell: And this is that argument.  Because there is, or at least there was an issue to add, methods to the connection for and/or so that the functions were not necessary.

Remaining tasks

User interface changes

API changes

Content language negotiation not working for entity autocomplete

March 23, 2017, 5:49 am

≫ Next: Make 'Use AJAX' work for Bulk update and similar form elements

≪ Previous: Fix the sub-query part in UserSelection::entityQueryAlter

$

0

0

Problem/Motivation

If a multilingual site is configured to use a content language negotiation through a query parameter then autocomplete post requests will not contain the query parameters from the current url and the returned entity labels will not be in the current content language in the case it doesn't matches the default language.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Make 'Use AJAX' work for Bulk update and similar form elements

April 8, 2016, 5:13 am

≫ Next: Convert LocaleUpdateTest::testUpdateProjects() to a kernel test

≪ Previous: Content language negotiation not working for entity autocomplete

$

0

0

Problem/Motivation

The 'Use AJAX' option of views does not work for 'Bulk update' form elements. By applying the bulk update the page refresh is still initiated.
The same problem occurs when using this diff form element.
This is a particular problem when working with modal dialogs.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

---

Convert LocaleUpdateTest::testUpdateProjects() to a kernel test

March 2, 2019, 9:42 am

≫ Next: [META] Deprecate contents of common.inc

≪ Previous: Make 'Use AJAX' work for Bulk update and similar form elements

$

0

0

Problem/Motivation

\Drupal\Tests\locale\Functional\LocaleUpdateTest::testUpdateProjects() is not making any HTTP calls.

Proposed resolution

Convert it to a kernel test.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

None.

[META] Deprecate contents of common.inc

November 22, 2018, 3:56 am

≫ Next: Views aggregation for the proximity field

≪ Previous: Convert LocaleUpdateTest::testUpdateProjects() to a kernel test

$

0

0

Followup #2999721: [META] Deprecate the legacy include files

ToDo:

• #2873881: [meta] Add Change Record to @deprecated for common.inc
• #2908176: Deprecate archiver procedural functions
• #2157945: Convert format_size() to a TranslationInterface::formatSize() method and a StringTranslationTrait::formatSize() helper
• #3000068: Deprecate drupal_process_states()
• #3035343: Deprecate drupal_attach_tabledrag(). Move its logic in Table form element

Done:

• #3029336: Properly deprecate check_url()
• #3008446: Complete the deprecation of format_date()
• #3008493: Deprecate format_date() in classes
• #3008494: Deprecate format_date() in core .modules and .inc files
• #2999989: Deprecate date_iso8601()
• #2566619: Deprecate drupal_http_header_attributes()
• #2677532: Move drupal_check_incompatibility() functionality to a new Dependency class and Version component
• #3008495: Replace format_date in twig comments
• #2911606: Replace usage of the deprecated LOCALE_PLURAL_DELIMITER constant
• #3000057: Deprecate drupal_set_time_limit() and file_upload_max_size() and move to Environment component

Views aggregation for the proximity field

March 2, 2019, 10:29 am

≫ Next: Fold drupal_get_updaters() into Updater class, deprecate drupal_get_updaters()

≪ Previous: [META] Deprecate contents of common.inc

$

0

0

Hi,
I'm creating a view for many businesses, each business has many branches

I would like to sort these businesses by the nearest, everything is ok with me except that I'm not able to aggregate the proximity field

are there any suggestions?

regards,

Fold drupal_get_updaters() into Updater class, deprecate drupal_get_updaters()

February 26, 2019, 6:25 pm

≫ Next: "There was a problem checking available updates ..." for Drupal, modules or themes

≪ Previous: Views aggregation for the proximity field

$

0

0

Problem/Motivation

#1577902: [META] Remove all usages of drupal_static() & drupal_static_reset() wants us to get rid of drupal_static().

#3015538: [META] Deprecate contents of common.inc wants us to deprecate functions in common.inc.

Thus here we feet two birds with one seed.

Proposed resolution

Move the functionality of drupal_get_updaters() into a static method on Drupal\Core\Updater\Updater. Let's call it getUpdaterRegistry().

Instead of using drupal_static() to cache in memory, we'll add a static property to Drupal\Core\Updater\Updater.

Deprecate drupal_get_updaters() in favor of Updater::getUpdaterRegistry().

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

"There was a problem checking available updates ..." for Drupal, modules or themes

October 28, 2010, 8:22 pm

≫ Next: Remove drupal_static from BookManager

≪ Previous: Fold drupal_get_updaters() into Updater class, deprecate drupal_get_updaters()

$

0

0

I have used both IE and Mozilla FireFox in Windows XP. Both of them got the same problem:
Two lines of "There was a problem checking available updates for Drupal ..." showed up at the top of Modules page. When I went to Administrator/Update page, it showed, "All of your projects are up to date." However, when I clicked on "check manually" button, I got "Failed to get available update data for 9 projects."
How to fix this "available update data" problem? Please help.