This meeting takes place every Tuesday, usually at 14:00 UTC (10:00am ET, 7:00am PT). See Time.is to see what that is in your timezone.
The meetings are held using Zoom, and a link is posted in the #ux Slack channel just prior. Agenda is first come, first serve and set by attendees. Use Needs usability review tag for issues that need review and/or suggest issues in comments here.
Recording of this week's meeting: TODO
We discussed the following issues:
TODO
JSON:API has a nice feature in that it flattens a Drupal field value so we don't have pesky value sub-properties on things like string, boolean, email, etc fields. This is great, except when you want your field type to have a forced sub-property.
In the Commerce API module being developed we have a billing_information field that has at least an address property and may have more, such as a tax number or phone number.
Currently, the billing_information field just displays all of the address item values as root properties, causing a broken schema.
The relevant code is: https://git.drupalcode.org/project/drupal/blob/8.8.x/core/modules/jsonap...
$field_properties = TypedDataInternalPropertiesHelper::getNonInternalProperties($field_item);
// Flatten if there is only a single property to normalize.
$values = static::rasterizeValueRecursive(count($field_properties) == 1 ? reset($values) : $values);
getNonInternalProperties will return properties that are not computed or marked internal.
I had to make this workaround for myself:
/**
* {@inheritdoc}
*/
public function normalize($object, $format = NULL, array $context = []) {
assert($object instanceof Address);
// Work around for JSON:API's normalization of FieldItems. If there is only
// one root property in the field item, it will flatten the values. We do
// not want that for the OrderProfile field, as `address` should be present.
// This only happens if there is one field on the profile.
// @see \Drupal\jsonapi\Normalizer\FieldItemNormalizer::normalize
// @todo open issue FieldItemNormalizer::normalize should ignore if mainPropertyName is NULL.
$parent = $object->getParent();
if ($parent instanceof OrderProfile) {
$field_properties = TypedDataInternalPropertiesHelper::getNonInternalProperties($parent);
if (count($field_properties) === 1) {
// This ensures the value is always under an `address` property.
return ['address' => array_filter($object->getValue())];
}
}
return array_filter($object->getValue());
}
If there is one property returned by TypedDataInternalPropertiesHelper::getNonInternalProperties, check if it matches the main property value. In most cases it will, or getMainPropertyName wil be NULL. If it doesn't match, then do not flatten the field values. Often times getMainPropertyName returns NULL If the field type has multiple properties for its value and there cannot be a single property used (ie: price field, you need the number and currency.)
None.
JSON:API will no longer flatten field types which return NULL or a main property name which does not match the single property returned.
None.
This patch allow for buttons (with type=submit) to trigger an ajax enabled exposed form, and is similar to the change in #1123300: Image button in block views with exposed filter breaks AJAX routine.
When using database cache on an Percona XtraDB cluster Truncate's are quite blocking. This means all requests for the cache will wait for the tabel to finish.
When a SST (an initial sync to a new node) is running this can result in waiting for a lock indefinitely which means the sync will fail and the cluster will go down. Other than changing the caching backend to another service, we think not allowing TRUNCATE will aliviate the issues at least. Then we can at least be sure deploying multiple Drupal sites will not result in unfortunate issues where you run into a deadlock situation.
Not too sure what the proper way to fix this would be, but i think removing the possibility for TRUNCATE is at least a start.
While reviewed patch #2473875-75: Convert uses of $_SESSION to symfony session retrieved from the request\Drupal\user\AccountForm using pass-reset-token from request instead of query string
Consume pass-reset-token from query string
- patch and add tests for token (may need CR
- review/commit
no
no
no
The drupal_get_schema_versions() parsing update hooks from .install files
After clean standard profile install I'm getting following versions in database
> select * from key_value where collection='system.schema' and name like's%';
system.schema|search|i:8000;
system.schema|shortcut|i:8000;
system.schema|standard|i:8000;
system.schema|system|s:4:"8901";
It means that updates are serialized with wrong type
- typecast the parsed value
- write update hook to fix values
- add upgrade test
- create patch and test
- add upgrade path and test
- review/commit
no
no
Data stored in key_value tables for system.schema serialized as integers for modules having update hooks defined
no
Using nested paragraphs creates multiple drag handles.
What it looks like with Paragraphs module:
What it looks like with CD_Tools module "tabledrag" test page:
| Expected layout | Actual layout |
|---|---|
 |  |
Scope of the bug:
This issue does not happen with the Seven theme and is scoped to the Claro tabledrag, which has overriden the core tabledrag and added some wrappers and other divs to the html so that we end up with 3 drag handles. The problem doesn't come up with any other place in admin UI, but the nested paragraphs use the "multiple drag".
DOM inspector analysis
The output for the Seven admin theme:
<td class="field-multiple-drag">
<a href="#" class="tabledrag-handle" title="Drag to re-order">
<div class="handle"> </div>
</a>
</td>And the output for the Claro theme:
<td class="field-multiple-drag tabledrag-cell tabledrag-cell--only-drag">
<div class="tabledrag-cell-content js-tabledrag-cell-content">
<a href="#" class="tabledrag-handle js-tabledrag-handle" title="Drag to re-order"></a>
<div class="tabledrag-cell-content__item">
<div class="tabledrag-cell-content js-tabledrag-cell-content">
<a href="#" class="tabledrag-handle js-tabledrag-handle" title="Drag to re-order"></a>
<a href="#" class="tabledrag-handle js-tabledrag-handle menu-item__link" title="Drag to re-order"></a>
<div class="tabledrag-cell-content__item"></div>
</div>
</div>
</div>
</td>It adds the handle three times.
Steps to reproduce with Paragraphs:
1. Create a new paragraph type (sub paragraph) (can be empty without fields)
2. Create two other paragraphs (main paragraphs) (the other one can be empty without fields)
3. Add a Paragraph field to the other main paragraph and include to sub paragraph in the reference type.
4. Add a Paragraph field to basic page and include the two main paragraphs in the reference type
5. Add a basic page and add there the paragraph type which has the sub field. It shows the three drag handles for the sub paragraph
Steps to reproduce with CD_Tools:
1. Install and enable https://github.com/zolhorvath/cd_tools and enable the "Tabledrag" submodule packaged with it.
2. Visit url /tabledrag/nested and /tabledrag/nested-hierarchy, which shows several nested tabledrag handles.
TODO
Nested tabledrag tables will not display duplicate tabledrag handle icons.
N/A
N/A
N/A
One major piece of functionality from the D7 Entity Reference module was left out entirely in #1801304: Add Entity reference field: the ability to render exposed views filters as a select list or autocomplete of available entities.
Create a new Views Entity Reference filter plugin to be available for all entity reference fields and migrate the existing taxonomy filters to be based on the new generic filter plugin.
TaxonomyIndexTid use this entity reference plugin
 |  |
None.
Providing server timing would help developers estimate site performance.
The corresponding W3C specification is currently in "Working Draft" status and its already supported by Google Chrome and Firefox.
https://www.w3.org/TR/server-timing/
Symfony adopted it in https://github.com/symfony/symfony/pull/27985
Add Server-Timing header with relevant timing information.
Decide how enable the Server-Timing.
Followup #2999721: [META] Deprecate the legacy include files before Drupal 9
There is already an existing utility Error class. So lets keep things together.
Deprecate legacy errors.inc file functions. Just get rid of errors.inc file in drupal:10.0.x.
Convert all error handler related functions to the methods in the Error class.
That will help to work on the next step of modernizing Drupal error handler in #1722694: Replace Drupal's error handling with Symfony/HttpKernel's without carrying out of legacy errors.inc file loading BC layer in Drupal 10.0.0.
-
-
-
Currently there is a overflow/scrollbar for the entire page, if the page is viewed on a mobile device and the page contains a table. Even with the responsive tables feature.
Instead of hiding columns, display all columns and introduce a mobile-friendly horizontal scroll on large tables.
Currently discussing if we should let claro override the responsive table feature with this new behavior, or introduce a dedicated #scrollable property to all tables to trigger this behavior when necessary. So one could have a responsive table that scrolls if too large.
The table currently only shows books that are published in the list.
Ideally, I (and I'm sure a few others) would like this to show both published and unpublished books.
/admin/reports/dblog/
Type: locale
User: Anonymous (not verified)
Location: .../core/install.php/?id=2&langcode=cs&op=do_nojs&op=finished&profile=standard&rewrite=ok&rewrite=ok
Referrer: .../core/install.php?rewrite=ok&langcode=cs&profile=standard&id=2&op=start
Message: 1 disallowed HTML string(s) in files: translations://drupal-8.7.6.cs.po.
Severity: Warning
Postponed on #3115223: Remove Stable as a base theme of core themes
The issue #2402165: #theme => 'links' renders <li class="_"> when the #links array is not associative removed the ability to add classes to list items in #links via the array key. This is detailed in the change record. This had some unwanted side effects that weren't apparent until the BC layer in Stable was no longer available to core themes in #3115223: Remove Stable as a base theme of core themes
The issue focused on a bug that occurred when #links items were not associative: the list item would include class="_". However, the issue did not take into account that core has existing code that relied on this functionality.
At least one use case is clearly impacted by this, which was discovered in #3115223, and discovered while manually testing System Tray. Core has several CSS rules including the selector #drupal-off-canvas td .dropbutton-single li.edit (and children of this selector). The .edit class in this selector is added via the keys-become-classes functionality that was removed in #2402165. This is an item added to #links in \Drupal\menu_ui\MenuForm::buildOverviewTreeForm as '#links' => $operations. There is an $operations['edit'] and there is styling that assumes an .edit class will be added.
The result is you get this weirdness:
Instead of the nice pencils:
The BC layer was labeled as deprecated, but it shouldn't have been because there is still core functionality that depends on it.
Remove the BC workarounds added to the .theme files of Bartik, Claro, Seven and Umami in #3115223: Remove Stable as a base theme of core themes.
To fully address, it may require finding everywhere an associative array is used for #links and make sure those array keys are added as classes instead. It's also possible it can only be changed as needed.
Implement the proposed resolution
Address the @todo items referencing this issue.
Seven's CSS is written in a way that makes the links in the tip body indistinguishable from the rest of the text:
"I'll teach you more about paragraphs" part is the the link. As the image clearly shows it is almost impossible to notice (unless one hovers it accidentally).
This is a followup to #3024682: Migrate UI - add human-friendly module names to the Review form. The patch in #105 over there contained out of scope changes which made it to RTBC but had to be removed. This is to preserve the improvement to the ReviewForm.
Since we cannot change the current Dropbutton (and Operations) implementation for BC reasons, the way to move on is:
Create a new Splitbutton element with the required markup, functionality and (accessibility) features.
References:
TBD.
TBD.
TBD.
assertEqual() is deprecated for removal in Drupal 10.0.0 as well.
When buildExternalUrl merges the query parameters with NestedArray::mergeDeep, if the array key for the parameter is an integer it is reset.
e.g. https://www.drupal.org/?360=1&28=drupal turns in to https://www.drupal.org/?0=1&1=drupal
The query parameter keys should be kept the same and not reset.
