Quantcast
Channel: Issues for Drupal core
Viewing all 296830 articles
Browse latest View live

Bug Smash Initiative meetings - next: 2021-08-31

$
0
0

Introduction

The Bug Smash Initiative is a community effort to fix known bugs in Drupal core. See the Bug Smash Initiative handbook page for more information.

We meet fortnightly on Tuesday at 0400 UTC in the #bugsmash channel in Drupal Slack. Beware, this might be Monday evening for some people:

  • 2:00 pm Tuesday - Australian Eastern Standard Time (AEST)
  • 9:30 am Tuesday - India Standard Time (IST)
  • 6:00 am Tuesday - Central European Standard Time (CET)
  • 9:00 pm Monday - Pacific Daylight Time (PDT)
  • When in doubt, ask the oracle.

All meetings are posted as child issues.

Please do not comment on this issueexcept to add a new child issue for an upcoming meeting and change the title here. Thanks!

Next meeting

The next meeting is on Tuesday 2021-08-31

#3226623: Meeting of the Bug Smash Initiative 2021-08-17

Past meetings

Please see the "Child issues" block in the right sidebar or at the bottom of this page for links to past meetings.


Meeting of the Bug Smash Initiative 2021-08-17

$
0
0

Agenda items

Standing items

  • Who is here
  • Any other suggested topics
  • Wins / Thanks / Blockers
  • Statistics and functionality update. X new bugs created in last two weeks. Y closed by the initiative.
  • The bug I would most like to see fixed
  • Update on target items from last meeting
  • What should be the initiative focus for the next 2 weeks?

Statistics

Statistics graph

ToDos

0️⃣ Who is here today? Comment in the thread to introduce yourself. We’ll keep the meeting open for 24 hours to allow for all timezones.

quietoneVicki, NZ
amjad1233Amjad, Brisbane
Griffyn HeelsGriff, Syd :wave:
Indrajith KBIndrajith, India
mohit_agheraMohit, India
larowlanLee late, au
MatroskeenIvan, Ukraine :wave:
lendudeLen, Amsterdam
jibranJibran, AU
Paulo Henrique Cota StarlingPaulo, Belo Horizonte - Brazil
SpokjeFrank, NL
Kristen Pol (she/her)Kristen, late, California
ambermatzAmber, Oregon
mansoor20Catching up late :wave:

0️⃣ .5️⃣ Who's attending DrupalSouth on Thursday/Friday? What session are you most looking forward to?

quietonehttps://drupalsouth.org/events/sessions/alex-matthews-life-after-drupal-...
Griffyn HeelsThat does look good @quietone
Griffyn HeelsI'm moderating this session on Thursday afternoon: https://drupalsouth.org/events/sessions/ian-laslett-making-auditing-stan...
quietoneAmbitious. Audit and fun in the same sentence.
larowlanThe sprint I'm looking forward to
Kristen Pol (she/her)@larowlan do we need a ticket to go to the contribution event?
Kristen Pol (she/her)Never mind... you mentioned it's free in the other thread (edited)

1️⃣ Do you have suggested topics you are looking to discuss? Post in this thread and we’ll open threads for them as appropriate.

quietoneTriage issues marked PMNMI before this initiative started and possibly add three month notice
quietoneIssues that have been committed but still open - is there a way to find them
quietoneIdeas for Triage meeting
larowlanPlan for Drupal South sprint and bugsmash domination
timHi didn't offically introduce myself     hiRe - looking for open issues - Could you use an api on issues?https://www.drupal.org/drupalorg/docs/apis/rest-and-other-apisI am not sure would work but can see advantages if it could. Download a list. filter for what you need in an excel spreadsheet....@quietone (edited)

2️⃣.1️⃣ Wins - what wins have you had since the last meeting? Share your successes!

amjad1233I managed to add Acronyms plugin for search_api module. Was quite awesome.
Kristen Pol (she/her)I think I forgot to mention that I got 2 github sponsors that are sponsoring me for bugsmash triage work... 2 hours a month which helps :) https://github.com/sponsors/kepol?sc=t&sp=bluehorndigital (edited)

2️⃣.2️⃣ Thanks - a space for callouts to other contributors who’ve helped you

amjad1233@darvanen Thanks Max for helping me with that query thingy.
Griffyn HeelsThanks to @mohit_aghera for running the last session! If anyone else wants to in the future I can share the info.
quietone@daffie for #1292966: Curly braces cannot be used in default values for columns
mohit_aghera@larowlan  and @daffie for following up on #3220437: Empty breadcrumb at node/add and node/add/{content_type} when frontpage view is enabled (edited)

2️⃣.3️⃣ Blockers - what’s getting in the way of your issues / goals

larowlanTime
Kristen Pol (she/her)Working on Australian government project that launches next week :tada:
larowlanPlease share when it launches
Kristen Pol (she/her)Will try to remember! :slightly_smiling_face:

3️⃣ Core bug statistics - current state of open bugs

quietoneToday: 2021-08-17
From: 2021-08-03 to 2021-08-17

  All bugs
  Open: 61, including 14 fixed
  Closed: 89
    Age   Count
     00   49
     01   07
     02   04
     03   03
     04   07
     05   08
     06   02
     07   05
     08   03
     09   01

           Status            Count
  closed (duplicate)           18
  closed (won't fix)            7
  closed (works as designed)   17
  closed (cannot reproduce)    14
  closed (outdated)            15
  closed (fixed)               18

  Approximately 230 yr reduction in total number of years of all open bugs.

  Only bugs tagged Bug Smash Initiative
  Open: 6, including 4 fixed
  Closed: 32
    Age   Count
     00   06
     01   02
     02   01
     03   02
     04   04
     05   08
     06   01
     07   04
     08   03
     09   01

           Status            Count
  closed (duplicate)            3
  closed (works as designed)    3
  closed (cannot reproduce)    12
  closed (outdated)             8
  closed (fixed)                6

  Approximately 169 yr reduction in total number of years of all open bugs

.

larowlanThanks
lendudeI’ll see if I can find some time to kick off another scrape and update the graphs, looking at the biweekly stats we are doing great work

4️⃣ Nominate your pet issue for a bug-smash target for the next fortnight

quietoneStill want to get the two children of this completed. https://www.drupal.org/project/drupal/issues/65474
mohit_aghera#3220437: Empty breadcrumb at node/add and node/add/{content_type} when frontpage view is enabled

5️⃣ Help me - Is there anything you could use a :hand:

mohit_aghera@larowlan #3220437: Empty breadcrumb at node/add and node/add/{content_type} when frontpage view is enabled#comment-14190352 is it ready to work on with following changes?- mark it as internal
- make the class final
- add a to-do linking to the broader followup about changing the paths, and say 'deprecate in {url}'
larowlanI think so yes
MatroskeenTend to mark as "Won't fix", but I can't without seeing other opinions:#3101664: UserRolesCacheContext reports wrong user.roles

6️⃣ @quietone: "Triage issues marked PMNMI before this initiative started and possibly add three month notice" (edited) 

Griffyn HeelsWhats PMNMI?
quietonePostponed Maintainer Needs More Information
quietoneMany months ago, I triaged and added a 3 month notice to PMNMI issues in migrate. Then, after the three months another migrate maintainer reviewed those issues. The result was that all but one was closed.That worked well and I suggest we do the same.
larowlanSounds great, can we crowd source this at the sprint on Friday
quietoneAs a start date I use 2020-04-21 which is from the initial stats, https://www.drupal.org/community-initiatives/bug-smash-initiative/goals
lendudeDo we have an ok for using the 3 month period? Think @xjm had some insights into a good period to use last time we talked about this?
lendudeCan’t remember what came out of that discussion
quietoneLinks to two meetings where I found discussion. [#3195107]The second issue has input from xjm, suggesting the three months. The last comment in the thread was a self reminder for xjm to look at the templates. I don't think that has happened.
Kristen Pol (she/her)Excellent suggestion @quietone. Thanks for the reminder

7️⃣ @quietone: "Issues that have been committed but still open - is there a way to find them"

quietoneThis is likely a small group of issue but a group where we have found that closing the old one and opening a new one is the way to move it forward.Maybe we could find them all and work through them.
larowlanWe'd need to ask drumm I think
quietone@drumm, is it easy to get a list of these issues?
timI posted in the wrong thread....https://drupal.slack.com/archives/C014QES6HSQ/p1629175932123600?thread_t...
quietonethanks for the nudge. I had a csv of open issues from working on the stats. I wrote a batch script to get the issue number and then to find those that are in the git log. I get 55 results.
drummI think we have all that data in the DB. Not exactly easy, but doable. Is this still needed, looks like you might have found a way already?
Matroskeen@quietone, that's nice! We can close at lease one of them :smiley:#3192059 was supposed to be backported to 8.9, but it's not gonna happen.Quick instructions how to deal with such issues are available in one of the previous meetings: https://drupal.slack.com/archives/C014QES6HSQ/p1623125376125100p.s. I went ahead and closed it. (edited)
catch@nod_ was working on some issue queue mining and might be able to pull this.
nod_do you need issues for D7 as well? or 8+?
nod_got 371 issues
nod_[ CSV file, see link below ]
nod_kinda uses commit data from a couple of weeks ago but it's a start. takes commits from about 2012, if an issue was committed earlier and is still open it won't be in this list
nod_added the human readable status
catch@nod_ I'm pretty sure only 8.x issues for this channel - thanks for digging those out!
larowlanthanks, this will be a good triage target for today @pameeela @Griffyn Heels
larowlanput into a sheet https://docs.google.com/spreadsheets/d/16P7m6IlLWgez0Q79UDT14MC-hJYlssQj... and filtered out patch to be ported and d7

8️⃣ @quietone: "Ideas for Triage meeting"

quietoneA list of thoughts I had.Run like a regular meeting with issues in threadsAnnounce a set of issues or component to be triagedAnnounce in other relevant channels that the triage is happeningInvite the relevant maintainer or other know keen person to joinKeep open for 24 hours
mohit_aghera+1 to Run like a regular meeting with issues in threads andAnnounce a set of issues or component to be triaged
larowlanThat sounds great
larowlanI think we'd need a champion to take on the job of organising them
larowlanI wonder if @kattekrab has any ideas on if this
larowlando you think we could spend some time at the sprint fleshing this out some more ?
lendudeMy only worry is that it could fill up the channel fairly quickly, and it might be hard to find the issue that actually needs discussing, ie. we do 10 issues, 9 are easy, 1 is hard, but its the third issue on the list so nobody sees that this still needs discussion cause it too far back in the slack history. I don’t know, maybe I’m going for premature optimisation here and we should try it and see
larowlanwe could spin up a triage channel if that became an issue
lendudeYeah, we should try it and see and tweak from there
kattekrabInteresting! Thanks @larowlan - I might have some ideas if I wasn't sleep deprived.  Very much agree with you @lendude "Just try, then tweak" Good suggestion @quietone
kattekrabTriage is well focussed - timeboxing, and trying to filter for complexity might be useful frames
kattekrabIs everyone familiar with the cynefin model?  Clear - Complicated - Complex - Chaotic?
kattekrabimage.png
dwwYes, an async triage meeting sounds great. Definitely worth trying & tweaking.
dwwAlso from the Premature Optimization Department (where I spend way too much time): I wonder if the nature of these async slack meetings will add any friction to actually taking the actions in the issues themselves. Eg, a couple people respond to a question in a thread, and it seems like agreement. Some possible risks to progress:Everyone thinks someone else will update the issue.Some temptation for “seems like agreement, but maybe we should wait for New York to wake up before we close that one...” No later responses come : when / how to circle back and go with whatever plan we’ve got so far...
dwwProposed mitigations:A) it’s only an issue. Folks can post new comments, undo metadata changes, etc. Just post something and if we change minds later, change the issue accordingly
dwwB) make good use of thread icons, be sure to update, so we can more easily circle back later to anything not :checkbox:
dww:point_up: would also help with Len’s concern
lendudeYeah B) sounds really good, maybe also removing the preview when it has been resolved so resolved stuff takes up less space?
dww@kattekrab hadn’t heard of that, but looks interesting. I started at https://en.m.wikipedia.org/wiki/Cynefin_frameworkSeems like a good, clear summary. Any better places to learn more?
dwwThis caught my eye:"best practice is, by definition, past practice"sounds like something to also keep in mind. I should post that to the #gitlab meeting. ;) maybe if I share it widely enough, I’ll take it to heart, and be less complacent in the technical aspects of my life.
Kristen Pol (she/her)Excellent idea @quietone and I agree with keeping it simple and the UX improvements above to keep the channel tidy and helpful
quietoneSome of @dww concerns can also be handled with by someone checking the threads for decisions or followups. This stuff often falls to the facilitator but I am cautious about overloading the expectations of a facilitator.

9️⃣ @larowlan: "Plan for Drupal South sprint and bugsmash domination"

larowlanAny thing you want us to focus on
larowlanFirst time contribution tasks would be great
quietoneHelping people to (learn how to) review issues
larowlanYes, @jibran did that in Melbourne a few years back +1
quietone@jibran, what did you do?
larowlanhe got up on stage and talked through a review
larowlanlike the live commit, but a live review
jibranDude! that's 6.5 years ago. :smile:
jibranYou pretty much have to present whatever you want sprinters to do.
larowlan6.5 years really?
larowlanwow, that went so fast
jibranDrupalSouth Melbourne was held in March 2015.
larowlan:exploding_head:
larowlanthe sprint is free for anyone to attend - no need to have a ticket
larowlani'll post in this channel the details on Friday
Kristen Pol (she/her)I'll try to attend, thanks for organizing
ambermatzI’ll do a social post from the Drupalize.Me account promoting the sprint and encouraging folks to check out bugsmash issues.
jibranMaybe @Gábor Hojtsy (he/him) can use his social media influence as well. :smile:
ambermatzHere’s a link to the tweet just posted: https://twitter.com/drupalizeme/status/1428137177855184900
Gábor Hojtsy (he/him)RTed :)

[Meta] Bug Smash Initiative triage fortnight commencing 2021-08-03

$
0
0

Meta for triage credit, please comment and link to issues you triaged and closed.

[Meta] Bug Smash Initiative triage fortnight commencing 2021-08-17

$
0
0

Meta for triage credit, please comment and link to issues you triaged and closed.

Use email verification when changing user email addresses

$
0
0

Problem/Motivation

Currently, when a new user registers for a Drupal account the details are sent to the user's supplied email address. This provides a basic mechanism that confirms the user is at that email address. However, once registered, users are permitted to change their email address without further confirming that the user is in fact at that email address.

Possible implications

  • A user can change their email address to be that of an unsuspecting third party as no confirmation of change is required. Using a second Drupal account (with it's email address also faked using the same method) the first user is then able to send anonymous malicious messages to the unsuspecting third party
  • A slow method for sending spam but exploitable none the less

Proposed resolution

Add a mechanism (similar to reset password) that:

  1. Sends an E-mail to the new address requiring the verification of the new address (similar to register confirmation).
  2. Sends a notification E-mail to the old address.
  3. Allow the site builder to customise both messages at admin/config/people/accounts
  4. Provides an update path to set the default behaviour and messages content.
  5. Write tests.

This new mechanism is bypassed if the e-mail address is changed by an administrator.

Remaining tasks

  1. #279.2: Seems to be fixed as well as possible right now given limitations of other issues. Raise a follow-on issue to tidy up once other issues have been fixed.
  2. #279.6: Add a test - see further explanation in #284
  3. Release note snippet for IS.
  4. Security review.
  5. Follow-up questions from usability review in #270 and #272.

User interface changes

New UI additions to admin/config/people/accounts:

New confirmation message (warning) when user changes e-mail address:

Your updated email address needs to be validated. Further instructions have been sent to your new email address.

Default text of the generated e-mail (some elements will vary):

alice,

A request to change your email address has been made at Drupal Usability. You
need to verify the change by clicking on the link below or copying and
pasting it in your browser:

http://drupalux.lndo.site/user/mail-change/2/alice%40example.org/1542687...

This is a one-time URL, so it can be used only once. It expires after one
day. If not used, your email address at Drupal Usability will not change.

After using the one-time link, the user is redirected to the site's home page, with the message (info)

Your email address has been changed to alice@example.org.

API changes

New controller used for mail changing: \Drupal\user\Controller\MailChangeController

Data model changes

New schema for configs user.settings and user.mail.

Release notes snippet

When users wishes to change their email, they must now verify the email belongs to them using a link sent to that address. This behavior is enabled by default on new installations but disabled by default on existing installations. Review the change record for more information.

Olivero: a11y color contrast test fail for primary button on hover

$
0
0

Olivero's primary button on hover doesn't pass a11y color contrast test.

Adding screenshots for reference.

Olivero's Title overflow when title link text too long.

User's image in comments is overlapping with layout builder section.

$
0
0

Problem/Motivation

While posting a comments on a test node ,user's image is overlapping with layout builder section.

Steps to reproduce

1. Create a test node for article content type.
2. Add data.
3. Home>Administration>Structure>Content types>Article,under layout options check layout builder.
4. Go to the article node, click on layout.
5. Scroll down to the place where comments are being posted.
6. You will see the user's image(circular one) overlapping with the layout builder section.
Please refer to the video attached.


Olivero: wide image can overlap sidebar when toolbar open and in vertical mode

$
0
0

Within Olivero, if the image can overlap a sidebar if the toolbar is in vertical mode and is open.

Private file download returns access denied, when file attached to revision other than current

$
0
0

This is the follow-up issue of Private file download returns access denied, as was suggested by @Berdir here.

Once upon a time a patch was committed to D7 core to make private files accessible, when there are nodes with revisions on your site (see "Private file download returns access denied" issue mentioned above). To achieve this, they changed some code at modules/file/file.module, namely file_get_file_references function parameter to FIELD_LOAD_CURRENT from FIELD_LOAD_REVISION.

But FIELD_LOAD_REVISION parameter was there for a good reason, with FIELD_LOAD_CURRENT we are not able to open files attached to all entity revisions except current. It's fatal in case you're trying to build, say, intranet with library for documents.

Steps to reproduce:
1.Set up clean Drupal 7.12 with private document folder (say, sites/default/files/private) and a content type with just a title and file field called field_file. It should store files in your private folder.
2.Login as UID1, create a node and add a file "testfile1.txt" to it's file field.
3.Save the node
4.Click edit
5.Remove the old file, "testfile1.txt"
6.Add "testfile2.txt"
7.Check "Create new revision" option
8.Click save
9. Click revisions tab, open first revision of your node
10. Node is fine, link to file is there, but when you'll click on this link to the file "testfile1.txt", you'll get "Page not Found"

It is possible to open old version of your file - if you'll revert old revision. But it is not an option in case you use revisions as revisions, not as backups for inaccurate users, because it will produce awful mess of revisions.

In short:

So if a user has access to a revision he should also be able to access its files. If not, not.

Create upstream issue for PostCSS regarding incorrect IE11 CSS grid Syntax

Potential header menu "X" close-icon usability issue in Olivero

$
0
0

Problem/Motivation

This is a follow-up issue from the discussion that was bought up in #3186349: Major accessibility problems with Olivero header show/hide feature.

From @andrewmacpherson

The issue of whether an "X" close-icon was mentioned in #9 as a possible follow-up. We decided to leave it for now, since it's highly bikeshed-able. Now that 2 accessibility maintainers have noted it, I think we should have that follow-up for sure, so I'll create that. I think it could be better as an in/out chevron-arrow, similar to the >> and << used by some application sidebars (like GitLab).

"Unpublished" style of rendered entities is not accessible (and looks bad)

$
0
0

Problem/Motivation

"Unpublished" style of rendered entities is not accessible (pink too hard to notice for some) (and looks bad)

blocks #2290101: UI telling you a field is shared across languages is way too subtle

Bug because there is an accessibility violation. Even for sighted people with good vision, the light pink background is difficult to see. For someone with low vision, there is no distinction. For someone using a mobile device outside, they won't be able to distinguish between published and unpublished content. For a blind user, there is no indication that a node is unpublished.

Major because this is a basic part of Drupal Core's workflow and it isn't accessible. This doesn't meet WCAG 2.0 AA, but also presents usability challenges.

Proposed resolution

Add a marker to nodes & comments to ensure that the published/unpublished state is semantically defined.

Enhance the visual representation of the unpublished content so that it is more distinct.

Remaining tasks

  • Update the patch so the marker is properly output for both nodes and comments that are unpublished in the Bartik, Stark, and Claro themes following the approach taken in patch #275 (https://www.drupal.org/project/drupal/issues/867830#comment-13839909)

    Currently, the markers are being output only for unpublished nodes in Bartik articles and comments in Stark. The marker should be output for all unpublished nodes and comments on all frontend themes. That is, all the no's in the table below should become all yes'.

    Current status of marker output with patch #275
    Theme/NodeNodeComment
    Bartik - Basic Pagenono
    Bartik - Articleyesno
    Stark - Basic Pagenoyes
    Stark - Articleno yes
    Claro - Basic Page nono
    Claro - Articlenono

    Output should include hidden text to give screen reader users context to for the status marker:

    <span class="marker marker--warning">
        <span class="visually-hidden">This node is</span> 
            Unpublished
    </span>
    

    Note: Current output in the stark theme with patch #275 uses the <mark> element. This should be changed to the spans with visually hidden context above. The <mark> element was moved to https://www.drupal.org/project/drupal/issues/1311372.

  • Update patch to get tests passing
  • To be discussed: The colors for marker warnings used in the latest patch (#275) do not pass WCAG guidelines for color contrast. (Success marker has ratio of 2.53:1 and warning marker has ratio of 2.46:1. Ratio should be at least 4.5:1.) Maybe this is part of a design already approved elsewhere and is out of scope of this issue? Otherwise, if these colors are being newly introduced with this issue, they should be revised for accessibility.

User interface changes

CSS changes.

before

This example has an unpublished node, with an unpublished comment.

after

Unpublished comments:

Unpublished nodes:
Screenshot needed once it's working in patch.

API changes

None.

Original report by @joshk

I really like this change: #394736: Unpublished node's pink background unclear

As the pink background is just too hard too see. This is the same issue as for unpublished comments as well!

Why this change should be committed during RC

A color based signifier for content state is not accessible or intuitive for any users.

Add "nomodule" attribute on polyfills

$
0
0

Problem/Motivation

There are feature detection in our polyfills but the JS is still loaded.

Proposed resolution

Add a "nomodule" attribute to the polyfill scripts to avoid loading them in supported browser.

"nomodule" causes a script to be ignored on all modern browsers. IE11 and Opera Mini do not understand the attribute and will load the polyfills:

https://caniuse.com/mdn-html_elements_script_nomodule

Support for various modern HTML features also correspond with this; only legacy browsers such as IE11 and Opera Mini need polyfills for the below features, other modern browsers support them already:

https://caniuse.com/array-find
https://caniuse.com/element-closest
https://caniuse.com/matchesselector
https://caniuse.com/mdn-api_nodelist_foreach
https://caniuse.com/mdn-javascript_builtins_object_assign
https://caniuse.com/picture

Remaining tasks

Make the unpublished status presentation accessible and consistent with Olivero's design

$
0
0

Problem/Motivation

Unpublished nodes and comments are only highlighted in a light pink using CSS. This is not accessible as described in the related core issue. It also looks bad with most complex content so that it distracts from content reviews done while unpublished.

Steps to reproduce

Create a page and leave it unpublished. The Olivero result is shown below:
unpublished screenshot

Proposed resolution

See the core issue for the approach tried so far.


Quickedit not working for node date

$
0
0

Problem/Motivation

Quickedit doesn't work for the node created field

Steps to reproduce

  1. Enable quickedit
  2. Enable "Display author and date information" for a content type
  3. Edit a node of that content type

Proposed resolution

The problem is in olivero_preprocess_node. The code overwrites $variables['date'] with just a date. Previously the value was set by template_preprocess_node() and it might be a rendered field output.

Remaining tasks

  1. Write a patch
  2. Re-enable commented out code in NodeDisplayConfigurableTest.php

User interface changes

API changes

Data model changes

Release notes snippet

Olivero: Modal dialog buttons not aligned (for example, in the "Leave preview" dialog)

$
0
0

Steps to get the leave preview box:

  1. Go to edit node
  2. Click on Preview button at the bottom.
  3. Click on logo or website title on Navbar.

Actual box:
Cancel button and Leave preview are not inline.
actual

Expected:
Cancel button and Leave preview should be inline.
expected

Olivero: repat placeholder CSS for IE11

$
0
0

Olivero: repat placeholder CSS for IE11.

Steps to reproduce:

1. go to olivero/css/components/form.pcss.css file.
2. we have written IE11 specific css for placeholder. :-ms-input-placeholder {color: var(--color--gray-30) !important; } which is not required. Because yarn compiles the ::placeholder to :-ms-input-placeholder for IE11 support.
3. Adding screen-recording to better understanding.

Resolution:

::placeholder {
  color: var(--color--gray-30);
}

/* IE 10 and 11 needs this set as important. */
:-ms-input-placeholder {
  color: var(--color--gray-30) !important;
}

This code compiles to

:-ms-input-placeholder {
  color: #7e96a7;
}

::placeholder {
  color: #7e96a7;
}

/* IE 10 and 11 needs this set as important. */

:-ms-input-placeholder {
  color: #7e96a7 !important;
}

So we can remove this extra line of code.

/* IE 10 and 11 needs this set as important. */
:-ms-input-placeholder {
  color: var(--color--gray-30) !important;
}

Display which role is the 'Administrator role' on /admin/people/roles

$
0
0

Problem/Motivation

Follow-up for #987978-57: Move "administrator role" setting to new Role Settings form:

we probably want to visually promote the value to the role overview page. Sort of the "settings summary" pattern. Or a whole new column in that table (there's plenty of space for it) to indicate anything special about each role. Not sure what the column should be labeled, what values it would contain, etc. But if I'm scanning my collection of roles, it'd be nice to know which one(s) are the admin role(s)

Steps to reproduce

  1. Install core (any version D8/9):
  2. Visit /admin/people/roles
  3. Wonder which one is the 'Administrator role'

Proposed resolution

Somehow indicate which role at /admin/people/roles is the 'Administrator role'.

Remaining tasks

  1. Decide on the UI
  2. Implement
  3. Add / update tests
  4. Reviews / refinements
  5. RTBC
  6. Commit

User interface changes

TBD.

API changes

Unlikely.

Data model changes

None.

Release notes snippet

TBD.

Header block overlapping popup

$
0
0

Steps required to reproduce

I found this issue in view popup when you add Field Header Footer or etc.

1. Set Olivero as admin theme
2. Go to Structure > Views and edit any view
3. In view settings when you click on Add button in the Fields,Filter criteria,sort criteria or in other sections the popup will appear and you'll find this issue.

Expecting behavior

Pop-up should be come top on the screen and Menu should not be clickable when Pop-up is open.

It's is what i find.

Viewing all 296830 articles
Browse latest View live


<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>