Problem/Motivation

We're standardising on writable over writeable so we need to change the requirement name in system_requirements().

See #2898947: Change "writeable" to "writable" in documentation

Proposed resolution

Change it.

Remaining tasks

User interface changes

None

API changes

Internal "API" change - the render array for requirements has a different key.

Data model changes

None

Release notes snippet

Agenda items

Standing items

• Who is here
• Any other suggested topics
• Wins / Thanks / Blockers
• Statistics and functionality update. X new bugs created in last two weeks. Y closed by the initiative.
• The bug I would most like to see fixed
• Update on target items from last meeting
• What should be the initiative focus for the next 2 weeks?

Statistics

Statistics graph

0️⃣ Who is here today? Comment in the thread to introduce yourself. We’ll keep the meeting open for 24 hours to allow for all timezones.

0️⃣.5️⃣ What's your favourite Christmas song? (edited)

1️⃣ Do you have suggested topics you are looking to discuss? Post in this thread and we’ll open threads for them as appropriate.

2️⃣.1️⃣ Wins - what wins have you had since the last meeting? Share your successes!

2️⃣.2️⃣ Thanks - a space for callouts to other contributors who’ve helped you

2️⃣.3️⃣ Blockers - what’s getting in the way of your issues / goals

3️⃣ Core bug statistics - current state of open bugs

4️⃣ Nominate your pet issue for a bug-smash target for the next fortnight

5️⃣ Help me - Is there anything you could use a :hand: with?

6️⃣ Approve last fortnight's minutes

7️⃣ "First Bugsmash for '22"

8️⃣ @quietone "Make a policy recommendation for Bot usage on GitLab to aid issue management"

Participants:

Griffyn Heels, quietone, Kristen Pol, larowlan, dww, darvanen, lendude, kim.pepper

Problem/Motivation

It's important for administrative elements to maintain consistent elements and a visual language even if they are being presented to the user alongside the front-end of the site. For example the Toolbar and Edit modules.

Currently this is very difficult or impossible to do, the CSS loaded by the front-end theme affects the admin elements and theme functions are also passed through the front-end them. This produces an amazing amount of inconsistency depending on the theme and commonly breaks admin UIs that are display on the front-end.

The Overlay module worked around this by loading the admin UI inside of an iframe.

Proposed resolution

Remaining tasks

User interface changes

API changes

Problem/Motivation

#3201820: Manually test that CKE 5 can be used in off-canvas added a CSS reset which makes CKEditor functional in off-canvas. It seems like the solution includes duplicating all CSS loaded on the page. This seems like a lot of work just for making CKEditor work in off-canvas.

Proposed resolution

Decide if we could duplicate only to a partial set of CSS.

Remaining tasks

User interface changes

API changes

Data model changes

Problem/Motivation

Currently, Drupal goes slow if working with billions of records. I have a application with has millions of records and view to display data in table format with exposed filter. After applying filters Drupal goes very very slow like it's dying.

Steps to reproduce

Add millions of records in database and use view to display as table then filter data using exposed filter and see Drupal takes lot of time to return millions of records

Proposed resolution

Drupal reporting should work RAD, to perform operations on billions of records within few seconds and show millions of records after applying filter.

Problem/Motivation

See #2729663: Fragment link pointing to <textarea> should be redirected to CKEditor instance when CKEditor replaced that textarea. Same problem with CKEditor 5.

Steps to reproduce

Trigger a validation error on a text field using CKEditor 5 while Inline Form Errors is enabled.

Proposed resolution

Implement a solution similar to #2729663: Fragment link pointing to <textarea> should be redirected to CKEditor instance when CKEditor replaced that textarea.

When suggested to implement this upstream, the CKEditor developers reacted surprised: they've never seen this requested before. Since it's simple enough to implement and maintain on our side, the above seems fine.

Remaining tasks

1. Port test coverage from \Drupal\Tests\ckeditor\FunctionalJavascript\CKEditorIntegrationTest::testFragmentLink().
2. Port test coverage from \Drupal\Tests\inline_form_errors\FunctionalJavascript\FormErrorHandlerCKEditorTest().
3. Add fix.

User interface changes

Fragment link navigation pointing to text fields using CKEditor 5 now works.

API changes

None.

Data model changes

None.

Problem/Motivation

The default action on /admin/content is "Delete selected content". It's really easy to push "Apply" button by mistake, thinking it will apply the filter, because of the button title, and because it's positioned at the bottom of the form, typically where people expect to look for submit buttons. (This actually happened to me today, and I've been using Drupal for 8 years.)

Proposed resolution

• Use the D7 sort order (#3)
• Make the default action something safer (or make the default a no-op).
• Change the "Apply" button back to "Update" (like D7), "Execute", or even something action specific ("Delete").

Proposed alternatives

Alternatives for order of operations. The first operation in a list is the default.

Alternative 1: D7-like

• Publish content
• Unpublish content
• Promote content to front page
• Remove content from front page
• Make content sticky
• Make content unsticky
• Delete content
• Save content

Variation: Unpublish as default, by swapping Publish and Unpublish. This has the same Cons. For consistency the other operation pairs should also be swapped.

Alternative 2: Safe default

• - None -
• Publish content
• Unpublish content
• Delete content
• Save content
• Promote content to front page
• Remove content from front page
• Make content sticky
• Make content unsticky

Variation: Place Delete and Save at the bottom of the list as in D7.

Alternative 3: Safe first

• Make content sticky
• Make content unsticky
• Promote content to front page
• Remove content from front page
• Publish content
• Unpublish content
• Delete content
• Save content

Variation: Use Promote/Demote as first operation pair.

Remaining tasks

• Implement the suggestion in Comment #75
• Fix the failing tests: see Comment #72
• Make follow-up to delete the Save content option

User interface changes

Yes!

API changes

N/A

Problem/Motivation

Update to CKEditor5 v31.1.0 in core: https://github.com/ckeditor/ckeditor5/releases/tag/v31.1.0

Key changes we need (besides the many bugfixes we benefit from):

• https://github.com/ckeditor/ckeditor5/issues/10828:image: Manual decorators on the linked inline images should be preserved while loading editor content. Closes #10828. (commit)→ this unblocks #3247683: [PP-2] Disable CKEditor 5's automatic link decorators (in Drupal filters should be used instead) + explicitly test manual link decorators, which is a major issue
• https://github.com/ckeditor/ckeditor5/issues/8510:core: Support language configuration passed in defaultConfig option through editor's constructor. Closes #8510. (commit)→ this might fix #3250191: [PP-1] Translation of toolbar button tooltips still not working.

Proposed resolution

1. core/package.json
2. cd core
3. yarn install
4. yarn run vendor-update
5. yarn run build:ckeditor5

Remaining tasks

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

CKEditor 5 asset library updated to version 31.1.0.

Problem/Motivation

The image style generation has been improved in #2027423: Make image style system flexible. Now a module can change the way image derivatives are generated. However, right now altering the derivative URI can be done by extending \Drupal\image\Entity\ImageStyle. This is a problem because the last module to override the image style class wins, and everyone else loses.

Proposed resolution

Allow modules to alter the image style derivative generated URI by implementing a new hook_image_style_uri_alter().

Remaining tasks

None.

User interface changes

None.

API changes

New hook hook_image_style_uri_alter().

Data model changes

None.

Beta phase evaluation

This is exactly the same as #3105925: The description of the arguments for FieldDefinition::setDisplayOptions() conflicts with what reported in FieldDefinitionInterface::getDisplayOptions(), but for BaseFieldDefintion instead of FieldDefinition. The docblock of BaseFieldDefinition::setDisplayOptions wasn't updated either in #2796581: Fields must store their region in entity displays, so it still mentions setting type='hidden' instead of region='hidden'.

Problem/Motivation

PHP 8.1 introduces many deprecation notices that would not appear previously. In my experience, it seems that hitting one of these notices (when thrown by a contrib module) generally causes a critical error coming from Core -- Error: Class "Drupal\Core\Utility\Error" not found in _drupal_error_handler_real() (line 63 of core/includes/errors.inc).. In such cases, the deprecation message is included in the stack trace:

The website encountered an unexpected error. Please try again later.
Error: Class "Drupal\Core\Utility\Error" not found in _drupal_error_handler_real() (line 63 of core/includes/errors.inc).

_drupal_error_handler_real(8192, 'Return type of Drupal\profile\Plugin\Field\ProfileEntityFieldItemList::offsetExists($offset) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice', '/var/www/html/drupal/web/core/lib/Drupal/Core/TypedData/ComputedItemListTrait.php', 121) (Line: 346)
_drupal_error_handler(8192, 'Return type of Drupal\profile\Plugin\Field\ProfileEntityFieldItemList::offsetExists($offset) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice', '/var/www/html/drupal/web/core/lib/Drupal/Core/TypedData/ComputedItemListTrait.php', 121) (Line: 571)
include('/var/www/html/drupal/web/core/includes/bootstrap.inc') (Line: 571)
Composer\Autoload\includeFile('/var/www/html/drupal/vendor/composer/../../web/core/lib/Drupal/Core/Utility/Error.php') (Line: 428)
Composer\Autoload\ClassLoader->loadClass('Drupal\Core\Utility\Error') (Line: 44)
Drupal\Core\EventSubscriber\ExceptionLoggingSubscriber->on403(Object) (Line: 97)
Drupal\Core\EventSubscriber\ExceptionLoggingSubscriber->onException(Object, 'kernel.exception', Object)
call_user_func(Array, Object, 'kernel.exception', Object) (Line: 142)
Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch(Object, 'kernel.exception') (Line: 219)
Symfony\Component\HttpKernel\HttpKernel->handleThrowable(Object, Object, 1) (Line: 91)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 67)
Drupal\simple_oauth\HttpMiddleware\BasicAuthSwap->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 49)
Asm89\Stack\Cors->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 708)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

Fixing/patching the deprecation seems to get rid of the notice, as well as this error handler error itself. The error handler error is problematic because it turns what should be a simple notice into a critical failure. I think that what must be happening is that the deprecation is somehow short-circuiting the autoloader or something.

Steps to reproduce

Trying to figure out simple steps to reproduce on a clean install. Not sure of a good way yet.

Proposed resolution

Unsure.

Problem/Motivation

In #3027952: [Plan] Remove the usage of deprecated methods in tests, we removed usage and started triggering deprecation errors for legacy assert methods coming from Simpletest.

It's time to remove the legacy traits for D10.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

None

Problem/Motivation

Updates from Drupal 9.2.10 to Drupal 9.3.0 are adding an --2 suffix to block-ID's (maybe only views-block-ID's?). For example block-views-block-newsslider-block-1 changes to block-views-block-newsslider-block-1--2, causing all JS an CSS selectors applied to the specific IDs not to work anymore and breaking the design of the website. This happens at least to allblock-views-block-Elements of the affected websites.

This happend with different websites and different base themes (Classy, Bootstrap 3).

Setup:

Steps to reproduce

Update from Drupal 9.2.10 to Drupal 9.3.0

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Problem/Motivation

PHP 8.1 adds Fibers, opening this meta to group together potential use cases.

https://php.watch/versions/8.1/fibers

https://www.php.net/releases/8.1/en.php

Steps to reproduce

Proposed resolution

Queues: #1189464: Add an 'instant' queue runner
Cron: #3257727: Run automated cron in a Fiber
Rebuilds: #3257725: Use Fibers to offload discovery builds

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Problem/Motivation

install_config_revert_install_changes declares global $install_state twice, once at the start of the function and again in a catch block

Steps to reproduce

Proposed resolution

Remove the second one

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Problem/Motivation

There is an aria-describedby that provides instructions regarding available keyboard commands when focusing a listbox item representing a CKEditor 5 button. The contents of aria-describedby are read twice

Steps to reproduce

Proposed resolution

Remove aria-describedby altogether and make the keyboard command instructions part of the visually hidden option contents. The text within a listbox option is read by AT already and it has role="option" so it doesn't need to be ARIA labeled/described - it just needs content conveyed to AT.

Remaining tasks

User interface changes

API changes

Data model changes

Hello, i have recently updated my php to 8.0 and realized a exposed filter changed how it works.

I'm using better exposed filters over the views, but i traced the issue to the views module.

When i have a boolean operator filter, and better exposed filter module assigns a default value of 0 (false), the "acceptExposedInput" method in Drupal\views\Plugin\views\filter\FilterPluginBase behaves differently.
At line 1507 of FilterPluginBase.php there is this condition, which evaluates to true (0=='string') in php7.4 and to false in php 8.0.

          if ($value == 'All' || $value === []) {
            return FALSE;
          }

Also lines 111, 112 and 113 at Drupal\views\Plugin\views\filter\BooleanOperator look redundant to me.

Kind regards and many thanks for your awesome work.

Problem/Motivation

From issue #3178534: Start running PHPStan on Drupal core (level 0): Start running PHPStan on Drupal core (level 0)

     Internal error: Internal error: Cannot assign an empty string to a string offset in file /app/core/modules/link/tests/src/Kernel/LinkItemTest.php                                                                
     Run PHPStan with --debug option and post the stack trace to:                                                                                                                                                     
     https://github.com/phpstan/phpstan/issues/new?template=Bug_report.md     

Steps to reproduce

Proposed resolution

Probably this should be checked explicitly that this is not a string.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

If we go to node view we receive non catchable MethodNotAllowedException.
Step to reproduce:
1. Install module rest.
2. Install module language.
3. Install module page_manager(Seams that this step can be excluded).
4. Create some language.
5. go to /admin/config/regional/language/detection and check Account administration pages.
6. Go to user edit page and set some language in "Administration pages language".
7. Go to node view.

You will receive:

Symfony\Component\Routing\Exception\MethodNotAllowedException: in Symfony\Component\Routing\Matcher\UrlMatcher->match() (line 97 of vendor/symfony/routing/Matcher/UrlMatcher.php).

Drupal\Core\Routing\UrlMatcher->finalMatch(Object, Object) (Line: 152)
Symfony\Cmf\Component\Routing\NestedMatcher\NestedMatcher->matchRequest(Object) (Line: 258)
Symfony\Cmf\Component\Routing\DynamicRouter->matchRequest(Object) (Line: 185)
Symfony\Cmf\Component\Routing\ChainRouter->doMatch('/node/212', Object) (Line: 155)
Symfony\Cmf\Component\Routing\ChainRouter->matchRequest(Object) (Line: 89)
Drupal\Core\Routing\AccessAwareRouter->matchRequest(Object) (Line: 138)
Drupal\Core\Routing\AccessAwareRouter->match('/node/212') (Line: 139)
Drupal\user\Plugin\LanguageNegotiation\LanguageNegotiationUserAdmin->isAdminPath(Object) (Line: 109)
Drupal\user\Plugin\LanguageNegotiation\LanguageNegotiationUserAdmin->getLangcode(Object) (Line: 191)
Drupal\language\LanguageNegotiator->negotiateLanguage('language_interface', 'language-user-admin') (Line: 136)
Drupal\language\LanguageNegotiator->initializeType('language_interface') (Line: 223)
Drupal\language\ConfigurableLanguageManager->getCurrentLanguage() (Line: 84)
Drupal\language\EventSubscriber\LanguageRequestSubscriber->onKernelRequestLanguage(Object, 'kernel.request', Object) (Line: 116)
Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch('kernel.request', Object) (Line: 120)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 62)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 62)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 53)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 103)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 82)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 55)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 632)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

Problem/Motivation

The ckeditor_stylesheets property in a theme's info.yml makes it possible to CKEditor contents with CSS from the front-end theme. More info on ckeditor_stylesheets use here.

This also needs to be supported in the CKEditor 5 module, and in a way that applies the styles from ckeditor_stylesheets only to CKEditor, not the full page.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes