Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 292590

Cleanup of Book Manager Service

$
0
0

Problem/Motivation

Book Manager Service was a copy/paste of book function methods. Plenty of cleanup tasks brought up in #1938296: Convert book_admin_overview and book_render to a new-style Controller that are being moved here.

Proposed resolution

Cleanup of documentation from this lines of code from '/core/modules/book/lib/Drupal/book/BookManager.php'

  • Line 13: Manages a list of books.
  • Line 18: The database connection.
  • Line 25: Array of books keyed by book id
  • Line 44: @return array
    An array of all books keyed by book id. Each value is an array with the following keys: type, type, all the columns from the {book} table and all the columns from the {menu_links} table.
  • Line 55: Loads books array

Proposed cleanup from `/core/modules/book/lib/Drupal/book/Controller/BookController.php`

  • Line 27: Injects the book manager.
  • Adittion after line 27 for missing return: `@return \Drupal\book\Controller\BookController
    The book controller'
  • Line 34: Missing `@param`

At line 80, the method `bookRender()` doesn't actually print anything.

#1938296: Convert book_admin_overview and book_render to a new-style Controller


Viewing all articles
Browse latest Browse all 292590

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>