Update standards doc on plugin annotations
Coming from#1969970: How do document needed @Translation on dedicated It appears that our standards on plugin annotationshttp://drupal.org/coding-standards/docs#Plugin are outdated, in that it is more...
View ArticleTwig implementation does not print int(0)
Problem/MotivationDrupal's Twig implementation does not print anything for the following:{% set var = 0 %}{{ var }}This should print '0'.Proposed resolutionTrack down the bug and squash it. @Fabianx...
View ArticleBook navigation block ids don't match book ids
In the code comments in book-all-books-block.tpl.php, the book_id (array key for book_menus) is supposed to be the parent book ID. Instead, it's just a sequential number (starting with 0). In...
View ArticleSearch results twig template is missing */
The file core/modules/search/templates/search-results.html.twig needs to have a line saying*/ at the end of its documentation block (just before the line that says #} ). Without that line the doc block...
View ArticleDateTimeFieldTest is DatetimeFieldTest.php (incorrect case)
This is causing strange issues, among others, it is confusing Simpletest, while the test can be found and executed, the results screen is messed up and it's not possible to re-execute the test.Looks...
View ArticleInstall profiles cannot list their own requirements in drupal_check_profile
As it currently stands, install profiles cannot insert their own requirements during the install phase.drupal_check_profile grabs the info file from the install profile, and loops through all the...
View ArticleModules don't appear in the "Installed Mods" list, themes don't appear in...
I'm having an issue similar http://drupal.org/node/1881624 today. I updated 3 different drupal installations, and two fo them are fine. The third, I only updated 1 module (meta-tags), and this...
View ArticleConvert contextual.js to use Backbone
Core JavaScript is shifting to utilizing the Backbone framework where appropriate.
View ArticleClik here to view.
Stray reference to fieldset in vertical-tabs.js that was not updated to details
In the port from fieldsets to details elements, one reference to fieldset was not updated to details.STR.Create a custom blockSet the Chrome developer tools to stop on any exception under the Sources...
View ArticleSlow glob() calls in ConfigStorageController::buildQuery() with many yml files
I was testing a big upgraded with lots of fields (290 fields and 500 instances or so, 1600 yml files in total with entity displays, image styles and other things like that).One major performance issue...
View ArticleBreakpointGroup::loadAllBreakpoints() is extremely expensive
This loops through each breakpoint, and runs entity_load() on it. We have entity_load_multiple() for a reason.
View ArticleDrupal and PSR-0 Class Loading
Both quicksketch and webchick have asked me about this before. I'm sure others have voiced concerns too. This is a write up of what our current PSR-0 system uses, and possible...
View ArticleProvide default value for select option when no value was previously selected
When there is no saved value for a select list, drupal does not set a default value. This is fine in most circumstances, however, if the select list is ever sorted by a method other than the default...
View ArticleCleanup of Book Manager Service
Problem/MotivationBook Manager Service was a copy/paste of book function methods. Plenty of cleanup tasks brought up in #1938296: Convert book_admin_overview and book_render to a new-style Controller...
View ArticleReplace "utilize" with a proper verb
*Self nominated Trivial Patch of the Month*In English, "utilize" is not a proper verb. It is a nominalization -- a noun (utility) turned into a verb. Therre is a perfectly good verb -- "use" -- to use...
View ArticleIncorporate longdesc into image support
Just looking over this issue since @quicksketch rightly closed it - #193887: Accessibility enhancementsHTML5 now includes longdesc and it looks like it will have more support for all users in FireFox...
View ArticleShould core output invisible but audible block titles, and how?
Spin off of / follow up to #1968360: Remove per-region block markup. In that issue, we are removing bartik_preprocess_block()'s adding of the 'element-invisible' class to blocks in the header and...
View ArticleIf we're going to add a .js class then we probably should also remove any...
Even thought core doesn't actually put a .no-js class on the document it's pretty common practice now a days.Sadly the issue is drupal just adds a .js class but it does nothing about .no-js class. So...
View ArticleThe specified file could not be deleted, because it is not a valid URI. More...
I am getting the following message in my log after each cron run :"Could not delete temporary file "" during garbage collection" from various referrers. Is there a way to reset this or to find the...
View ArticlePatch Backbone.sync safely
#1. It needs to check options.editor existence. #2. All other Backbone scripts do not work unless you patch the script to use Backbone.defaultSync. It sounds wrong to me.AttachmentSizeStatusTest...
View Article