Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 302494

Complete conversion of comment form validation to entity validation

$
0
0

Problem

Follow-up for #2002158: Convert form validation of comments to entity validation: In the original issue all validation logic for fields has been converted to the entity validation API, however conditional validation logic that validates field values in dependence of another field value has not been converted. See CommentForm::validate() for the logic that needs conversion.

Proposed resolution

Solve #2105797: Figure out the best way to do conditional validation and apply the solution by moving validation logic to the CommentNameConstraint or other respective constraints.

Remaining tasks

All.

User interface changes

-

API changes

-

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue categoryBug because the conversion is supposed to be complete and required for REST validation to cover it.
Issue priorityCritical, because REST request might miss some validation logic.
DisruptionNot disruptive as comment and form validation works as before, comment entity validation just becomes more complete.

Viewing all articles
Browse latest Browse all 302494

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>