PHP DOM (libxml2) only understands XHTML4, misinterprets HTML5, but D8 must...
Problem/MotivationThe filters 'htmlcorrector', 'html' and the testing system needs html parsing and a valid DOM to work with. This is done by the libxml2 library provided in PHP that cleans html and...
View ArticleDon't do a registry_update() before installing a module
It is expected that module hook_update_N() implementations should not use the module's own APIs, but that is not for the module's hook_schema(), hook_install() or hook_enable() implementations.Drupal...
View ArticleNotice: Undefined index: uid in simple a user view
Updated: Comment #NProblem/MotivationSimple user views without field formatting on the username field result in the following error message:Notice: Undefined index: uid in...
View ArticleOptimize Drupal's Container::get()
Problem/Motivation\Drupal\Core\DependencyInjection\Container::get() is called repeatedly for service IDs that are already instantiated. That is as expected, but given that, it makes a measurable...
View ArticleViews UI: Exposed Filter css is not applied
Problem/MotivationWhen i edit a view i found an issue in exposed filter. UI of exposed filter is breaking. Adding screenshot of the issue.Proposed resolutionApply the exposed form css that comes with...
View Articlemodule_enable() exposes module hooks before the module's schema is...
Currently, the sequence of module_enable() is as follows (once it is determined that the module needs to be installed):The module's main code file ("*.module") is loaded.The module's install file...
View ArticleComplete conversion of comment form validation to entity validation
ProblemFollow-up for #2002158: Convert form validation of comments to entity validation: In the original issue all validation logic for fields has been converted to the entity validation API, however...
View ArticleWhy the 0.2em left margin for label in the seven theme?
I know we are looking very closely at styling so I wonder why there is a 0.2em left margin for the label in the seven theme? I'm also adding a little cut space between the baseline of the label and the...
View ArticleProperly inject services into ModuleInstaller
Follow-up to #2324055: Split up the module manager into runtime information and extension information.Problem/MotivationThe ModuleInstaller is littered with calls to \Drupal::service.Proposed...
View ArticleDrupal does not allow W3C compliant language codes where you target a numeric...
I have a need to create a Spanish site targeting a Latin American audience. It is my understanding that valid language code would be es-419 for this, but Drupal doesn't allow me to create this, instead...
View ArticleAdd an entity link template for lists
Problem/MotivationRight now, entity lists are not standardized as a link template. We have an entity_list route thingy, we have a list builder handler, but they are not connnected. Route names are not...
View ArticleExpand EntityDisplayBase with methods
Problem/MotivationPart of meta-issue #2016679: [Meta] Expand Entity Type interfaces to provide methods, protect the properties.API changesEntityDisplayInterface has been adjusted with the following...
View ArticleSaving the grants of a translated node has the wrong fallback set
Problem/MotivationThe fallback column is set based on $node->language()->getId(). If a translated node is saved this is not what we want. Ie.: let $node be an English node then $node->save()...
View ArticleDIC: Lazy instantiation of service dependencies (ProxyManager for "proxy...
Problem/MotivationCurrently, if a service A depends on another service B, then B needs to be instantiated at the same time or before the instantiation of A. This happens even if A might never actually...
View ArticleEditor Image dialog: alt text required_error does not close <em> tag
Problem/MotivationThe 'Alternative text' required error in the EditorImageDialog includes an <em> tag that is not closed. This results in the rest of the form being wrapped in the <em> tag....
View ArticleAdd a search/input group component
We are adding a grouped search component to Seven in #2160545: Create search/filter component and it seems like it would suit Bartik's search form as well.
View ArticleMerge selectnodetitle into core
selectnodetitle is a really small module that automatically gives the node title field focus, so the user can just start typing when the node add form loads.We should put this in core, then backport it...
View ArticleClean-up field_ui module test members - ensure property definition and use of...
The field_ui module uses test class members with underscored names. Some examples are big_user, web_user and admin_user, but there could be others. According to our coding conventions, these should be...
View Articlereturn FALSE on EntityManager::loadEntityByUuid with invalid UUID / non...
Problem/MotivationEntityManager::loadEntityByUuid breaks if you pass in a wrong / non existing UUID.Proposed resolutionLet's return FALSE, in case we have a wrong one.Remaining tasksUser interface...
View ArticleMove DrupalKernel::initializeCookieGlobals() into a SessionConfiguration service
Problem/MotivationThird party implementations should be able to modify session options and therefore DrupalKernel::initializeCookieGlobals() needs to be replaced by a service. Regrettably #2331909:...
View Article