Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 302490

Editor Image dialog: alt text required_error does not close <em> tag

$
0
0

Problem/Motivation

The 'Alternative text' required error in the EditorImageDialog includes an <em> tag that is not closed. This results in the rest of the form being wrapped in the <em> tag. Italics everwhere.

This bug was introduced in #2307647: [Follow-up] Allow manual override of required image alt text in the Text Editor image dialog when appropriate

To reproduce:

  1. Open the image dialog from the CKEditor
  2. Leave the 'Alternative text' field empty

Proposed resolution

@AlexPott #3
The is odd here. is for emphasis but we're putting the text in brackets () to visually de-emphasise it... how about we just remove the .

Remaining tasks

  • Write a patch.
  • Add screenshots to show the effect of the patch.
  • Review the patch.

User interface changes

The EditorImageDialog form keeps its original font style when the Alternative text is marked as required with a form error.

API changes

None

Screenshot before

/files/issues/editorimagedialog-before.png

Screenshot after


Viewing all articles
Browse latest Browse all 302490

Trending Articles