Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 294215

Make assertions using ConfigEntityValidationTestBase::assertValidationErrors() clearer

$
0
0

Problem/Motivation

\Drupal\KernelTests\Core\Config\ConfigEntityValidationTestBase::assertValidationErrors() was introduced in #3324150: Add validation constraints to config_entity.dependencies and currently just asserts an array of actual violation messages/validation error messages.

It'd be better to instead assert them based on the property path at which that validation error occurred, to avoid false positives. That's also what \Drupal\Tests\ckeditor5\Kernel\CKEditor5ValidationTestTrait::validatePairToViolationsArray() does.

Discovered this while working on #3341682: Add config validation to the "label" config schema data type.

Steps to reproduce

N/A

Proposed resolution

Improve it!

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

N/A


Viewing all articles
Browse latest Browse all 294215

Trending Articles