Refactor references to images in Claro's images/core directory
Sorry it took me a while to review this. The patch applies, but it's actually changing the color for several icons with different level of visual implication.Problem/MotivationIn #3045216: Asset paths...
View ArticleMake assertions using...
Problem/Motivation\Drupal\KernelTests\Core\Config\ConfigEntityValidationTestBase::assertValidationErrors() was introduced in #3324150: Add validation constraints to config_entity.dependencies and...
View ArticleSet the toolbar to position fixed on mobile
Problem/MotivationDuring the usability sessions, some participants did not notice the toolbar on mobile, as struggled to get back to their administrative content area.When the toolbar was originally...
View Article[meta] Make config schema checking something that can be ignored when testing...
Problem/MotivationThis is via a live conversation with @alexpott, hopefully I'm summarising it correctly.#784672: Allow text field to enforce a specific text format introduced a new key for text fields...
View Article[Followup] Fix Drupal.Commenting.FunctionComment.MissingReturnType returns...
Problem/MotivationIn #2941148: Fix Drupal.Commenting.FunctionComment.MissingReturnType return types were fixed. But this change NULL returns to return; whereas the return in the docblock is NULL....
View ArticleRevisions log on translated nodes should not show original language...
Problem/MotivationMotivation: Inconsistent behavior is confusing, and not seeing translation revisions hinders work of editors.Problem: Sometimes revisions tab on translated content only shows original...
View ArticleExternal application is redirected to frontpage in maintenance mode
Problem/MotivationWhen authorized headless consumer requests the site in maintenance mode, he gets 302 code instead of 503. Generally if it follows redirect it gets 503, but if homepage is forbidden...
View ArticleAdd poster image and transcript to HTML5 media videos
Problem/Motivation & Steps to reproduceDrupal core comes with several Media entities; audio, file, image, external video and local video.When a content editor uses the local video entity, it only...
View ArticleLocale configuration storage passes wrong arguments to install storage
Problem/MotivationThe signature of the \Drupal\Core\Config\InstallStorage::getComponentNames method has changed in this...
View ArticleAdding File Usage "File" relationship results in broken/missing...
Problem/MotivationRelationship id is missing in "file_to_node", "node_to_file", "file_to_user", "user_to_file" and other file related relationships.Steps to reproduce-------- From original summary -...
View ArticleUse proper machine names for permissions
PostponedAccording to #2350615: [policy, no patch] What changes can be accepted during the Drupal 8 beta phase?, this should be postponed to Drupal 9. Changing the permission's machine name may require...
View ArticleClik here to view.
Redesign the toolbar
Problem/MotivationThe existing Toolbar is the result of several UX improvements done for Drupal 7, but both Drupal and design and UX patterns have changed since then.This issue will focus on giving a...
View ArticleNotice: Undefined index: value in...
Problem/MotivationNumeric views filter (\Drupal\views\Plugin\views\filter\NumericFilter) and all child filters (Date, SearchApiDate, etc) throw a php notice when using grouped exposed filters with a...
View ArticleValidate configuration schema before importing configuration
It is possible to validate configuration using schema prior to importing. This will make the configuration import more robust by doing a pre flight check that what is being provided is sane.
View ArticleWhen enabling or disabling a block, don't move the focus to the top of...
A follow-up to #1848940: When enabling or disabling a View, don't move the cursor to the top of the page to address a similar issue in the Block UI.Problem/MotivationWhen a user enables, disables, or...
View ArticleAdd an alter hook to EntityQuery
EntityFieldQuery in D7 had an alter hook. When we rewrote it for D8, we forgot to add an alter hook. The dead docs were removed in #2611638: hook_entity_query_alter() is dead, remove it from...
View ArticleDeprecate _drupal_flush_css_js() and create a new AssetQueryString cache service
Problem/MotivationSplitting off a child issue from #3014752: [PP-1] Convert drupal_rebuild(), drupal_flush_all_caches() and _drupal_flush_css_js() functions into cache Rebuilder class where @alexpott...
View ArticleClik here to view.
ManyToOneHelper ignores group configuration for some cases
Bug descriptionWe've met a buggy behaviour of a view having two reference-field filters in an OR subgroup.That's how filters looked like:And this is the resulting query:There are two issues: 1. AND...
View ArticleSave FieldStorageConfig at the same time as FieldConfig
Problem/MotivationDuring the field creation flow, you first configure the "Field Storage Settings" and then are redirected to configure the "Field Settings". However, after the first step, the Field...
View Article