Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 293751

Comment views field handlers need to be replaced with field/entity aware handlers

$
0
0

Problem/Motivation

On #2393339: [META] Make sure Views base fields are using Field API for formatting, and do not lose functionality, we are updating all base entity fields in entity views data so that they are using Field API for formatting rather than using generic Views handlers.

This issue is about various fields in CommentViewsData that are currently using custom handlers from the Comment module:
- 'comment' handler for comment_field_data.subject and comment_field_data.cid
- 'comment_username' handler for comment_field_data.name ==> This is now a separate issue #2454163: Replace comment_username handler with generic views handler
- 'comment_depth' used for comment_field_data.thread

Proposed resolution

Change all of these to use the Field API formatter 'field' instead of the custom formatter. Should also be able to remove the custom formatters from the code base completely. That last one may need to have a custom handler, but if so it needs to derive from the Field API formatter so that it does the right thing with respect to entity access and translation.

Remaining tasks

Make a patch.

User interface changes

None.

API changes

Not really.


Viewing all articles
Browse latest Browse all 293751

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>