Problem/Motivation
I was reviewing the code of SystemController.php and noticed that there was a procedural t() function instead of $this->t() which is not a best practice to use inside a controller.
$admin_theme_options[$theme->getName()] = $theme->info['name'] . ($theme->isExperimental() ? ' (' . t('Experimental') . ')' : '');
Steps to reproduce
Proposed resolution
Fix Controllers in non tests for the sniff 'Drupal.Commenting.DocComment.ShortSingleLine'
That should be these files
- core/modules/views_ui/src/Controller/ViewsUIController.php
core/modules/book/src/Controller/BookController.phpMoved to contribcore/modules/tracker/src/Controller/TrackerController.phpMoved to contrib- core/modules/system/src/Controller/SystemController.php
- core/modules/update/src/Controller/UpdateController.php
Remaining tasks
review
commit