Add void return typehints to protected test helper methods
Problem/MotivationSee #3455549: Add return typehints to protected test helper methodsSteps to reproduceProposed resolutionUse...
View ArticleUncaught ReferenceError: loadjs is not defined after drupal core upgrade 9.5.1
Problem/MotivationAfter drupal core upgrade 9.5.1. I am getting Uncaught ReferenceError: loadjs is not defined in site. This is breaking other js in the site. This js defined in core.libraries.yml...
View ArticleTriggering deprecations for plugins using annotations when core plugin type...
Problem/MotivationPart of #3252386: Use PHP attributes instead of doctrine annotationsthis issue will not convert all plugin types to attributesProposed resolution- trigger deprecation error when some...
View ArticleReplace t() calls inside of Controllers that do not use StringTranslationTrait
Problem/MotivationI was reviewing the code of SystemController.php and noticed that there was a procedural t() function instead of $this->t() which is not a best practice to use inside a...
View ArticleMake label and category properties for layout plugins
Problem/MotivationPer How to register layouts:The 'label' and 'category' keys are required.This came up in #3392572: Add missing category to Drupal\layout_builder\Plugin\Layout\BlankLayout and let...
View ArticleAdd missing category to Drupal\layout_builder\Plugin\Layout\BlankLayout and...
Problem/MotivationThis issue is fixed in the 10.3.x branch, and it should be included in the 10.3.2 release. If you are using Drupal 10.2 (or 10.1, which is EOL) and are not ready to upgrade to 10.3,...
View ArticleImageAdminStylesTest::testAjaxEnabledEffectForm() fails because...
Problem/MotivationMoving to selenium has exposed a problem with the statusMessageExists() assertion. It does not wait - if the message is added by ajax there's no guarantee the message is there yet....
View ArticleMerge the build and lint stages in core MR pipelines
Problem/MotivationCore has three overall stages in gitlab pipelines: Build, Lint and Test.The build stage consists of two jobs - composer and yarn, which exist only to build caches/artifiacts for later...
View ArticleDetails element not correctly handling the #open attribute.
Problem/MotivationAccording to the documentation, passing the attribute `'#open' => FALSE` to the Details element will output the <details> as collapsed by default.It's not, the Details...
View ArticleUpdate help_topic tests to HTML5
Problem/MotivationFollow up from #2441373-99: Upgrade tests to HTML5 were help_topic tests were split out.there is a problem in one case, on bad_html3 help topic error template. Likely the parsing is...
View ArticleNewline character in HtmlTag causes unwanted whitespace
A '\n' (newline) character is included at the end of every tag output by theme_html_tag(). This causes extra whitespace that may not always be desired. One specific example is for use with sprite icons...
View ArticleOptimize Drupal\Core\Template\Attribute
ProblemDrupal\Core\Template\Attribute has become a bit of a God class with too many responsibilities. Move CSS Class parsing code off to its own class and apply some speed improvements to the logic of...
View ArticleBaseFieldOverride fails to take into account...
Postponed on #2283977: Create a new ConfigEntity type for storing bundle-specific customizations of base fields, which is introducing the BaseFieldOverride class described in this...
View ArticleExplore PHP 8.4 native HTML 5 parser vs html5-php
Problem/MotivationThere's feature freeze of PHP 8.4 coming but new HTML5 classes already available (in alpha releases) and core nww using masterminds/html5 library after #1333730: [Meta] PHP DOM...
View ArticleAccessDeniedSubscriber should extend HttpExceptionSubscriberBase
Problem/MotivationAccessDeniedSubscriber seems to be the perfect use case for HttpExceptionSubscriberBase. Instead it implements some logic that is already offered out-of-the-box by...
View Article[policy no patch] Make it possible to mark plugins as deprecated
Problem/MotivationIn #2916740: Add generic entity actions we want to mark some node and comment action plugins as deprecated and replace them with generic entity actions. Since #2870194: Ensure that...
View ArticleCreate Javascript library for searching/filtering rendered lists on the client.
Problem/MotivationThere are several places in core where the user searches in a text area to filter a list that is already rendered on the page. This filtering does not require any call back to the...
View ArticleMigrate Toolbar button to SDC
Problem/MotivationSDC is part of core now, so we can migrate the existing code to take advantage of SDC.Create Toolbar button into a SDCMove the component Toolbar button into its own SDC.Remaining...
View ArticleClik here to view.
Issue with HTML ` ` not being correctly filtered out
Problem/MotivationHey, After updating to Drupal 10.2.5, I've encountered an issue in one of my projects where our automated tests related to the HTML filter are failing. The problem arises with HTML...
View ArticleUsing LocalRedirectResponse with "<front>" URL in controller...
Problem/MotivationWhen I tried to create a redirection route in a contrib module, #3228805: How to use with for tfa (two factor authentication aka 2fa), using LocalRedirectResponse I faced...
View Article