Problem/Motivation
View modes have 3 property paths that are not yet validatable:
./vendor/bin/drush config:inspect --filter-keys=core.entity_view_mode.taxonomy_term.full --detail --list-constraints --fields=key,validatability,constraints
➜ 🤖 Analyzing…
--------------------------------------------------------------------- ------------- ---------------------------------------------------------------------------------------------
Key Validatable Validation constraints
--------------------------------------------------------------------- ------------- ---------------------------------------------------------------------------------------------
core.entity_view_mode.taxonomy_term.full 79% ValidKeys: '<infer>'
core.entity_view_mode.taxonomy_term.full: Validatable ValidKeys: '<infer>'
core.entity_view_mode.taxonomy_term.full:_core Validatable ValidKeys:
- default_config_hash
core.entity_view_mode.taxonomy_term.full:_core.default_config_hash Validatable NotNull: { }
Regex: '/^[a-zA-Z0-9\-_]+$/'
Length: 43
↣ PrimitiveType: { }
core.entity_view_mode.taxonomy_term.full:cache Validatable ↣ PrimitiveType: { }
core.entity_view_mode.taxonomy_term.full:dependencies Validatable ValidKeys: '<infer>'
core.entity_view_mode.taxonomy_term.full:dependencies.module NOT ❌ @todo Add validation constraints to ancestor type: config_dependencies
core.entity_view_mode.taxonomy_term.full:dependencies.module.0 Validatable NotBlank: { }
ExtensionName: { }
ExtensionExists: module
↣ PrimitiveType: { }
core.entity_view_mode.taxonomy_term.full:description Validatable Regex:
pattern: '/([^\PC\x09\x0a\x0d])/u'
match: false
message: 'Text is not allowed to contain control characters, only visible characters.'↣ PrimitiveType: { }
core.entity_view_mode.taxonomy_term.full:id NOT ⚠️ @todo Add validation constraints to config entity type: core.entity_view_mode.*.*
core.entity_view_mode.taxonomy_term.full:label Validatable Regex:
pattern: '/([^\PC])/u'
match: false
message: 'Labels are not allowed to span multiple lines or contain control characters.'
NotBlank: { }
↣ PrimitiveType: { }
core.entity_view_mode.taxonomy_term.full:langcode Validatable NotNull: { }
Choice:
callback: 'Drupal\Core\TypedData\Plugin\DataType\LanguageReference::getAllValidLangcodes'↣ PrimitiveType: { }
core.entity_view_mode.taxonomy_term.full:status Validatable ↣ PrimitiveType: { }
core.entity_view_mode.taxonomy_term.full:targetEntityType NOT ⚠️ @todo Add validation constraints to config entity type: core.entity_view_mode.*.*
core.entity_view_mode.taxonomy_term.full:uuid Validatable Uuid: { }
↣ PrimitiveType: { }
--------------------------------------------------------------------- ------------- ---------------------------------------------------------------------------------------------
Steps to reproduce
- Get a local git clone of Drupal core
11.x. composer require drupal/config_inspector— or manually install https://www.drupal.org/project/config_inspector/releases/2.1.5 or newer (which supports Drupal 11!)composer require drush/drushvendor/bin/drush config:inspect --filter-keys=core.entity_view_mode.taxonomy_term.full --detail --list-constraints
Proposed resolution
Add validation constraints to:
core.entity_view_mode.*.*:dependencies.modulecore.entity_view_mode.*.*:idcore.entity_view_mode.*.*:targetEntityType
This requires looking at the existing code and admin UI (if any) to understand which values could be considered valid. Eventually this needs to be reviewed by the relevant subsystem maintainer.
For examples, search *.schema.yml files for the string constraints:😊
Reach out to @borisson_ or @wimleers in the #distributions-and-recipes.
Remaining tasks
User interface changes
None.
API changes
None.
Data model changes
More validation 🚀
Release notes snippet
None.