comment subject line is too short for multibyte languages
Problem/MotivationThe comment subject field limit of 64 characters is too short. Steps to reproduceDo a Standard Drupal 11 installation. Make sure the Comment module is enabledCreate a node of type...
View ArticleReplace lazy service proxy generation with service closures
Problem/MotivationAs discussed in #3228623: DX: Creating lazy services is too difficult/obscure/bespoke/brittle the DX for our current lazy service proxies is poor. We tried using symfony lazy services...
View ArticleFix 'Drupal.Commenting.InlineComment.DocBlock' coding standard
Follow-up to #2572659: Fix 'Drupal.Commenting.InlineComment.SpacingAfter' coding standardPart of #2571965: [meta] Fix PHP coding standards in core.ApproachWe are testing coding standards with PHP...
View ArticleUserCreationTrait::checkPermissions contains unreachable code
Problem/MotivationSplitting out from https://www.drupal.org/project/drupal/issues/2234295#comment-15699921Steps to reproduceSee codeProposed resolutionRemove $valid from checkPermissionsRemaining...
View ArticleAdd an API for comparing the (current) route name that takes into account...
Problem/MotivationIn #3159210: Support route aliasing (Symfony 5.4) and allow deprecating the route name we added the ability to deprecate routes, but we later found that usages of...
View ArticleFix PHPStan missingType.generics for FieldItemListInterface not specifying...
Problem/MotivationFix i$ignoreErrors[] = [ 'message' => '#^Method Drupal\\\\Core\\\\Entity\\\\ContentEntityBase\\:\\:getTranslatedField\\(\\) return type with generic interface...
View ArticleClik here to view.
Add view tags on administrative list of views
Problem/Motivation#2574767-36: Views listing page displays too few items on a page removed the "Tags" column from the list of views at /admin/structure/views, because it was rarely used. I don't...
View Article[META] Replace t() calls inside of classes
Problem/MotivationThere's many places in core where t() function is used in classes without dependency injection. It makes this classes hard to unit test because t() defined in...
View ArticleClik here to view.
Content translation access manager may use the wrong revision
Problem/MotivationThe content translation manager sometimes looks for existing translations on the wrong revision ("active" instead of "latest") of an entity. This assumes content moderation is active...
View ArticleFix Drupal.Commenting.FunctionComment.Missing in Plugins
Problem/MotivationWorking to enable the sniff Drupal.Commenting.FunctionComment.Missing.Now that most of the views plugins have been fixed in other issue, fix this sniff for all Plugins not in...
View ArticleAllow big pipe to run for session-less users
Problem/MotivationBig pipe currently only runs when the user has a session, this is for two reasons:1. Edge caching doesn't work with streamed responses, at least until Symfony supports HTTP...
View ArticleAjax error while installing Drupal11
I am getting Ajax error while installing drupal11,An AJAX HTTP request terminated abnormally. Debugging information follows. Path:...
View ArticleFix Drupal.Commenting.FunctionComment.Missing in Unit tests
Problem/MotivationWorking to enable the sniff Drupal.Commenting.FunctionComment.Missing.Steps to reproduceProposed resolutionFix this sniff for Unit testsRemaining tasksReviewUser interface...
View ArticleAdd validation constraints to core.entity_view_mode.*.*
Problem/MotivationView modes have 3 property paths that are not yet validatable:./vendor/bin/drush config:inspect --filter-keys=core.entity_view_mode.taxonomy_term.full --detail --list-constraints...
View ArticleFix Drupal.Commenting.FunctionComment.Missing in Functional tests
Problem/MotivationWorking to enable the sniff Drupal.Commenting.FunctionComment.Missing.Steps to reproduceProposed resolutionFix this sniff for Functional testsRemaining tasksFix remaining erros...
View Article[meta] Fix Drupal.Commenting.FunctionComment.Missing
Problem/MotivationThis is a part of the attempt to fix #2572645: [Meta] Fix 'Drupal.Commenting.FunctionComment' coding standardThis issue is created to work on the...
View ArticleAdd validation constraints to comment.type.*
Comment type entity is not yet fully validatable:./vendor/bin/drush config:inspect --filter-keys=comment.type.comment --detail --list-constraints --fields=key,validatability,constraints > 🤖...
View ArticleAjax callback inside views plugin doesn't work.
Problem/MotivationWhen you make a new views plugin wiith ajax form inside, the ajax callback of form not working on the first reload. If you open the settings of plugin in a second time everything is...
View ArticleIncorrect content-length header breaks HTTP/2 with net::err_http2_protocol_error
Problem/MotivationAfter a migration from Drupal 9.5.11on to 10.2.2 on OVH mutualized server, the document is not loaded, JS files are not running and the error err_http2_protocol_error error is...
View ArticleCSRF check always fails for users without a session
Problem/MotivationAny route using the _csrf_token requirement doesn't work for users without session because the CSRF checker fails as the CSRF seed is not stored anywhere. Proposed resolutionOnly add...
View Article