Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 293129

[PP-1] After applying a recipe, it should be possible to remove the backup checkpoint

$
0
0

Problem/Motivation

#3407956: Create a config storage checkpoint before applying a recipe made RecipeCommand create a checkpoint before the recipe is applied, for backup purposes. Once the recipe successfully applies, the checkpoint probably isn't needed anymore, but it's kept anyway.

That's not a big deal from a safety perspective, but if you apply a lot of recipes, it will eventually make a mess of old, defunct checkpoints that you don't need. So I'd say this is needed in order for recipes to be usable in the wild.

Proposed resolution

Add a --no-keep-checkpoint option to RecipeCommand which will delete the backup checkpoint once the recipe has been successfully applied. If the recipe fails to apply (throws an exception), the backup checkpoint should remain.

Remaining tasks

This is hard-blocked by #3409718: Add CheckpointListInterface::merge() or ::squash() to allow NOT keeping a checkpoint after application, which will fix a bug wherein deleting a checkpoint deletes all the checkpoints before it.

Once that's done, it should be reasonably straightforward to implement this with tests.


Viewing all articles
Browse latest Browse all 293129

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>