Task
Prefix form-item classes with js- to separate classes needed for JavaScript functionality from those used for styling and make it clear which classes can safely be removed without breaking JavaScript functionality.
Remaining tasks
- Patch
- Patch review
- Manual testing
Steps to test
- Navigate to
admin/structure/types/manage/article/fields/add-field - Test that the machine name functionality still works
Beta phase evaluation
| Issue category | Bug report, there is currently a class missing from the non-Classy text-format-wrapper.html.twig. |
|---|---|
| Unfrozen changes | Unfrozen because it mostly just affects templates and JS which are not frozen. |
| Prioritized changes | The main goal of this issue is to improve themer experience and arguably it reduces fragility where JavaScript and markup intersect. |
| Disruption | Shouldn't be too disruptive as it is mostly affecting CSS classes that are added to markup. Themes extending Classy will only have classes added. Themes not extending Classy will have classes removed but they can be added back via template overrides. |
User interface changes
None for themes extending Classy. Possible visual changes for other themes.
API changes
n/a