Quantcast
Channel: Issues for Drupal core
Viewing all articles
Browse latest Browse all 293443

_locale_export_po_generate must not create empty msgid and they mustn't contain "\r"

$
0
0

In includes/locale.inc, _locale_export_po_generate outputs the following:
_locale_export_string($string['source']); as a value for msgid without testing the string is non-empty.
But there should be only one empty msgid in a po file: inside its header.
msguniq from gettext will abort on a duplicate empty msgid and such a po file will be unusable until you manually remove the duplicated empty msgid.

Other than that, msgid should not contains "\r" escape-sequence (msg* utils will throw a warning on them).


Viewing all articles
Browse latest Browse all 293443

Trending Articles