Decide if we need a hook for controlling access to a block plugin, not just a...
We currently have a hook_block_access() for modules other than the one implementing the block to have a say in determining block access. This hook is invoked on the block entity, not on the block...
View ArticleThrow an exception in ConfigEntity::save() (or even Entity::save() ?) if the...
Followup from #1969698: Field UUID changes can badly corrupt field data, postponed on discussion in #1969800: [META] Discuss how and whether the configuration system, config entities, or their...
View ArticleRename ViewsDataCache to ViewsData
It makes sense to rename the ViewsDataCache class to just ViewsData, it manages the views data, and just happens to use the cache backend and manage the getting/setting. So it's not just a cache it IS...
View ArticleDrupal 6 Search module double ID's
There was a problem on the search page of the site with a double ID:<div class="form-item" id="edit-keys-wrapper"> <label for="edit-keys">Enter your keywords: </label>...
View ArticleClean up/improve consistency of Edit
Blocked on #1979784: Factor Create.js and VIE.js out of the Edit module.Rename data-edit-id to data-edit-field-idRename data-edit-entity to data-edit-entity-idRename the 'direct' editor to 'plaintext'...
View ArticleClean Drupal way to sanitize form's default values?
So, let's assume there is an item named Molot's e-book reader (close enough to real life facts). And let's assume there is a form displaying all my possession. This seems...
View ArticleAllow URLs with query string
Why are the URLs for a feed restricted to ending with a file extension like '.xml'? There are feeds out there that need a query string, for a example something non-public that needs a hash as...
View ArticleFunction field_language() may return the wrong display language under certain...
The Field Language API function field_language() may return the wrong display language for an entity which is in the process of being created (e.g., during the preview of a node which references the...
View ArticleAdd a dedicated @Condition plugin annotation
A part of #1966246: [meta] Introduce specific annotations for each plugin typeAttachmentSizeStatusTest resultOperationsdb.condition-annotation.patch4.21 KBIdlePASSED: [[SimpleTest]]: [MySQL] 55,555...
View ArticleNever skip 'Verify requirements' on install
When restarting an unfinished install, the 'Verify requirements' task is skipped and the installer directly moves on to 'Setup database' or a later step.In the meantime however, the requirements might...
View ArticleConvert system_modules() to a Controller
Convert the form builder system_modules() to a new-style Controller, using the instructions in the WSCCI Conversion Guide.
View Articletemplate_preprocess_comment() is preparing the parent's author with the wrong...
Problem/MotivationWas reviewing the template_preprocess_comment() function's code and noticed a bug. The parent comment author was being built off the wrong comment. if...
View Articlenode_preview() shouldn't call hook_field_load()
According to the documentation hook_field_load() seems to be the place to load additional data for a field-type once the field item has been loaded from the field-storage.During my investigations of...
View ArticleForm api #ajax callbacks inside vertical tabs are broken
When defining a fapi #ajax callback inside a vertical tab (==> inside a details element) it never works. This used to work in D7. You can test this by:1) Downloading latest dev code from display...
View ArticleRegression: Adding/removing a shortcut (or otherwise changing the toolbar)...
In Drupal 8: Open the overlay and click the + (or -) icon next to a page title to add (or remove) it from the shortcuts. Then look at the shortcuts tab in the toolbar and notice it has not been updated...
View ArticleConvert MachineNameControllerTest to PHPUnit
When #1842718: Use new Transliteration functionality in core for machine names landed we still had the unicode string functions in procedural code. Now that #1938670: Change notice: Convert unicode.inc...
View ArticleTest info not displayed for PHPUnit tests when using run-tests.sh
If run PHPUnit test using run-tests.sh then the info is not correctly retrieved from the class... for example:$ php ./core/scripts/run-tests.sh --class...
View Article"Edit shortcuts" link in the toolbar points to a nonexistent page (as does...
Looks like some URLs got changed at one point to include 'manage', but weren't updated everywhere.
View ArticleShortcuts in the toolbar appear in alphabetical order (which doesn't match...
If you add the "Extend" page as a shortcut (using the plus icon next to the page title) and then add "Configuration" afterwards, the shortcuts in the shortcut bar in the toolbar should appear in the...
View Article