Skip Config::save schema validation of config data for trusted data
Problem/MotivationConfiguration Import is slow and needs a lot of memory.A lot of that is the schema validation in Config::save. We also recalculate the dependencies for all configuration...
View ArticleComment pager-dependent cache key should be a cache context
Reported by Berdir:/** * Implements hook_entity_build_defaults_alter(). */function comment_entity_build_defaults_alter(array &$build, EntityInterface $entity, $view_mode = 'full', $langcode = NULL)...
View ArticleImplement admin role as a flag on the role storage, simplify permissions...
Problem/MotivationCore has an admin role, which has by design all permissions. To achieve this user.module traditionally assigned all new permissions to the admin role.This approach is flawed in...
View ArticleMake the mobile breakpoint for Bartik empty
Follow-up to #2334387: UI changes to support current responsive image standardsProblem/MotivationResponsive images module now allows an empty breakpoint, but since there's no UI for the moment, you can...
View ArticleSplit drupal.js
Problem/MotivationDrupal.js mixes the behaviors attachment/dettachment with several API level functions. Let's split those for having clearer dependencies.Proposed resolutiondrupal.init.js defines the...
View ArticleAllow adding entity level constraints
ProblemFor being able to solve #2395831: Entity forms skip validation of fields that are not in the EntityFormDisplay (critical) we need to be able to define general, entity-level validation...
View ArticleStatic cache permissions
Problem/MotivationPermissionsHandler:moduleProvidesPermissions costs quite a lot and so should be static cached.Proposed resolutionStatic cache result Let ::getPermissions accept an optional module...
View ArticleMaintenance Mode after Database Update
After installing D8 and a subfolder, I received the message that the database was outdated. After I did the database update, the site entered in maintenance mode. How to solve this?
View ArticleToolbar expects breakpoints ordered from smallest to largest; responsive...
Problem/Motivation#2260061: Responsive image module does not support sizes/picture polyfill 2.2 updated responsive image support to use the current spec for the picture element. The picture element can...
View ArticleRace conditions in the twig template cache
Problem/MotivationWhen you are clearing caches while a site is being visited, then you sometimes get fatal errors like this:Class...
View ArticleThere is no way to validate a property containing a country code
Drupal provides the country list via the CountryManager. Entity properties sometimes have a need to store the country. There is no constraint/validator that would validate the country against Drupal's...
View ArticleConvert existing drupal_render() KernelTestBase tests to PHPUnit tests
Problem/MotivationDrupal\system\Tests\Common\RenderTest uses KernelTestBase.Since #2346937: Implement a Renderer service; reduces drupal_render / _theme service container calls, it can be converted to...
View ArticlePostgreSQL: Fix tests in views test group
This issue is part of #2157455: [Meta] Make Drupal 8 work with PostgreSQL.Currently there is one or more fail or exception in the views test group identified by the new docker based testbot that need...
View ArticleFields of type 'Text (formatted)' do NOT save values.
Problem/MotivationAny field of type 'Text (formatted)' simply does not save the data entered into it when a module is enabled that alters the element info for #type text_format and adds an additional...
View ArticleLimit PDO MySQL to executing single statements if PHP supports it
One of the reasons for the severity of https://www.drupal.org/SA-CORE-2014-005 was the fact the PDO MySQL allows multiple statements to be executed.In contrast, the mysqli functions used for Drupal...
View Article[meta] svg guidelines / requirements
Problem/MotivationWe need some guidelines for svg & svg icons for Drupal core.The issue have come up during the work on the RSS icon #2427213: replace feed.png with feed.svgTo sum it up we need...
View ArticleRemove node title field description
When I add content I get a title field with description text of "The title of this node, always treated as non-markup plain text."The first part is redundant and uses the word 'node' although the...
View Article[PP-1] Entity/field access and node grants not taken into account with core...
Opening this after discussions at DrupalCon this week.Field access and entity access modules complicate entity render caching quite a bit, couple of examples:1. An entity reference holds 3 referenced...
View ArticleRemove html => TRUE option from l() and link generator.
Problem/MotivationFollow-up to #1825952: Turn on twig autoescape by defaultRather than benefiting from Drupal 8's autoescaping, LinkGenerator::generate() (and by extension, Drupal::l() and...
View ArticleRemove UserAutocompleteController
Problem/MotivationNow that we have a generic 'entity_autocomplete' form element, UserAutocompleteController is just duplicated functionality.Proposed resolutionConvert its usage to...
View Article