Problem with drupalLogin in simpletest
Hi!I'm not sure what I'm doing wrong.code in my setUp() function:<?php $this->admin_user = $this->drupalCreateUser(array('access administration pages', 'administer modules'));...
View ArticleContentEntityBase::__construct() lacks documentation
Problem/MotivationWhile writing the mongodb content entity storage passing back stored data to ContentEntityBase was the biggest mystery. I have figured it out, I think. Proposed resolutionDocument the...
View ArticleChange String::format()'s '@' and '%' placeholders...
Problem/MotivationNow that we have SafeMarkup::escape(), which has more intelligence than String::checkPlain(), there's no reason not to use it within String::format().Doing so will allow '@' to be...
View Article(change notice, etc.) String::format() marks a resulting string as safe even...
Problem/MotivationIssue title says it all.Proposed resolutionChange String::format() to not call SafeMarkup::set() on the result if there are one or more passthrough arguments that are not...
View ArticleConvert theme_views_view_fields() to 100% Twig: remove the theme function
TaskUse Twig instead of theme functionRemainingRemove the theme_ functionRevisit performanceThere is already a twig file for this purpose. views-view-fields.html.twig.There is a preprocess function for...
View ArticleCheck if Twig loaders can protect against infinite loops/self references
Problem/Motivation#2291449: Add Twig template inheritance based on the theme registry, enable adding Twig loaders brought up that it's possible to get infinite recursion if you extend the current...
View ArticleREST user updates bypass tightened user account change validation
ProblemSpin-off from #2405943: User entity validation misses form validation logic: When you edit your user account, you have to provide the existing password when you want to change the password or...
View ArticleEntity forms skip validation of fields that are not in the EntityFormDisplay
Spin-off from #2002180: Entity forms skip validation of fields that are edited without widgetsProblem/MotivationEntity changed validation (=ensure no one edited the entity while editing it) gets...
View ArticleAdd an 'empty' libraries folder and encourage people to use it...
We should add a sites/all/libraries folder like sites/all/modules and sites/all/themes to encourage people to use it properly.
View ArticleTests for Annotation Component
Problem/MotivationThe annotation component has 0 explicit testing.Proposed resolutionAdd tests.Remaining tasksReview and commit patch.Beta phase evaluationReference:...
View ArticleAdd cache wrapper to the UrlGenerator
Problem/MotivationThis is a follow-up for #1888424: Make Drupal's URL generation logic available to HttpKernel, and minimize code repetition/divergence Part of this is postponed on #2351015: Convert...
View ArticleNotices in comment_submit() and comment_admin_overview() when body field does...
Summary updated until comment #101.(The following happens in D7. The comment module in D8 has no problems, according to #99 and #101.)After changing the comment_body field of a content type, the...
View ArticleRegression: There is no (resonable) way to programmatically render a block
In D6 you could easily render a block by doing this:<?php $block = module_invoke($module, 'block',$delta); $output = theme('block', $block);?>In D7, module_invoke($module, 'block' ,$delta);...
View ArticlegetPrefixInfo() calls wrong function to get the connection info
There is an issue with the getPrefixInfo() function. It uses Database::getConnectionInfo(); which returns the wrong database connection info when using multiple databases. It should use...
View ArticleAllow the image style 'itok' token to be suppressed in image...
Problem/MotivationThe itok token introduced in 7.20 prevents working with CDNs, third party integrations that generate image presets on the fly. To understand the Image style token, itok, read Drupal...
View ArticleDocument that ConfigEntityBase and ConfigStorageController are tightly coupled
Problem/MotivationUnless a config entity always uses or subclasses ConfigEntityStorage, there is no way to be sure that it supports overrides, dependency management, scalable entity queries,...
View ArticleField of type Text/Summary not editable
I've imported nodes with a description field of type Text/Summary. Importing is done with Feeds and Tamper module. The field is shown fine in node display mode. As soon as I reference the field or show...
View ArticleRemove drupal_static from ViewAjaxController::ajaxView
Child of #1577902.ViewAjaxController::ajaxViewhas calls to drupal_static(). These should be replaced with protected properties.
View ArticleSpecific menu theme suggestions based on block
Problem/MotivationPeople might want to render one menu with different markups. That might be necessary in scenarios where there is different styling for menu in mobile and desktop version. There is no...
View Article