Enforce return types to non-inheritable navigation methods
Problem/MotivationOnce #3461318: Enforce return types in all new methods and functions has been merged, a bunch of PHPStan ignore rules related to Navigation module were added to...
View ArticleEnable Drupal.Commenting.FunctionComment.InvalidNoReturn
Problem/MotivationFix the return types in the these methods. 1 core/lib/Drupal/Component/Plugin/PluginManagerBase.php 2 core/lib/Drupal/Core/Database/Connection.php 3...
View ArticleTypeError: array_filter(): Argument #1 ($array) must be of type array, null...
Problem/MotivationI get this error when submitting a billing profile with a date field, using select list to pick a date.Steps to reproduceUse a date field in a billing profile in Drupal Commerce,...
View ArticlePerformance Degraded after update to twig 3.14.2
Problem/MotivationThis is probably a twig issue and not Drupal, however, there appears to be a significant page load performance issues (especially on admin entity create/edit forms such as node forms)...
View ArticleReplace \PDO::FETCH_* constants to indicate fetch mode with an enumeration
Problem/MotivationIn #3345938: Deprecate support for unused \PDO::FETCH_* modes, we normalized the fetch modes used in Drupal's database operations. However, we fell short of introducing our own logic...
View ArticleClik here to view.
Password and confirm password should be mandatory fields while setting up...
Problem/MotivationClicking on the forgot password link it generate one time use password reset link which is send via mail. After clicking on the link we can see that Password and confirm password are...
View ArticleFix usage of str_getcsv() and fgetcsv() for PHP 8.4
Problem/MotivationAccording to RFC escaping should be always provided- https://wiki.php.net/rfc/deprecations_php_8_4#deprecate_proprietary_csv_... - https://github.com/php/php-src/pull/15365Steps to...
View ArticleEntity view/form mode formatter/widget settings have no translation UI
Problem/MotivationAdd missing configuration translation interface.There are several pieces of information from the Entity/Field system, which may include translatable strings, but which prior to this...
View ArticleRemove comment and node preview
Problem/MotivationComments and nodes both offer 'preview' functionality: when you're creating or editing the entity, there's a preview button on the form, and it will show you an approximation of what...
View ArticleClaro's CSS naming is too generic, clashes with custom theme styles in...
One of the obvious needs of the wysiwyg (ckeditor) is to have stylesheets that styles elements to match the theme front-end. This includes entity embeds, that probably will have class names like...
View ArticleConfig translation needs to be validated on input for XSS (like other t...
Ingested t() strings are normally validated on input for XSS (as opposed to user input that's filtered on output)For example in D7:...
View ArticleDisable preview on node and comment types by default
Problem/MotivationAs a first step toward #3244848: Remove comment and node preview, we could update the default preview setting for node and comment types from 'Optional' to 'Disabled'.This is...
View ArticleThe `node_revision_link_revert` views plugin should consider whether the node...
Problem/MotivationThe Revert link produced by the node_revision_link_revert views plugin does not consider whether the content has been translated.The plugin will always produce a...
View Article10.3 upgrade now missing status-message theme suggestions
Problem/MotivationMessageCommand and the associated JavaScript API was added to Drupal core in 2019/Drupal 8.8.0, but was not used widely in Drupal core until 10.3.0, when the bigpipe module began...
View ArticleChange default escaping of str_getcsv() and fgetcsv() to empty string
Problem/MotivationFollow-up to #3477324-7: Fix usage of str_getcsv() and fgetcsv() for PHP 8.4Reading https://www.php.net/manual/en/function.fgetcsv.php Warning When escape is set to anything other...
View ArticleLength of menu_tree.url and menu_tree.route_param_key are too short (255...
Problem/MotivationURL/route lengths in the database need to be long enough for typical use. In reviewing the codebase, we found two menu_tree database fields (route_param_key and url) that are too...
View ArticleIntroduce a Schema::executeDdlStatement method
Problem/MotivationIf a database does not support transactional DDL, executing statements that alter the database structure in the midst of a transaction lead to the transaction to self-commit.In our...
View Article[META] Make Drupal 10/11 compatible with PHP 8.4
Problem/MotivationPHP 8.4 is expected on November 21, 2024. Release schedule is https://wiki.php.net/todo/php84 Release cycle change https://wiki.php.net/rfc/release_cycle_updateProposed...
View ArticleTimestamp field type uses numeric filter plugin rather than date filter plugin
Problem/MotivationWhen using a custom timestamp field to filter a view the filter type used is the numeric filter, rather than the expected date filter, this prevents the view from being filtered by an...
View ArticleUse TrustedRedirectResponse Error on Multilingual Setup
Problem/MotivationI received the following error while setting up a multilingual website:Redirects to external URLs are not allowed by default, use \Drupal\Core\Routing\TrustedRedirectResponse for it....
View Article