ComponentPluginManager must implement CategorizingPluginManagerInterface
Problem/MotivationSDC components have a group property: https://api.drupal.org/api/drupal/core%21modules%21sdc%21src%21Component...But it doesn't seem this property is leveraged until now. Proposed...
View ArticleSingle Directory Components templates are not auto reloaded after change
Problem/MotivationWhen twig.config:auto_reload is true, the component's templates are not refreshed, they only refreshed after the change to the YML file. This is also weird because the parsed YML file...
View ArticleExtra field blocks render even when empty
Problem/MotivationWhen adding an empty extra field in Layout Builder, the resulting page will always render the wrapping div of ExtraFieldBlock even when the extra field has empty...
View ArticleAdd a trait for autowiring properties in tests
Problem/MotivationCurrently when adding services as properties in tests you need to declare the properties and initialize them in ::setUp. This is unnecessary boilerplate.Steps to reproduceProposed...
View ArticleUse symfony/var-exporter for encoding data in PHP cache backend
Problem/Motivationunserialize is slow. Even though the cache items are stored in PHP files unserialization is still slow. Opcache does not much help in this case.On Drupal sites served from Page Cache,...
View ArticleReplace custom weights with dependencies in library declarations; introduce...
Problem/MotivationLibraries allow custom weights to be specified for each individual file, this has been shown to be fragile/brittle in issues such as #3222107: Library order asset weights do not work...
View ArticleUpdate Composer dependencies for 10.4.0-beta1
Problem/MotivationYes, there's no alpha release yet! Yes, it's probably too early for this! Yes, it's an ever moving target!I'm going to do it anyway, even if it isn't committed right away.If we hit...
View ArticleUpgrade twig/twig to 3.15.0
Problem/MotivationThere's new release which breaks lots of tests https://github.com/twigphp/Twig/blob/v3.15.0/CHANGELOGSteps to reproduceUpgrade and run testProposed resolutionUpgrade and fix...
View ArticleUnhandled exception when trying to register a duplicate username with...
Problem/MotivationIn https://www.drupal.org/project/drupal/issues/3415582, an unhandled exception when trying to register a duplicate username with different case was fixed. However, we've now noticed...
View ArticleRemove use of deprecated "spaceless" filter in core templates
Problem/Motivation%Since twig/twig 3.12: Twig Filter "spaceless" is deprecated% Steps to reproduceProposed resolutionWe can remove it without any problems and get better...
View ArticleReduce jQuery usage in dialog.ajax.js
Problem/MotivationI discovered today that in addition to the dialogue itself, we have a fairly large amount of jquery code.I believe that in order to make switching to a native dialog easier in the...
View ArticleTypeError: Cannot access offset of type string on string in...
Problem/MotivationGetting errors when viewing Recent Log Messages.TypeError: Cannot access offset of type string on string in Drupal\views\Plugin\views\area\Text->preQuery() (line 51 of...
View ArticlePrefer to replace some of typeof obj !== 'undefined' with optional...
Problem/MotivationSome of JavaScript checks object existence with typeof obj !== 'undefined' and checks property existence in the object. For example, it checks drupalTranslations and its property...
View Articleupgrade prophecy to 1.20
Problem/MotivationLast part of dependency updates for PHP 8.4 compatibility #3427903: [META] Make Drupal 10/11 compatible with PHP 8.4Ref https://github.com/phpspec/prophecy/issues/624Proposed...
View ArticleConvert system_theme to OOP and handle install time call
Problem/MotivationAfter #3487971: Convert system_page_attachments to OOP system_theme will be the last procedural hook in core that supports OOP implementations for.This is complicated by install...
View ArticleClean up how ModuleInstaller invokes hooks around installing other modules.
Problem/MotivationModuleInstaller currently loops over every module and calls invoke for each hook, so this tries invoking hooks on modules that have not implemented them. This in turn calls...
View ArticleFix twig 3.15 deprecations
Problem/MotivationFollow-up to #3488365: Upgrade twig/twig to 3.15.0Steps to reproducehttps://github.com/twigphp/Twig/blob/v3.15.0/CHANGELOG * Deprecate instantiating `Node` directly. Use `EmptyNode`...
View ArticleRefactor Olivero details stylesheet
The current details stylesheet doesn't make use of PostCSS nesting, custom properties, etc. We can refactor this to make the code more portable, modular, and readable.
View ArticleDefault images for the Image field are not recording file usage properly
Problem/MotivationThere are 2 issues. First, the image module hooks are adding file usage with \Drupal::service('file.usage')->add($file, 'image', 'default_image', $field_storage->uuid()) But...
View ArticleModule provided templates can only render with Twig
Problem/MotivationIn \Drupal\Core\Theme\ThemeManager::render there is a condition that prevents module-originated templates from being processed with a different render_templateif...
View Article