preSave() and postSave() not working with ContentEntity translations
Problem/MotivationSqlContentEntityStorage::saveToSharedTables() always iterates over all translations of entity on save. In other words, storing an ContentEntity always stores all translations of it....
View ArticleDrupal 7 .htaccess rule to prevent backup file access is broken and needs...
Problem/Motivation.htccess is supposed to prevent executing php files like those in vendor # Deny access to any other PHP files that do not match the rules above. # Specifically, disallow...
View ArticleClik here to view.
Node revisions cannot be reverted per translation
Problem/MotivationWhen you have a node translated into two languages (p.e. English and German), both „versions" can be edited separately. But revisions are created/stored across all language versions...
View ArticleService changes should not result in fatal errors between patch or minor...
Problem/MotivationIn Drupal 8, if a required argument is added to a service that is commonly used, the new version of the class won't get the parameter passed in until the container is updated.This...
View ArticleCondition plugins should provide cache contexts AND cacheability metadata...
Problem/MotivationThis issue blocks critical #2495171: [PP-1] Block access results' cacheability metadata is not applied to the render arraysShort version: Because conditions do not indicate their...
View ArticleUpdate error: SimpleXMLElement::__construct(): Entity: line 6: parser error :...
Update get this error Warning: SimpleXMLElement::__construct(): Entity: line 6: parser error : Opening and ending tag mismatch: hr line 5 and body in update_parse_xml() (linia 386 din...
View ArticleBlockContent::delete() should be preDelete() and needs to clear plugin...
Problem/Motivationdelete() is not guaranteed to be called, since it's just a shortcut for passing the entity to the delete() method of the entity storage handler.The code needs to be moved into a...
View ArticleFieldItemInterface methods are only invoked for SQL storage and are...
Problem/MotivationThere are a few related problems with the FieldItemInterface::insert() and FieldItemInterface::update():They are invoked, together with FieldItemInterface::delete() and...
View ArticleUpdate Backbone to 1.2.1
Reference: https://www.drupal.org/core/beta-changesIssue categoryTask because we should update all third party assests/libraries upto date.Issue priorityNormalProblem/MotivationBackbone Current version...
View ArticleUpdate theme system maintainers
The responsibilities of a core maintainer have been updated (see #2457875: [policy] Evolving and documenting Drupal core's structure, responsibilities, and decision-making), and all...
View ArticleUnit tests should use a default timezone other that UTC
Problem/MotivationCurrently, tests/core/bootstrap.php sets the timezone to be UTC because (from core/tests/bootstrap.php):// Set the default timezone. While this doesn't cause any tests to fail, PHP//...
View ArticleUnused namespaces in EntityDeriver.php (and a comment typo).
EntityDeriver.php contains the following unused namespaces: Drupal\Core\Routing\RouteBuilderInterface Drupal\Core\Routing\RouteProviderInterface...
View ArticleProxies of module interfaces don't work
Problem/MotivationThe proxyBuilder components currently creates proxy classes which look like the following and writes them into the dumped container:<?phpclass Drupal_Core_ExampleClass implements...
View ArticleSeveral migrate_drupal migrations fatal error on count()
Problem/MotivationWith the drush migrate-status command in migrate_plus, several migrations defined by migrate_drupal fail when obtaining the source count:PHP Fatal error: Call to a member function...
View ArticleAdd "Add Content" submenu to navigation.
The "Add Content" menu is missing, which most users are probably used to. This patch adds it in.
View ArticleToolbar UI regression: shortcuts and menu not visible at same time
In the 7.x toolbar module, I had the menu items (top level only) and the shortcuts visible at the same time.In the current 8.x toolbar, I have to choose whether I want shortcuts or menu.To me this is a...
View ArticleConfirm form cancel button can lead to external domain
The confirm form cancel button is subject to hijacking via the destination query stringreported STR:1. Log in as an admin to your Drupal installation. 2. You need to have at least one custom block in...
View ArticleChanging password should invalidate all other sessions
Follow-up to #2508627: Changing email address should invalidate one-time login linksProblem/MotivationAssume I realize I left myself logged into a shared computer to my Drupal site account.I change my...
View Article"Translate user edited configuration" permission needs to be marked...
The "Translate user edited configuration" permission actually allows one to translate shipped configuration strings that are then returned by t() and assumed safe, leading to many XSS attacks by e.g....
View ArticleConfig translation needs to be validated on input for XSS (like other t...
Ingested t() strings are normally validated on input for XSS (as opposed to user input that's filtered on output)For example in D7:...
View Article