Merge LTR and RTL margins for indented comment
There is no need to specify a margin for LTR and then override it in RTL, we can just make it one simple rule.
View ArticleCode injection via preg_replace()
Path: machine_name/transliterate?replace_pattern=a@e%00&replace=a Сallback: MachineNameController::transliterateAll parameters that we pass to preg_replace come from the request so can be easily...
View ArticleRewrite views_ui_add_ajax_trigger() to not rely on /system/ajax.
Problem/Motivation#2263569: Bypass form caching by default for forms using #ajax. is moving forms away from relying on /system/ajax, since that requires that forms always be...
View ArticleClik here to view.
Bartik footer block menu-item misaligned in RTL
As shown in the image, there is a visual bug in the Bartik footer block in the RTL version.
View Article[Regression] The idea that there is an existing library of blocks was...
During usability testing, there wasn't a single participant who was able to successfully place an existing block. The right sidebar is dead to them. They're taught this both from the new add content...
View ArticleDependencySerializationTrait serializing ContentEntityBase causes a fatal error
Problem/MotivationDependencySerializationTrait serializing ContentEntityBase causes a fatal error, because...
View ArticleNotice: Undefined index: in file_ajax_upload() (line 258 of...
I received the following error whenever I was creating a custom audio field.Notice: Undefined index: in file_ajax_upload() (line 258 of modules/file/file.module).Here is the code that the error is...
View ArticleDatabaseSchema_mysql::createTableSql() can't set table collation
There's a typo in DatabaseSchema_mysql::createTableSql() which makes the 'collation' setting in schema definitions get silently ignored. The schema info variable is called $table, but it's referenced...
View ArticleLocale JS alter breaks on remote JS files
Problem/Motivation_locale_parse_js_file() throws an exception if an external file is passed in, but I can't see anywhere in the call path (locale_js_alter() -> locale_js_translate() where those are...
View ArticleUnhandled exception when trying to register a duplicate user
Steps to reproduceGo to user/register and register an account named 'example'.Go back to user/register and register an account named 'example'.Expected outcomeDrupal displays an error message, which...
View ArticleDrupalPrivateStreamWrapper getExternalUrl doesn't work if language...
Steps to reproduce: - Create a bundle of any entity type and add a file field with private wrapper. - Add an entity with a file in that field. - Go to view that entity. The file field has an url with...
View ArticleDrupalStandardsListener's error messages don't show up in test results
Problem/Motivation\Drupal\Tests\Standards\DrupalStandardsListener registers test failures for incorrect @covers annotations. However, the messages for these failures do not show up in the test results,...
View ArticleFollow-up for #2432837: Security problem with optimizing ['user',...
Problem/MotivationFollow-up for #2432837: Make cache contexts hierarchical (e.g. 'user' is more specific than 'user.roles'), because that issue introduced the concept of folding implied cache contexts...
View ArticlePass validation violation property paths on to widgets
Follow-up from #196972: How does hook_views_tabs() work?: Let's add the $sub_property_path of a validation violation to the errorElement() method of widgets, so they can be easily used when mapping...
View ArticlePolyfill date input type
Problem/MotivationImplement the strategy we have in #1252178: Add Modernizr to core for date inputs.Some browsers doesn't support the HTML 5 date input, so we need to add a JS fallback to support...
View ArticleClik here to view.
Send a helpful error message when no format found by the serializer
Problem/MotivationThe error or the lack of an UI error on a REST Export Display does not help to solve the problem.Steps to reproduceEnable HAL moduleAdd a Rest export display to /nodeSet serializer to...
View ArticleOn Available translation updates report "Missing translations for:"...
Problem/MotivationNo text is displayed after "Missing translations:" on the Available translation updates report page.Steps to reproduce1. Install drupal 8. Make sure automatic updates are switched...
View Articleclass Drupal\Core\Access\CsrfTokenGenerator should implement a TokenGenerator...
Currently the FormBuilder takes an instance of CsrfTokenGenerator, which means that form building is tightly coupled to a single implementation of CSRF. It would be better if the FormBuilder was...
View ArticleThe Hide summary/Show summary link should not be displayed for a disabled...
Problem/Motivationtext.js adds the Show summary/Hide summary links even if the text area is disabled. This does not make sense. Either the text element has a summary already - in which case it should...
View ArticleDate tokens do not handle all date types
system_token_info and system_tokens() only provide the 'short', 'medium' or 'long' type tokens, but do not use system_get_date_types() to define what tokens are available. Therefore any module-defined...
View Article