Change system_retrieve_file function to return error instead of generating...
https://api.drupal.org/api/drupal/core!modules!system!system.module/func...Currently the function system_retrieve_file generates a variety of Drupal error messages that cannot be suppressed or...
View Articledrupal_parse_url() fails to parse fragment from external url when query is...
drupal_parse_url() does not correctly parse External URLs and fails to get the path, query and fragment.Example code:<?php$url = 'http://drupal.org/?q=node/123456#comment-form';$uri1 =...
View ArticleAggregator feed overview misleading text
At admin/config/services/aggregator , the Next update is "Never" when it's not yet updated, but scheduled, which is misleading. Here's a patch with test.
View ArticleThe $name parameter for UrlGenerator::getRoute() is documented incorrectly
Problem/MotivationThe $name parameter for UrlGenerator::getRoute() is documented incorrectly. $name can be a string or an instance of SymfonyRoute.Proposed resolutionUpdate the UrlGenerator::getRoute()...
View ArticleRendered Cache Metadata created during the main controller request gets lost
Problem/MotivationThere are several things like token processing, CSRF links, and potentially other things, where metadata gets lost due to Drupal's usage of strings.If the user is within a 'rendering...
View ArticleReplace CacheablePluginInterface with CacheableDependencyInterface
Problem/MotivationBack in #2318377: Determine whether a view is cacheable and its required contexts, store this i/t config entity we introduced a CachePluginInterface so that views plugin can specify...
View Article[meta] Finalize the cache contexts API & DX/usage, enable a leap forward...
Problem/MotivationThe Big Picture of what we've already doneIn order for Drupal 8 sites to have great performance, we've done a huge amount of work. A big part of that is making Drupal 8 the first...
View ArticleComply with new documentation standards for @file for namespaced class files
Problem/MotivationFor PSR-0 class files (where a PHP file contains just a single class definition), it seems a bit redundant to have an @file documentation line that is pretty much the same as the...
View Article'administer actions' permission can be abused - needs to be flagged...
There are multiple ways the 'administer actions' permission could be abused to gain control of a site. Example STR:1. As user with 'administer actions' permission go to /admin/config/system/actions 2....
View ArticleRemove support for #ajax['url'] and $form_state->setCached() for...
Problem/MotivationCalling $form_state->setCached() during a form's initial build (the GET request) leads to several problems:Though named setCached(), what is actually persisted is state, and...
View ArticleFolder permissions
Problem/MotivationWe shouldn't allow open-access to the compiled php container. Previously we'd had strict permissions on the sites/default/files/php folder. Now it is getting 777 permissions.Proposed...
View Article[META] Support PHP 7
Problem/MotivationPHP 7 is likely to be released sometime this year and Drupal 8 is incompatible with PHP 7 in several significant ways. This is major because:PHP 7 will be released late this year,...
View ArticleAdding Assertions to Drupal - Test Tools.
Part of the Well Formed Errors InitiativeProblem/Motivation"Be polite, Never Assert Avoid the assert() mechanism, because it could turn a three-day debug fest into a ten minute one." -- How to Write...
View ArticleMigration dependency ordering should be in migrate, not migrate_drupal
Problem/MotivationWhen loading multiple migrations together, they should be returned in dependency order. For example, with the migrate_example submodule of migrate_plus, the node migration depends on...
View Articleincomplete instructions in INSTALL.txt
Instructions in INSTALL.txt do not describe need/method for granting permissions to sites/default/files (only to sites/default). This incompleteness might leave an inexperienced installer stranded.Beta...
View ArticleMigrate file_managed table to file entities
Problem/MotivationManaged Drupal 7 files need to be migrated to Drupal 8 file entities.Proposed ResolutionD7's unified file management API (and the fact that files are already entities!) makes this a...
View ArticleClik here to view.
Comments heading should not display when comments are closed and empty.
A "Comments" heading displays on published articles even though comments are disabled and empty. This does not occur in Drupal 7.Steps to replicate.Fresh D8.Create article.Set Comments to closed in...
View ArticleRemove duplicated getDataDefinition() method in EntityAdapter
EntityAdapter::getDataDefinition() is the exact same implementation as the parent TypedData::getDataDefinition(), so can be removed to avoid confusion.
View ArticleClik here to view.
XSS on field edit form via label field via ckeditor
STR as reported:1. Login to account 2. Visit following URL: /admin/structure/block/block-content/manage/basic/fields 3. Click Manage fields and then edit tab 4. Name label as...
View ArticleDatetime select list uses PHP non-OOP datetime functions
Problem/MotivationThe DateTime selectlist widget currently used the php non-oop versions of some of the date functions - such as date_format(). That expects a PHP base DateTime Object not the Drupal...
View Article