if theme() in drupal_render() returns an empty string, drupal_render() will...
The docs say that drupal_render() will pass a renderable array to theme() if #theme is set and in this case it is the responsibility of the theme function called to render children as...
View ArticleSetting #theme in a renderable array shouldn't change the way that #markup is...
I don't know what the original use-case/scenario behind this was but currently drupal_render() will not render #markup if #theme is set. // If #theme was not set, but the element has raw #markup,...
View ArticleReplace drupal_region_class() with direct calls to drupal_html_class()
drupal_region_class() was introduced by the overlay module patch. It's a tiny oneliner that doesn't really save any time, and just makes it more magical and confusing.AttachmentSizeStatusTest...
View ArticleMove getDisplaysList() out of View storage class to ViewListController
This method is currently living in our View storage class, it doesn't really belong there. The storage class doesn't need to care about plugin managers or anything like that. This is only used in Views...
View ArticleFix indefinite article in book_menu_subtree_data docblock
Change "An subtree of menu links in an array, in the order they should be rendered." to "A subtree of menu links in an array, in the order they should be rendered."
View ArticleImplement access controller for the menu and menu link entity
Problem/MotivationCurrently menu module registering services to check access for menu and menu link entities deletion This custom access should be moved to corresponding access controllersProposed...
View ArticleAdd child page link in book navigation does not insert parent into book outline
The book navigation provides an "Add child page" link, which passes the parent ID to the node/add/book form via a GET parameter.Currently this is broken: the parameter is passed correctly, but it looks...
View ArticleObjectify user_logout()
Lets move this somewhere..maybe the User entity controller? i am not really sure cause it has to do with session
View ArticleUnable to POST a node via REST with a date field
I have tried various permutations on setting a value for a date field but an invalid value seems to get saved and then reading when I follow the Location on the 201 response. I most recently...
View ArticleStop saying '@see template_preprocess()' in every twig file
We have added a new convention for .twig files which was not in phptemplate files which I believe is a bit too verbose. Our templates have two @see references in the Doxygen such as:* @see...
View ArticleEvaluate pros and cons of using specific device names vs. generic size names...
Spin-off from #1741498-132: Add a mobile preview bar to Drupal core. There, Dries requested that continued discussion about this topic be spun off into a new issue, so this is it.The latest patch in...
View ArticleDX: is it necessary to require Composer autoloader in module code when using...
There's something I've been thinking about from the point of view of developer experience, in a way that kind of relates to issues like #1920666: Allow additional external libraries with composer. I've...
View ArticleSimplify render for theme_status_report()
Following from #1938930: Convert system theme tables to table #type and #2010982-8: Replace theme() with drupal_render() in system module for system_status()Problem/MotivationCurrently...
View ArticleLink text followup issue
@larowlan posted a simplified patch for #1801268: Change link field 'title' field to 'link text' but this leaves a few unresolved issues that should be fixed. Variables should be renamed, renderable...
View ArticlePossible assignment/comparison error found in code
Was creating a multistage batch job, and trying to work out why it wouldn't report that one of the earlier stages had failed.In the includes/batch.inc file, line 206 is as follows while...
View ArticleHelper issue for #1953408 (Remove ArrayAccess BC layer)
Use this for the testing the full patch - once we're green, we'll split them up though, see #1953408: [META] Remove ArrayAccess BC layer from field config entities
View ArticleOngoing ajax submission prevents full form submission
Problem/MotivationWhen using AJAX within a form to perform updates when an element get changed (for example updating when a textfield is changed), Drupal.ajax disables the element and adds the...
View ArticleReplace theme() with drupal_render() in system module for...
follow up for #2009674: Replace theme() with drupal_render() in system moduleRelated issues#1987810: Convert system_admin_config_page() to a new style controller(Search for duplicate issues)
View ArticleSearch results page should be highly configurable
Search results page should be highly configurable like “Content types” - “Manage Display”, eliminating the need of changing templates: - remove author info - add content type - ...
View ArticleWhy am I getting the message "There was an error saving the menu link"?
First of all I know we need to update to the latest version. :) But in the meantime... I get the message "There was an error saving the menu link" whenever I try to save a note with a menu link. I...
View Article