Improve DX of doing a redirect
Problem/MotivationIn #1668866: Replace drupal_goto() with RedirectResponse we introduced the following pattern...-Â Â Â Â Â Â Â Â Â drupal_goto("node/$node->nid");+Â Â Â Â Â Â Â Â Â return new...
View ArticleInacurrate since drupal 7.20
Issue is on this page: https://api.drupal.org/api/drupal/modules!image!image.module/function/image_style_url/7This is no longuer true since drupal 7.20: Requesting the URL will cause the image to be...
View ArticleAllow validation constraints to add in message replacements
We need the possibility to specify custom message replacement values when defining the validation constraints. This is need to support constraint messages as field API uses in the form of "%name: Some...
View ArticleMerge FieldItem::insert() and FieldItem::update() on fields into preSave()
FieldItem::insert() and FieldItem::update() are left-overs of the previous field.module API, but do not make much sense in the entity context as insert/update are not post-storage operation as they are...
View ArticleMake bootstrap three steps
There's still multiple bootstrap phases, most of them are very thin now, and they provide no advantage compared to previous releases where you might want to do a partial bootstrap in a utility script...
View ArticleAdd 'Right' and 'Below' position options to Field Label display
In D7 and D8, the display options for the label of a field are currently only Above, Inline, and〈hidden〉. In other words, the only choices for a displayed label position are 'above' and 'left'. This...
View ArticleConvert entity field types to the field_type plugin
#1969728: Implement Field API "field types" as TypedData Plugins defines a new field_type plugin, once it's in we can convert entity field types over to make use of it. However for that, we need to...
View ArticleSupport preprocessing in EntityRenderController
Right now, with have field_attach_preprocess() which needs to be moved to the entity system. Also, I guess it makes sense to have preprocessing logic that is tight the buildContent() of the render...
View ArticleConsider moving event registration from services.yml to events.yml
To register event subscribers currently, you have to add a service with the "event_subscriber" tag.Considering that we don't use tagged services for discovery consistently in core, this is exposing an...
View ArticleRemove our CKEditor ACF work-around once ACF supports blacklisting
#1936392: Configure CKEditor's "Advanced Content Filter" (ACF) to match Drupal's text filters settings ensured that ACF was optimally configured: so that it perfectly matches the restrictions by...
View ArticleReturn render arrays from RowPluginBase::render overrides
This was observed in changes for #2008980: Replace theme() with drupal_render() in comment module. One of the suggestions was to use parent::render() from \Drupal\comment\Plugin\views\row\Rss, which is...
View ArticleClik here to view.
Improve the layout and usability of the admin/people exposed filters and actions
Updated: Comment #0Problem/MotivationThe form at the top of admin/people is currently a bit chaotic and confusing:The local action to add a user is not clearly delineated from the rest of the form, and...
View Articlemenu: hook_entity_operation_alter() does not work with EntityListController
Updated: Comment #0MenusProblem/Motivationfunction hook_entity_operation_alter(array &$operations, \Drupal\Core\Entity\EntityInterface $entity) {} was added in#2004408-34: Allow modules to alter...
View Articleviews: hook_entity_operation_alter() does not work with EntityListController
Updated: Comment #0ViewsProblem/Motivationfunction hook_entity_operation_alter(array &$operations, \Drupal\Core\Entity\EntityInterface $entity) {} was added in#2004408-34: Allow modules to alter...
View ArticleREGRESSION: hook_local_actions doesn't use title callback
follow-up to #1908756: Separate Action Links (MENU_LOCAL_ACTION) from hook_menu()In Drupal 7 if a title callback was specified for a local action is would be used in rendering it in...
View ArticleUpdate drupal_get_query_array function to handle array in query parameters
Currently there is no support to handle array in the query parameters.Example String like 'foo[]=1&foo[]=2&foo[]=3' will just give an <?phparray('foo'=> 3)?>So the attached patch adds...
View ArticleRemove the ability to install/uninstall a module without it's...
Parent issue#2024083: [META] Clean up and simplify ModuleHandler to improve DX and maintainabilityProblem/MotivationCurrently it is possible to install a module without installing a dependency....
View ArticleConsider adding ModuleInterface, ThemeInterface, ExtensionInterface and...
Parent issue#2024083: [META] Clean up and simplify ModuleHandler to improve DX and maintainabilityProblem/MotivationThe DX of ModuleHandler or any other place that reads or works with...
View ArticleChange ModuleHandlerInterface::install()/uninstall() method signature to...
Parent issue#2024083: [META] Clean up and simplify ModuleHandler to improve DX and maintainabilityProblem/MotivationRefactor ModuleHandler::install()/uninstall() method signature to expect single...
View Article[META] Clean up and simplify ModuleHandler to improve DX and maintainability
Problem/MotivationAs nice as ModuleHandler is compared to what we used to have (nothing) it is still DX hell. The method signatures are needlessly complex, some methods are well over 200 or 300 LoC...
View Article