[policy, no patch] Default to PHP 7 for Drupal core patch testing
Problem/MotivationPHP 7 complete's test runs 1/3rd faster than PHP 5.6. This saves overall resources for the testing infrastructure, as well as giving quicker feedback to patch...
View ArticleBaseFieldOverride entities created by content_translation break...
Problem/MotivationContent editors are unable to re-save existing, translatable draft content as draft again. After hitting "Save and Create New Draft", an EntityStorageException is...
View ArticleProvide the 'revision_translation_affected' base field by default...
Problem/MotivationA recent critical issue (#2766957: Forward revisions + translation UI can result in forked draft revisions) brought up the fact the the 'revision_translation_affected' field is...
View ArticleRuntime debug statement in Views now prints out object
Problem/Motivation\Drupal\views\ViewExecutable::setDisplay() includes a helpful debug() statement if you try to set an invalid display. However, this can be shown to end-users if a site is...
View ArticleFatal error when saving a node type without content moderation
I have installed the Content Moderation module and I have applied the default workflow to one node type. If I create a new node (without moderation), I got the following error when trying to save...
View ArticleImprove usability of disabled checkboxes on module listing page
Modules on the listing page can have their checkboxes disabled and there is no messaging to the end user as to why this is occurring.My recommendation would be to offer help text as a caption and/or...
View ArticleConvert web tests of block
See #2735005: Convert all Simpletest web tests to BrowserTestBase (or UnitTestBase/KernelTestBase)These tests depend on assertBlock(Not)Appears which lives on WebTestBase but has no equivalent on...
View ArticleBook allows emptying node titles in admin/content/book/* (Notice: Trying to...
After emptying a node title in admin/content/book/* your site gives errrors of course and the title can only be fixed in this same book form, not through the node editing form... Why on earth are these...
View ArticleHeadersCacheContext needs test coverage
Problem/MotivationThere's no test coverage for this cache contextProposed resolutionAdd a test like \Drupal\Tests\Core\Cache\Context\QueryArgsCacheContextTest but for HeadersCacheContext. That test was...
View ArticleDealing with unexpected file deletion due to incorrect file usage
Problem/MotivationRecently @catch, @webchick, @xjm, @cottser, @cilefen and I discussed #2801777: Give users the option to prevent drupal from automatically marking unused files as temporary , #2810355:...
View ArticleClarify the notion of "computed field"
Spin-off from #2164601: Stop auto-creating FieldItems on mere reading of $entity->field[N]ProblemThe notion of "computed property" is pretty clear - typically, $field->field_ref->entity. This...
View Articlemime_header_encode() doesn't correctly follow the RFC 2047
Suggested commit message (feel free to change / doublecheck contributors, I scanned manually):#84883 by earnie, ximo, netbjarne, scor, greggles, pillarsdotnet, DuaelFr, roderik: make...
View ArticleHow to list subsequently referenced entities?
Hi,There is something I could not get my head wrapped around: How to list subsequently referenced entities?I have a number of entities (A,B,C,D - all of the same type) referencing their respective...
View ArticleRedirection from HTTPS to HTTP. Doesn't have option for base url.
Hi,When Drupal8 site is SSL enabled we normally enable HTTPS redirects in .htaccess. So all the HTTP requests are redirected to HTTPS.In our case we have a load balancer in which this wont have a HTTP...
View ArticleCoding standards: use colons in case statements
To my surprise, while copying AccessDeniedSubscriber, I discovered some semicolons being used.I didn't even know that was possible. PHP documentation says it's allowed. Drupal coding standards don't...
View ArticleAdd .woff and .woff2 to .gitattributes
Problem/MotivationThe .gitattribues files specifies certain extensions as binary (like *.jpg ) to provider easier diffs.However, the web font formats .woff and .woff2 are missing. So for webfonts you...
View ArticleInconsistent behaviour: Entity can not be referenced
When I create content as advanced user, less advanced uses, advanced enough to edit the content, can't edit my content.Content structure: - Node type reseller with user reference field_contact -...
View ArticleFieldDefinitionInterfacegetDefaultValue() requires an entity
Problem/MotivationFieldDefinitionInterfacegetDefaultValue() requires an entity. This means if we don't have an entity we can't know the default value of a field. This is problematic for #2283977:...
View ArticlePrevent accessing null elements when operating on ajax instances using the...
Follow-up to #2844261: Allow dialog links to specify a renderer in addition to a dialog typeProblem/MotivationSometimes the Drupal.ajax.instances array contains items that are null.It seems that when...
View ArticleReplace the static map in the d7_field migration by field plugins
Problem/MotivationIn #2842222: D7 Plain text fields incorrectly migrated to D8 as Text (formatted), we need to replace the static map in the d7_field migration by a process plugin that will instantiate...
View Article