Media library should not use js- prefixed CSS classes for styling
Problem/MotivationIn reviewing #3037668-17: Improve visual coherence of the media library, @lauriii had this to say:We shouldn't use js- prefixed classes for styling. Since this is just adding RTL...
View ArticleJS error when creating group conditions
If we create more groups with different conditions, the condition label apper next to field is incorrect. Please check attached screenshot.Attached the patch file.Steps to reproduce: 1. Install view...
View ArticleDetermine how to mark themes as experimental
Problem/MotivationIf we want to do #3079738: Add Claro administration theme to core, then we need to figure out how to actually add a theme to core as experimental. (This will be the first time we've...
View ArticleRoadmap to stabilize Claro
Problem/MotivationClaro is aimed to be an experimental admin theme in Drupal 8.8.0 which according to Drupal development roadmap is aimed to be released on December 4, 2019. Drupal 8.8.0 feature freeze...
View ArticleOffering to Support & Maintain Drupal core user.module (8.7.x/8.8.x/9.x)...
I wanted to offer my support in helping develop, co-maintain and manage stable releases of this module for Drupal 8/9. It would be useful to clear through the issues and make the necessary improvements...
View ArticleDeprecate Seven theme
Problem/MotivationWe are working on a new admin theme here: #3066007: Roadmap to stabilize Claro. After the new admin theme has been made default experience on new installations, we should start the...
View ArticleFix return typehinting for user_load functions
Static analysis tools like PHPStan blow up on incorrect typing, especially when bool is typed, but TRUE is never returned.Some quick fixes / quick wins.
View ArticleDetermine how to deprecate themes
Problem/MotivationWe have opened multiple issues planning to deprecate themes:#2659890: [Plan] Drupal 9 markup and CSS backwards compatibility Will likely introduce a new Stable for Drupal 9 meaning...
View Article[meta] Update documentation screenshots to use Claro instead of Seven
Problem/MotivationBlocked on Claro becoming Stable. Progress can be followed on #3066007: Roadmap to stabilize Claro.Documentation is using screenshots of Seven. As we are planning to gradually move...
View ArticleMissing summary/param/return docs for several QueryInterface methods
Problem/MotivationAPI page: https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Entity%21...The docblock is incomplete: missing description, missing param and return.There are several other...
View Article[regression] Nightwatch log messages not getting written
Problem/MotivationIt seems like #3059356: [Security] Update yarn packages to fix 19 vulnerabilities by updating nightwatch broke the functionality to write logs to the file system after test...
View ArticleDocument the Media Library module
Problem/MotivationWe need to write documentation for the Media Library module.Proposed resolutionWhen #2962110: Add the Media Library module to Drupal core is closed we should write a new documentation...
View ArticleFileMedia: Local videos has no thumbnail on iOS
The FileVideoFormatter in core does not provide any thumbnail by default with local video uploads.Luckily (?), most browsers like Chrome are smart enough to supply the first frame of the video as the...
View Article[policy, no patch] Update Drupal's browser support policy
Problem/Motivationhttps://www.drupal.org/docs/8/system-requirements/browser-requirements lists some extremely outdated browsers, such as Firefox 5 and Safari 5. It's unlikely that any core developers...
View ArticleUpdate browserslist browsers
Problem/MotivationDrupal 8.8.0 has a new browser support policy #2390621: [policy, no patch] Update Drupal's browser support policy. According to the policy, Drupal can start using any given browser...
View ArticleConsider abstracting some parts out of JavaScript / CSS build tools
Problem/Motivation#3060153: Proposal to use PostCSS for Claro in core added build tools for CSS that are similar to JavaScript. We might be able to abstract some of the tooling out of these tools to...
View ArticleDecouple run-tests.sh from the simpletest module
Problem/MotivationIn #3057420: [meta] How to deprecate Simpletest with minimal disruption we are contemplating making simpletest a contrib module.That issue has many steps involved in decoupling...
View ArticleDocument development dependencies
Problem/MotivationDrupal has documentation on maintainership, security policies and release and support cycles of its dependencies. However, development dependencies are largely missing on that...
View ArticleIncludeResolver assumes entity reference fields will always have a value
Problem/MotivationUsing core 8.7.6, if you make a JSON:API resource request which has an include and an entity does not have that included entity reference field populated, the following...
View Articleroute node.add should be defined through _entity_form instead through...
Problem/MotivationFrom entity.api.php:- defaults: For entity form routes, use _entity_form rather than the generic _controller or _form. Unfortunately we do not follow this directive and have some...
View Article