Fix 'Drupal.Semantics.FunctionT.NotLiteralString' coding standard
Part of #2571965: [meta] Fix coding standards in core.ApproachWe are testing coding standards with PHP CodeSniffer, using the Drupal coding standards from the Coder module. Both of these packages are...
View ArticleFix 'Drupal.Semantics.FunctionT.ConcatString' coding standard
Part of #2571965: [meta] Fix coding standards in core.ApproachWe are testing coding standards with PHP CodeSniffer, using the Drupal coding standards from the Coder module. Both of these packages are...
View ArticleFix 'Generic.CodeAnalysis.UselessOverridingMethodp' coding standard
Part of #2571965: [meta] Fix coding standards in core.ApproachWe are testing coding standards with PHP CodeSniffer, using the Drupal coding standards from the Coder module. Both of these packages are...
View ArticleFix 'PSR2.Classes.PropertyDeclaration.Underscore' coding standard
Part of #2571965: [meta] Fix coding standards in core.ApproachWe are testing coding standards with PHP CodeSniffer, using the Drupal coding standards from the Coder module. Both of these packages are...
View Article"Site UUID in source storage does not match the target storage."...
When importing a config where system.site UUID is empty, the following error is thrown:Site UUID in source storage does not match the target storage.If the system.site UUID is deliberately empty in the...
View ArticleAdd sorting configuration to composer.json
Problem/MotivationWhen adding packages doesn't sort them in composer.json.Proposed resolutionAdd sort-packages:true in root composer.json and core/composer.jsonRemaining tasksAdd a patch.User interface...
View ArticleForm Field Date
On line 65 of core\lib\Drupal\Core\Render\Element\Date.phpI found same issue in function processDate and exactly on line :if ($element['#attributes']['type'] == 'date'&&...
View ArticleExcept for websites created by Drupal, no websites use "zh-hans"...
Except for websites created by Drupal, no websites use "zh-hans" and "zh-hant" language codes.public static function getStandardLanguageList() { 'ur' => ['Urdu', /* Left-to-right marker "" */...
View ArticleRegister form: roles are not set by using the account object
Here is the code which create the roles checkboxes in AccountForm Class $form['account']['roles'] = [ '#type' => 'checkboxes', '#title' => $this->t('Roles'), '#default_value' => (!$register...
View ArticleError: Call to a member function getItemDefinition() on null in...
Hello, After upgrade from drupal 8.6.16 to 8.8.1, I have discovred the below error: Error: Call to a member function getItemDefinition() on null in media_requirements()
View ArticleReplace assert(Not)Same/Identical() on booleans with assert(Not)True/False()...
Problem/Motivation$this->assertSame(FALSE, ... and $this->assertSame(TRUE, ... is no longer necessary and can be replace with assertTrue/False().Also $this->assertSame(..., FALSE/TRUE).See...
View ArticleRollback of complete node migration fails
Problem/MotivationWim Leers reported in #2746541: Migrate D6 and D7 node revision translations to D8, Comment #451 that the rollback of the complete node migration fails.Proposed resolutionRemaining...
View ArticleProperly deprecate AssertLegacyTrait::assert
Problem/MotivationAssertLegacyTrait::assert is meant for removal in Drupal 10.Proposed resolutionDeprecate the method and remove its usage in core.Remaining tasksUser interface changesAPI changesData...
View ArticleProperly deprecate AssertLegacyTrait::pass
Problem/MotivationAssertLegacyTrait::pass is meant for removal in Drupal 10.Proposed resolutionDeprecate the method and remove its usage in core.Remaining tasksUser interface changesAPI changesData...
View ArticleClik here to view.
Quick Edit toolbar does not float up above content on first invocation, it...
Problem/MotivationWhen you first invoke the Rich text edit toolbar for the body field, the expanded toolbar will cover the text in the body field. It behaves like this in the last versions of Chrome,...
View Article[meta] Fix coding standards in core 7.x
This meta issue to tackle an issue in D7 core: coding standard. My goal here is to have a Drupal 7 that passes Drupal coder.It's a huge task but we need to get over it. It's important to provide a good...
View ArticleRemove Drupal::CORE_COMPATIBILITY because it is not accurate when modules can...
Problem/MotivationDrupal::CORE_COMPATIBILITY is used in many places throughout to filter on core compatibility. Historically this has all corresponded to project branch and version names with the 8.x-...
View ArticleAdd "url to media thumbnail" formatter for media reference fields
For image field, we get two formatters:image: renders image in <img>Url to image: provides the URL. Use case: To render an image as background image through inline styling in template.But in case...
View Article
