Update stylelint to 13.0.0
Problem/MotivationStylelint 13.0.0 requires at least Node.js 10.13.0. Since Drupal core still supports Node.js versions till 8.11.0, we had to refrain from updating stylelint as part of #3101543:...
View ArticleAllow hook_update_last_removed() to provide version information
Problem/MotivationBased on discussions in #3066801: Add hook_removed_post_updates() and #3098475: Add more strict checking of hook_update_last_removed() and better...
View ArticleClik here to view.
Improve multiple removed version message for removed post updates
Problem/MotivationFollow-up from #3066801: Add hook_removed_post_updates().When multiple versions are shown for one module, the message we show is confusing.Proposed resolutionFigure out the lowest...
View ArticleJSON:API with custom entity with separate unique keys
When saving a custom entity which has a unique key a duplicate entry exception is thrown and the json api request crashes.To reproduce this- Create Custom Entity - Create a custom storage_schema there...
View Article[meta] Ensure compatibility of Drupal with PHP 8 (as it evolves)
Postponed on #3086374: Make Drupal 8 & 9 compatible with PHP 7.4.Problem/MotivationMake sure Drupal keeps being compatible with PHP 8. Work with dependencies as needed. See #3086374: Make Drupal 8...
View ArticleError: Call to a member function access() on null in...
Step to reproduce:Kindly see the attachment for this.
View ArticleRemove unused variables from core
Unused variable $user in RegisterForm.php Unused variable $key. ProfileFieldOptionTranslation.php
View ArticleRemove hard-coded Drupal 8 dates from update logic for the status report
Problem/MotivationThis is a follow-up to #2991207: Drupal core should inform the user of the security coverage for the site's installed minor version including final 8.x LTS releases. In that issue, we...
View ArticleRemove phpunit/phpunit-mock-objects it is a dangling dependency
Problem/MotivationBecause of the way we commit composer.lock it's possible to dependencies to become unneeded but still in the lock file. At the moment one such library is...
View ArticleComments make a reference to filter_process_format(), a not existing function
In TextfieldWidget::errorElement() there is the following comment. // Ignore validation errors for formats if formats may not be changed, // i.e. when existing formats become invalid. See...
View ArticleIf an update hook modifies configuration, then old configuration is imported,...
A typical workflow is that developers, on a local version of a site, will update the code, then run:... drush updb drush cim ... The important thing here is that drush updb is often run before drush...
View ArticleFind a proper way to manage including/excluding database-driver-specifc tests
Problem/MotivationLastly discussed from #3098426-10: EntityQueryTest::testToString fails with non-core db drivers onwards, but really popped up several times already, + if...
View ArticleDocumentation for ModuleHandler::invokeAll() says the method uses a PHP...
The description for the return value of ModuleHandler::invokeAll() contains the following warning. Note: integer keys in arrays will be lost, as the merge is done using array_merge_recursive(). The...
View Article[PP-1] Remove remaining deprecated code from taxonomy.module
We removed all the BC layers in #3096976: Remove taxonomy.module BC layers but we missed two methods that weren't tagged correctly: /** * Removed reference to terms from term_hierarchy. * * @param...
View ArticleProperly deprecate TermStorage::deleteTermHierarchy() and...
Problem/MotivationIn #2543726: Make $term->parent behave like any other entity reference field, to fix REST and Migrate support and de-customize its Views integration,...
View ArticleMake more explicit the email address is necessary to recover the password
AccountForm::form() (an similarly RegisterForm::form()) uses the following sentence to describe the email field. The email address is not made public and will only be used if you wish to receive a new...
View ArticleClik here to view.
Incorrect "Drupal already installed" if any database settings are...
After https://www.drupal.org/project/drupal/issues/3120124 went in making MariaDB 10.3 the minimum version, an install reports "Drupal already installed" if MariaDB version is 10.2 and settings.php is...
View ArticleUpdate easyrdf library or change \Drupal\Tests\rdf\Traits\RdfParsingTrait to...
Problem/Motivation#3086374: Make Drupal 8 & 9 compatible with PHP 7.4 introduces a workaround for easyrdf PHP 7.4 compatibility. We should remove that workaround.Proposed resolutionEither: Update...
View ArticleRdfMapping unnecessarily adds a dependency on the module providing the target...
Problem/MotivationIn \Drupal\rdf\Entity\RdfMapping::calculateDependencies() it does: // Create dependency on the bundle. $entity_type =...
View Article