Media::getSource() should check that $this->bundle->entity is not NULL
Problem/MotivationIt is easy to create a Media entity with a non-existent type (see below). I came across this when defining a migration, when I used the incorrect bundle name.In this case,...
View ArticleRouteProvider::getRouteCollectionForRequest() can poison query string of next...
Problem/MotivationRequests have their query parameters overridden by RouteProvider::getRouteCollectionForRequest() (here) when a route collection is matched in the cache. This is problematic if the...
View ArticleRemove references to WebTestBase
Problem/MotivationWebTestBase no longer exists in Drupal 9, but we still have several references in code comments. We should update those to point to the appropriate base class...
View ArticleReplace deprecated WebTestBase in AjaxTestBase
Problem/MotivationAjaxTestBase.php still extends the removed WebTestBase from simpletest, which was removed from core in Drupal 9.Proposed resolutionExtend BrowserTestBase instead of...
View ArticleUncomment code in EntityReferenceAutoCreateTest
Problem/MotivationWe have commented out code in EntityReferenceAutoCreateTest. Let's fix that.Proposed resolutionMake it easier to test error states by adding a header to a request to ensure that the...
View ArticleMySQL on PHP 8 now errors when committing or rolling back when there is no...
Problem/MotivationThis @todo exists in Drupal\KernelTests\Core\Database\TransactionTest::testTransactionWithDdlStatement() try { $transaction->rollback(); unset($transaction); // @TODO: an exception...
View Article[meta] Ensure compatibility of Drupal 9 with PHP 8.0 (as it evolves)
Problem/MotivationMake sure Drupal keeps being compatible with PHP 8. Work with dependencies as needed. See #3086374: Make Drupal 8 & 9 compatible with PHP 7.4 for how we did it with PHP 7.4. PHP...
View Article[Backport to 8.9.x] Make every $modules property protected on classes...
Problem/MotivationSince the parent issue has been committed to D9+, maintaining a project compatible with 8.9 and 9+ has become problematic. D9 now reports a lot of deprecations, but those cannot be...
View ArticleDouble // in file paths
Problem/MotivationThis is a follow up to #2925899: MigrateUpgradeImportBatch does not use source_private_file_path & source_base_path correctly, making it impossible to have public & private...
View Article[META] Various updates when PHP 8.0 will become required
Problem/MotivationThis issue to collect all todos and updates discovered while making core compatible with PHP 8.0 in #3109885: [meta] Ensure compatibility of Drupal 9 with PHP 8.0 (as it evolves)Add...
View Article[meeting] Migrate Meeting 2020-10-29
Hello all, it’s time for the weekly migration initiative meeting. The meeting will take place in slack in various threads This meeting:➤ Is for core migrate maintainers and developers and anybody else...
View ArticleReplace use of whitelist/blacklist in CkEditor and Editor modules
Problem/MotivationLets remove usage of "blacklist" and "whitelist" in CkEditor and Editor modulesThey are:An historic bad labelling of peopleProvide no context: "what is listed in them"?Proposed...
View ArticleFix Claro details caret
Problem/MotivationThe Details caret is misaligned after changes were made for the Extend page. We still need the effects from the Extend page commit on the interior details elements, but we need the...
View ArticleUser logout is vulnerable to CSRF
One of the users on my site posted the following code yesterday: <img src="/logout">. This causes every user to log out when visiting the page that code is on. He suggested making a special page...
View ArticleSelect's #empty_option gets removed on ajax callback
Problem/MotivationFrom #44 we learned that select element adds #empty_option in Select::processSelect. However, if a select element is updated (re-rendered?) on an ajax callback, the #empty_option gets...
View ArticleDatetime-related test failures on PostgreSQL 12
Problem/MotivationThe new PostgreSQL 12 DrupalCI environment has numerous failures that do not happen on any of the Postgres 9 or 10 environments: https://www.drupal.org/pift-ci-job/1605867They all...
View ArticleReplace error and exception handlers with implementation from Symfony...
This would give us a nice looking error page with more readable stack trace. See attached screenshots.The symfony/debug component is already included in Drupal code base as it is a dependency of...
View Article[PP-1] Use comment access handler instead of hardcoding permissions
Problem/MotivationThe comment module comes with a CommentAccessControlHandler which is not really used on crucial places. Instead of using this handler, there are dozens of places, where the...
View Articlefield_read_fields() omits indexes from hook_field_schema
I have a custom module that calls field_update_field(), but that function fails with exceptions like "DatabaseSchemaObjectExistsException: Cannot add index field_sunflower_geo_lat to table...
View Article