Drupal Core 7.79 Broke Password Reset
Problem/MotivationJust updated from 7.78 to 7.80 and all new user email password resets including "reset my password" are broken -- the system claims the link has already been used even though the...
View ArticleBroken "Allowed Tags" updating: after all values for an attribute...
Problem/MotivationBasically, if you're using CKEditor with styles dropdown and "limit allowed HTML tags", automatic "allowed tags" updating can really trip you up.Steps to reproduce:Add a new text...
View ArticleUpdate manager tests have a bizarre mix of D7 and D8 versions
#1089320: Update version strings and constants to 8.x tried to convert all version strings in core to D8, but it was clearly a massive grep/replace. The results in update.test and tests/* are pretty...
View ArticleDocument updates-7.x-extra defgroup pattern
If this is documented somewhere I don't know where it is. Everyone forgets it including me.Should explain why we have the defgroup at all, and code example. I'm guessing this code go in the docs for...
View Article[Meta] Bug Smash Initiative triage fortnight commencing 2021-04-14
Meta for triage credit, please comment and link to issues you triaged and closed.
View ArticleClik here to view.
libraries-override failed: ckeditor/drupal.ckeditor.plugins.drupalimagecaption
Problem/MotivationMy understanding of "libraries-override" that will override and only load the final target:https://git.drupalcode.org/project/drupal/-/blob/9.2.x/core/themes/stabl...But we could see...
View ArticleEditing menus user-experience has regressed
Problem/MotivationIn Drupal 8.5 menu editing has regressed because if you add a menu link from this form you are redirected back to the menu list form. It is very jarring. This is a regression from the...
View ArticleClik here to view.
Clarify in the dblog_help that the dblog module should not be used for...
Problem/MotivationBased on #1635646: Admin users should know site report permission allows for more than viewing it is clear that the dblog module cannot be used as a forensic log. Here is a screen...
View ArticleThe service "search.index" should be backend_overridable
Problem/MotivationThe service "search.index" uses database queries and should therefore be backend_overridable. This is blocking the database driver for MongoDB.Proposed resolutionMake the service...
View ArticleFix mismatched sprintf calls
Problem/MotivationDiscovered when starting to get PHPStan running against Drupal core in #3178534: Start running PHPStan on Drupal core (level 0 - part 1), the following errors were reported relating...
View ArticleCore themes are not added to the test autoloader
Problem/Motivationdrupal_phpunit_contrib_extension_directory_roots does not add core/themes but it should because claro uses classes for safe callbacks.Steps to reproduceTry to autoload a class from...
View ArticleMissing View not helpfully reported in preRenderViewElement()
What are the steps required to reproduce the bug? See /core/modules/views/src/Element/View.php It can be reproduced by opening a page with a View (in a block), deleting the View, or (easier) by adding...
View ArticleClik here to view.
HTML5 validation with table sticky header is misaligned over the toolbar
Trying to address the fragment issue of points 4 and 6 from #1440628: [Meta] javascript toolbar/tableheader with url fragment mess.4) tableheader + fragment: the browser will scroll so that the element...
View ArticleAllow drupal_match_path() to also match aliases
It seems like drupal_match_path() would be more useful if it also matched path aliases of the given path.Seeing as the path and the alias both match the same page I would think in most, if not all,...
View ArticleConvert UpdateDescriptionTest to a Unit test.
Problem/MotivationFollowup to #1624278: cleanup of docblock to UI text in update_get_update_list() is weak. Convert \Drupal\Tests\system\Functional\UpdateSystem\UpdateDescriptionTest to a Unit...
View Articlecleanup of docblock to UI text in update_get_update_list() is weak
Problem/Motivation // The description for an update comes from its Doxygen. $func = new ReflectionFunction($module . '_update_' . $update); $description = str_replace(array("\n", '*', '/'), '',...
View ArticleAdd new hook DATABASEMODULE_views_data_DATABASEDRIVER_alter to the views module
Problem/MotivationThe database driver for MongoDB needs to change the views data after all calls to the hook_views_data_alter() have run. MongoDB stores all entity data for an entity instance in a...
View ArticleDeprecate Drupal\Core\Database\StatementEmpty
Problem/MotivationDeprecate Drupal\Core\Database\StatementEmpty as it only is used in testing and therefore does not belong in the main namespace.Proposed resolutionDeprecate...
View ArticleClik here to view.
Add an implementation of EntityDisplayBase::label()
Problem/MotivationNeither EntityFormDisplay nor EntityViewDisplay have a label key, and as such their ::label() method returns NULL.Proposed resolutionImplement ::label(), returning a string indicating...
View ArticleUse absolute URLs for Terms in link relations Google doesn't support...
Problem/MotivationFollowing up https://www.drupal.org/project/drupal/issues/3003713, but in this case is for Taxonomy Terms.Steps to reproduceVisit a term page and see the canonical link is like...
View Article