Clik here to view.
Administrative comment
Its a little unclear that the comment is for administrative purposes. BeforeAfterI think that we should add ellipses to the summary in the other category, right now it just wraps after a number of...
View ArticleClik here to view.
Cleanup exposed form settings
Removing a bunch of duplication.AttachmentSizeStatusTest resultOperationsexposed.form_.options.cleanup.patch2.36 KBIdlePASSED: [[SimpleTest]]: [MySQL] 54,311 pass(es).View details |...
View ArticleMake FileFieldTestBase::createFileField to return Field entity
This should simplify tests and minimize calls to field_info_fields() This helps to minimize patch in #1953410: Remove field_create_*(), field_update_*() and field_delete_*() in favor of just using the...
View ArticleClik here to view.
Simplify administrative title and description
I am not sure why we need these descriptions, the word Administrative should signal that its within the admin UI. AttachmentSizeStatusTest resultOperationsadmin-name-description-before.png166.48...
View ArticleClik here to view.
Handler administrative label
The label for this area that will be displayed only administratively. It's a little silly, because you could just say the word Administrative in the label of the field and it would indicate this...
View ArticleClik here to view.
Simplify pager options help descriptions
Lets simplify this text a little, I think the word "skip" is much more accessible than offset so I made it part of the label.BeforeAfterAttachmentSizeStatusTest...
View ArticlePlease remove all please(s) from the views UI
In accordance with our UI text standards, and http://drupal.org/node/679890. We should avoid using the word please, I removed this from the views UI. The guideline that we are implementing here is;Do...
View ArticleField instance isNew() method is broken
ConfigEntityBase isNew() method checks that id() returns '' or NULL<?php final public function isNew() { // Configuration entity IDs are strings, and '0' is a valid ID. return...
View ArticleRead more link isn't rendered
As reported by xjm, the readmore link is not rendered anymore.
View ArticleMove fields and instances to standard profile config
Now fields and instances are config entities #1735118: Change notice: Convert Field API to CMILet's move them to config as #1943468: Move Tags vocabulary to standard profile config
View ArticleViews blocks are missing contextual links
Views contextual links break a lot. Each time we've added tests. This is no exception.This fix is borrowed from #1927608: Remove the tight coupling between Block Plugins and Block Entities, as is the...
View Articlelocale_languages_delete_form_submit() doesn't flush nodes from the entity...
locale_languages_delete_form_submit() updates nodes in the database directly without also flushing the affected objects from the load cache.
View ArticleFigure out file layouts
sites/default/files contains compiled PHP stuff, config and file uploads. We didn't want to burden people with creating more than one webserver writeable directory. My plan was that once #1856766:...
View ArticleAdd back menu masks or rip out the routing system
The following holds of the D7-D8 menu routing system change compared to the D5-D6 one:There wasn't and still there is no documentation on it. The D6 system had detailed documentationbefore it went in....
View ArticleLimit validation errors for the entity form delete button
Drupal\Core\Entity\EntityFormController::actions() creates a delete button for entity forms, but clicking does not prevent form validation from being executed. This causes both HTML5 and server-side...
View ArticleEntities should define URI templates and standard links
Problem/MotivationCurrently, there is no central definition of the path to an entity. Sure there's its route/menu item, but we can't reverse associate from that.Sure entities now have a uri() method,...
View ArticlePatch testing issue
THIS ISSUE IS NOT FOR REVIEW. This is a place holder to test patches that are passing in local and not in d.o. It will avoid failing patch in main issue.
View ArticleSearchExcerptTestCase should be a WEBtestcase
SearchExcerptTestCase cannot be a UnitTest because it tries to invoke preprocess handlers (via search_simplify_excerpt_match) that need a hit to the db on module_list.Attached patch converts...
View Articledb_set_active vs target
This was working OK in 7.21:<?php $result = db_query('SELECT l.idLanguage, l.LanguageCode2 FROM {language} l', array(), array('target'=> 'myotherdatabase'));?> Now it direct db calls to my...
View ArticleRole filter creates notice when filtering for non existing role
I had a filter set on the user overview page and deleted the role i filter for. Returning to the user overview page results in.. See attached screenshot.AttachmentSizeStatusTest...
View Article