Improve keyboard accessibility in a particular edge case
Problem/MotivationAddress @todo comment on line 121 of ckeditor5.module:// @todo if this triggers the callback via keyboard navigation such as // tab, focus should move to the next element, not to the...
View ArticleRemove deprecated code from the migration system
Problem/MotivationRemove deprecated code from the migration systemd6/Comment d6/UrlAliasLanguage d6/ViewMode field/NodeReferemce destination/EntityContentBase ReviewForm.phpRemove...
View ArticleClean up confusing code in ModuleInstaller that checks for dependencies
In #2885309: [PHP 7.2] each() function is deprecated some code was refactored to remove the use of PHP's each function, since it's been deprecated in PHP 7.2.This patch that was committed was changed...
View ArticleResearch if the CKE off-canvas CSS reset could be optimized
Problem/Motivation#3201820: Manually test that CKE 5 can be used in off-canvas added a CSS reset which makes CKEditor functional in off-canvas. It seems like the solution includes duplicating all CSS...
View ArticleClik here to view.
Multi-select (combobox) list items "escape" bounding box in...
Problem/MotivationMulti-select (combobox) list items "escape" bounding box in off-canvas forms in Chrome. This happened in the past: #3043467: Multi-select list items "escape" bounding box in...
View ArticleBackport Stylelint 14 related changes to 9.3.x
Problem/MotivationIn #3246211: [Revert from 9.3.x needed] Update to Stylelint 14 we upgraded to Stylelint 14, fixed some style violations, and improved the commit-code-check.sh script.This was...
View ArticleThe "bundle" views filter shows options the user doesn't have...
Discovered in Commerce: #3003105: The views bundle (type) filter shows items that the user doesn't have access to.The offered bundles are not filtered for access: public function getValueOptions() { if...
View ArticleMultilingual content: Menu link is not correctly stored on translation.
Problem/MotivationWhen I translate node, the translated menu link item overwrites the original menu item link.This issue was supposedly fixed here: https://www.drupal.org/project/drupal/issues/2599594,...
View ArticleAllow ROLLBACK_PRESERVE option in MigrateSkipRowException
Problem/MotivationWe are migrating a site where content creators are maintaining content simultaneously on both the source and destination. All nodes come over during an initial migration, but if a...
View ArticleAllow altering the post_update run order
Problem/MotivationCurrently all the post_update methods are run on alphabetical order (see UpdateRegistry::getAvailableUpdateFunctions). The documentation suggests adding numerical prefix the update...
View ArticleConvert hook_update_dependencies() to PHP attributes
Problem/Motivationhook_update_dependencies() declares dependencies between hook_update_N() implementations.function hook_update_dependencies() { $dependencies['mymodule'][8001] = [ 'another_module'...
View ArticleOutbound path processors miss the route name
Problem/MotivationIf an outbound path processor is configured to peform some path alterations based on the route then the route name needs to be known. However we pass only the route, but not the...
View Article[drupalMedia] Support alignment on <drupal-media>
Problem/MotivationWith CKEditor 4, data-align attribute can be toggled in the UI. While CKEditor 5 retains the value of existing data-align attributes, it is not possible to change the value through...
View ArticleUntranslated menu items are displayed in menus
Problem/MotivationWe have a very nice translation system in place that is based on translating fields on entities. For many cases this work very well, but in some cases we need to special care. One of...
View ArticleForms inside layout builder in customized page layout break save
Steps to reproduceEnable layout builder on a content type, enable 'Allow each content item to have its layout customized'Create a new node, customize layout on nodeAdd webform (or search form) as a...
View ArticlePHPUnit 9.5.12 (released 2022-01-21) throws unhandled deprecation notice on...
Problem/MotivationNew PHPUnit version 9.5.12 released just now (2022-01-21, see here: https://github.com/sebastianbergmann/phpunit/blob/master/ChangeLog-9.5.md) throws a new, unhandled deprecation...
View ArticleClik here to view.
FilterHtml accepts <*> but does not support it, resulting in inaccurate...
Discovered while working on #3216015: Generate CKEditor 5 configuration based on pre-existing text format configuration for CKEditor...
View ArticleGrouped exposed taxonomy term filters do not work
Problem/MotivationAs mentioned in the issue title, if the exposed filter is based on taxonomy reference field and is a type of "Grouped filter", then it's not working properly. To be more exact, it...
View ArticleUncaught exception 'TypeError' with message 'implode():...
Problem/MotivationI recently upgraded from php7.4 to php8. After the upgrade I stared to see some errors on our logs regarding implode method on asm89/stack-cors. It looks like drupal 9.3.3 requires...
View ArticleAdd YAML support to serialization module
Now that we have serializer support for JSON and XML. The last one it makes sense to implement is YAML. Then we have the most common serialization formats out of the box. Plus, as we already have the...
View Article