Remove theme_more_link() and replace with #type link render arrays
Here is the current code for theme_more_link():<?phpfunction theme_more_link($variables) {Â return '<div class="more-link">'. l(t('More'), $variables['url'], array('attributes'=>...
View ArticleRemove theme_more_help_link() and replace with a #type link render array
Current code<?phpfunction theme_more_help_link($variables) {Â return '<div class="more-help-link">'. l(t('More help'), $variables['url']) . '</div>';}?>Render array to replace...
View ArticleException message when trying to print an object without __toString() in a...
@Berdir mentioned this issue to me today on IRC.Relevant code from twig.engine:<?php if (is_object($arg)) {   if (method_exists($arg, '__toString')) {     return (string) $arg;   }   throw new...
View ArticleColor upgrade path test is broken
When working on #1892006: Seven needs a print stylesheet.. The testbot kept failing on the upgrade path test for the color module. The patch in 4# changed the style.css stylesheet settings from...
View ArticleThe documentation for theme() should be clearer about saying not to call it...
As per #2006152: [meta] Don't call theme() directly anywhere outside drupal_render(), apparently since D7 was launched we're supposed to be calling drupal_render() exclusively and not call theme()...
View ArticleMove theme_container into theme.inc
Theme container adds a div around something. We will be using this for many, many things in core, not just form elements, so it should be moved out of form.inc and into theme.inc.Here are examples of...
View ArticleURLgenerator broken for Drupal installed in a subdirectory - doesn't have a...
When I install Drupal 8 in s subdirectory and use the URLgenerator to create a path with the subdir name repeated 2x:like: http://127.0.0.1:8082/subdir-d8/subdir-d8/admin/structure/views/addThe...
View ArticleEditor's in-place editing AJAX endpoint broken because of #1043198 and...
The exact same frustrations and symptoms as #1996378: Edit broken because of #1043198 and routing system bug + missing test coverage apply here.Due to lack of testing coverage (which is really about...
View ArticleImprove the Views Form API
Views Form is an odd and ugly API.Its basic purpose is to allow field handlers to output form elements, and then validate / process the submission. An example of this is a quantity textfield or delete...
View ArticleBlocks no longer use 'delta'. Remove it from derivative plugins
Block deltas are no longer used by block entities, now that they are identified by their id, but two modules are still using them: aggregator and system.They ought to be removed.
View ArticleAdd unit test for PoHeader::evaluatePlural
The current tests in testGetPluralFormat() do test the plural evaluator. But since the code is fairly complex, it can use some additional test. Below is the code I have used to manually test the code...
View ArticleAdd new views-grid styling to Bartik
The patch at #1903746-44: Replace the views grid table template with one using divs makes the new views grid look a little janky in Bartik. We need to add some styling cleanup and responsive support...
View ArticleAdd amateescu as a Field API and Field UI maintainer
Title says it all, will roll a patch soon as I'm typing this on my phone.
View ArticleThe Place blocks button shows on the Configure block page
When placing a block, the Place blocks button is displayed on the Configure block page.Steps to reproduce:Navigate to admin/structure/block (Structure -> Blocks)Click on the Place blocks...
View ArticleConvert menu local actions to plugins so that we can generate dynamic titles...
Branching off from #1981644: Figure out how to deal with 'title/title callback'Local actions in Drupal 8 that are based on routes cannot handle dynamic titles or paths (e.g. an action link with the...
View ArticleBreadcrumbManager's docblock is a lie
<?php/** * Provides a breadcrumb manager. * * Holds an array of path processor objects and uses them to sequentially process * a path, in order of processor priority. */class BreadcrumbManager...
View ArticleDon't replace the upcasted values in the request attributes array.
While working on #2031473: Convert menu local actions to plugins so that we can generate dynamic titles and paths we realized that the attributes array contains just the upcasted value, but there are...
View ArticleDeleting a view does not empty it's object cache
Steps to reproduce:On the Views list page, click the Add new view buttonConfigure a basic viewClick the Save & edit buttonMake a change but don't save the viewGo back to the Views list pageDelete...
View ArticleThe display breaks, when selecting Restricted HTML for Global: text
Steps to reproduce:On the Views list page, click the Add new view buttonSetup a basic viewClick the Save & edit buttonIn any of the Header, Footer, or No results behavior areas, click the Add...
View ArticleThe text area does not display correctly
Steps to reproduce:In any of the Header, Footer, or No results behavior areas of any view, click the Add buttonSelect either Global: Text area or Global: Unfiltered text and click Apply (all...
View Article