Fix Bartik's comment.html.twig to markup author and creation date in RDFa
Follow up from #1784234: Use schema.org types and properties in RDF mappings where some failing tests revealed that Bartik wasn't marking up some elements in RDFa. rdf.module prepares the submitted...
View ArticleDrupalKernal.php coder review
When I was doing some work on #2002606: Themes don't support their own services.yml file, I noticed a few minor coder issues that should probably be fixed.
View Articleadd a generic Entity test for the hook_entity_operation_alter() that can be...
Follow up for #2027857-18: Blocks operations cannot be alteredUpdated: Comment #0Problem/Motivationfunction hook_entity_operation_alter(array &$operations, \Drupal\Core\Entity\EntityInterface...
View ArticleWeird YAML data
Whilst exploring if we could use the PECL Yaml extension we discovered some strange YAML that it can not parse. See #1920902: Add a Drupal Yaml wrapper so we can default to PECL Yaml component if it is...
View ArticleReplace collection by getCollectionName() in Tempstore
Exceptions when locking tempstore try to use collection protected property while I guess they should use getCollectionName() instead
View ArticleClik here to view.
hook_tour_tips_alter is kinda blocking the Tour writer process
While working on #2017471: Multilingual tour for language section which uses hook_tour_tips_alter tip text is altered. This seems a cool feature but that needs coders instead of Tour writers to fix...
View ArticleUpdate hook_help for Color module
Background: This issue is part of the task to update the hook_help texts of the Drupal 8 modules:#1908570: [meta] Update or create hook_help() texts for D8 core modulesTasks: - review / write the...
View ArticleChange active class in l() function to is-active
Change active class in l() function to is-active according new CSS architecture (for Drupal 8).This change requires change on function it self as well as in all CSS files where active link is...
View ArticleProvide minimal default rest configuration
Many people get tripped up when they are configuring REST for the first time. We should configure it to work with all formats by default... since it is permissioned anyway, it doesn't open up data in...
View ArticleFix tableSort typo in QueryInterface
It says struucture, fixing the typo and the comment length in the patch attached.AttachmentSizeStatusTest resultOperationsstruucture-queryinterface.patch941 bytesIdleFAILED: [[SimpleTest]]: [MySQL]...
View ArticleReturn the called object from setter methods for chaining
Really, this should be a pattern for all our setters across core. It's very useful and basically the behavior I would expect.<?php$entity->setSomething('foo')->setAnotherThing('bar');?>I am...
View ArticleClik here to view.
field_sync_field_status() does not enable fields defined without...
So there's no way to return back fields after module enabled again, also this blocks #731724: Convert comment settings into a field to make them work with CMI and non-node entities which was converted...
View ArticleRemove entity.module - once again.
We discussed that in Portland but I noted that we do not even have an issue for it yet: - It's confusing that we now have mostly everything below \Drupal\Core\Entity but some stuff remains in the...
View ArticleMove all entity API related interfaces to the core component
In preparation for #2031717: Remove entity.module - once again. - let's make sure all interfaces exposed by the entity API are below the core component.Attached patch separates the existing...
View ArticleAdd basic default grid styling to Seven Theme
The patch at #1903746-44: Replace the views grid table template with one using divs makes the new views grid look a little janky in Seven. We need to add some styling cleanup and responsive support for...
View ArticleImprove hook_help for text editor module
The help page should be checked, and a link to the ckeditor as a core module included.
View Articletheme_checkbox() : Few errors in comments
API page: https://api.drupal.org/api/drupal/includes%21form.inc/function/theme_che...Hello, In the comment, i think the parameter #title is no correct, #name is better no? #id is missing and #value is...
View ArticleProvide a RDF wrapper twig template for renderable variables + attributes
Problem/MotivationI am worried about RDF module adding markup into variables in preprocess.We'll want to turn on auto-escape eventually in Twig, and that means we need to keep data separate from markup...
View ArticleInvoke a hook[s] when something happens that makes a block plugin go away
@dawehner pointed me to #2018493: FATAL error when a view with a placed block is disabled or removed, which made me realize that we're letting other code assume things about how block plugins get...
View ArticleRename RenderWrapper, and turn temporary shiv into a more elegant solution...
Follow-up from #2004286: Defer calls to drupal_get_* functions until printed inside a template by adding a RenderWrapper classAt DrupalCamp Colorado today we were talking about the naming and...
View Article